From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-stable@nongnu.org, qemu-devel@nongnu.org,
Jeff Cody <jcody@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] iotests: Add test for rebasing with relative paths
Date: Wed, 9 May 2018 12:24:04 -0500 [thread overview]
Message-ID: <f9bbaffe-2543-929f-7ee2-c41704046416@redhat.com> (raw)
In-Reply-To: <20180509154949.8206-3-mreitz@redhat.com>
On 05/09/2018 10:49 AM, Max Reitz wrote:
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/024 | 82 ++++++++++++++++++++++++++++++++++++++++++++--
> tests/qemu-iotests/024.out | 30 +++++++++++++++++
> 2 files changed, 109 insertions(+), 3 deletions(-)
>
> diff --git a/tests/qemu-iotests/024 b/tests/qemu-iotests/024
> index e0d77ce2f5..4071ed6093 100755
> --- a/tests/qemu-iotests/024
> +++ b/tests/qemu-iotests/024
> @@ -29,9 +29,14 @@ status=1 # failure is the default!
>
> _cleanup()
> {
> - _cleanup_test_img
> - rm -f "$TEST_DIR/t.$IMGFMT.base_old"
> - rm -f "$TEST_DIR/t.$IMGFMT.base_new"
> + _cleanup_test_img
> + rm -f "$TEST_DIR/t.$IMGFMT.base_old"
> + rm -f "$TEST_DIR/t.$IMGFMT.base_new"
> +
> + rm -f "$TEST_DIR/subdir/t.$IMGFMT"
> + rm -f "$TEST_DIR/subdir/t.$IMGFMT.base_old"
> + rm -f "$TEST_DIR/subdir/t.$IMGFMT.base_new"
> + rmdir "$TEST_DIR/subdir" 2> /dev/null
Any easier to just 'rm -rf "$TEST_DIR/subdir"' instead of calling out
individual files? And was Jeff ever going to finish the iotests
cleanups that took care of cleanup globally by running tests in a
per-test directory in preparation for running tests in parallel?
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-05-09 17:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 15:49 [Qemu-devel] [PATCH 0/2] qemu-img: Resolve relative backing paths in rebase Max Reitz
2018-05-09 15:49 ` [Qemu-devel] [PATCH 1/2] " Max Reitz
2018-05-09 17:20 ` Eric Blake
2018-05-09 17:56 ` [Qemu-devel] [Qemu-block] " Max Reitz
2018-05-09 15:49 ` [Qemu-devel] [PATCH 2/2] iotests: Add test for rebasing with relative paths Max Reitz
2018-05-09 17:24 ` Eric Blake [this message]
2018-05-09 17:58 ` [Qemu-devel] [Qemu-block] " Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9bbaffe-2543-929f-7ee2-c41704046416@redhat.com \
--to=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.