From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lHyFk-0004Pq-Ae for mharc-grub-devel@gnu.org; Thu, 04 Mar 2021 19:23:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHyFQ-0004Hm-IO for grub-devel@gnu.org; Thu, 04 Mar 2021 19:23:17 -0500 Received: from mail-qk1-x730.google.com ([2607:f8b0:4864:20::730]:42840) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHyFI-0006Nc-VL for grub-devel@gnu.org; Thu, 04 Mar 2021 19:23:16 -0500 Received: by mail-qk1-x730.google.com with SMTP id z190so326439qka.9 for ; Thu, 04 Mar 2021 16:23:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SMFQqs1lgrd0rIgO85u3MkNerKYEVVo2qfwvc+S8f7k=; b=BBn5Xv0vOziRMO9afGZmLifr9rYD1+NGJoziWmXXdWsbFplnHmiMRBvDJiVjuVhrhw v2dKx7xdI/O5/rBIOhuB4dr/RN2LcbH5Z5jJkJgES7tcpSJPVglK4DEC98JS9pJ10gD3 eJ26rEq/JiwJU9wLofivSs53JIzqHIxZpSVU9uJXRRtJZtAtN/egFagD05gEJs6KFnB3 h5AHXmTlPwbPrwhrh6mNAFc1q0RQXRU+oXIf1nhz9z6mYwvr2CEQ48Ws9mYKXTYQ/SZc oVfzSPMoIisklVklYR/+uOqJlqZw5IxuBQeI8tYreBWxxRuArH25gmz2GEZ92X0hZWHC vPSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SMFQqs1lgrd0rIgO85u3MkNerKYEVVo2qfwvc+S8f7k=; b=IfXZ7x3yv4xEV0d601m060Hf7YSv/0mDsW3rl342REZ/y3Ed10mULuYDpAJFpyHk7E dqiyXzG5HSLcMvQIW8dd7ySPj3bgoCax11Es4Tckd4QIifLjdKwr3wOwG4IVuVFcEq/n 2r1YGi/xAPXnPF5N6tqtmslPqkSHHW+ZLFaeh5bfUg6Z7DiVi+qxMdmEodjPh15rJYKW aK1xZxDaJFzmt3iWflxFAwyYZdZxWWcywnDofbyeKCnFjoT5qRtfHczuJr1k212vw5SG AyFioD+iPU5m3nRWxsGNNcUdgpH5ylHlIwdHNmdJSD5VwcFwE0wnT0Ly3AjQqw/6apA0 wxFw== X-Gm-Message-State: AOAM531wfyTtcbrosX3sbf40bAJZD2zp8McggHEwh/bmuXHp3uE0Sbah zgZDoluS9lnxQ5uLKb2ZgahFNp3lQ6r8Zg== X-Google-Smtp-Source: ABdhPJzOj0quQizWu8h7ldb84beuWYbNjUXu7hp5qTIEL7yfyW2SbZrLeSXiQOBMa5TRiCcGltk8IA== X-Received: by 2002:a37:8947:: with SMTP id l68mr7049521qkd.122.1614903787985; Thu, 04 Mar 2021 16:23:07 -0800 (PST) Received: from localhost.localdomain ([2605:a601:aac5:3700:9763:81c2:19e4:8a8f]) by smtp.gmail.com with ESMTPSA id 75sm674558qkd.114.2021.03.04.16.23.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Mar 2021 16:23:07 -0800 (PST) From: Glenn Washburn To: grub-devel@gnu.org, Daniel Kiper Cc: Glenn Washburn Subject: [PATCH v6 02/14] error: grub_error missing format string argument Date: Thu, 4 Mar 2021 18:22:33 -0600 Message-Id: X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::730; envelope-from=development@efficientek.com; helo=mail-qk1-x730.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2021 00:23:17 -0000 X-List-Received-Date: Fri, 05 Mar 2021 00:23:17 -0000 Its obvious from the error message that the variable named "type" was accidentally omitted. Signed-off-by: Glenn Washburn --- grub-core/parttool/msdospart.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/grub-core/parttool/msdospart.c b/grub-core/parttool/msdospart.c index dcbf74e3b..2e2e9d527 100644 --- a/grub-core/parttool/msdospart.c +++ b/grub-core/parttool/msdospart.c @@ -127,8 +127,8 @@ static grub_err_t grub_pcpart_type (const grub_device_t dev, { dev->disk->partition = part; return grub_error (GRUB_ERR_BAD_ARGUMENT, - N_("the partition type 0x%x isn't " - "valid")); + N_("the partition type 0x%x isn't valid"), + type); } mbr.entries[index].type = type; -- 2.27.0