From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F13B8C433EF for ; Mon, 21 Mar 2022 14:39:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349477AbiCUOkg (ORCPT ); Mon, 21 Mar 2022 10:40:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349455AbiCUOkZ (ORCPT ); Mon, 21 Mar 2022 10:40:25 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA06C12E176; Mon, 21 Mar 2022 07:38:55 -0700 (PDT) X-UUID: 65bb2f0f74004d3d9c0c060ceb518971-20220321 X-UUID: 65bb2f0f74004d3d9c0c060ceb518971-20220321 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 312422891; Mon, 21 Mar 2022 22:38:50 +0800 Received: from mtkexhb01.mediatek.inc (172.21.101.102) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Mon, 21 Mar 2022 22:38:49 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb01.mediatek.inc (172.21.101.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 21 Mar 2022 22:38:49 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 21 Mar 2022 22:38:48 +0800 Message-ID: Subject: Re: [v5 3/4] ASoC: mediatek: mt8192: refactor for I2S8/I2S9 DAI links of headset From: Jiaxin Yu To: Tzung-Bi Shih CC: , , , , , , , , , , , , Date: Mon, 21 Mar 2022 22:38:48 +0800 In-Reply-To: References: <20220319114111.11496-1-jiaxin.yu@mediatek.com> <20220319114111.11496-4-jiaxin.yu@mediatek.com> <17e6e8895ebc1113911481c7e097b394005db123.camel@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2022-03-21 at 17:21 +0800, Tzung-Bi Shih wrote: > On Mon, Mar 21, 2022 at 05:14:08PM +0800, Jiaxin Yu wrote: > > On Mon, 2022-03-21 at 11:59 +0800, Tzung-Bi Shih wrote: > > > On Sat, Mar 19, 2022 at 07:41:10PM +0800, Jiaxin Yu wrote: > > > > @@ -1145,6 +1140,13 @@ static int > > > > mt8192_mt6359_dev_probe(struct > > > > platform_device *pdev) > > > > goto err_speaker_codec; > > > > } > > > > > > > > + headset_codec = of_get_child_by_name(pdev->dev.of_node, > > > > "mediatek,headset-codec"); > > > > + if (!headset_codec) { > > > > + ret = -EINVAL; > > > > + dev_err_probe(&pdev->dev, ret, "Property > > > > 'headset_codec' missing or invalid\n"); > > > > + goto err_headset_codec; > > > > + } > > > > > > (to be neat) Does it have any reason to prevent from using > > > of_parse_phandle() > > > but of_get_child_by_name()? > > > > "mediatek,headset-codec" is a child node of pdev->dev.of_node, so I > > use > > of_get_child_by_name() to get and pass it to > > snd_soc_of_get_dai_link_codecs(). > > "mediatek,platform" and "mediatek,hdmi-codec" are also children of > pdev->dev.of_node. I guess my question is: why doesn't it also use > of_parse_phandle() for "mediatek,headset-codec"? Did I > misunderstand? Hi Tzung-Bi, The following is from bindings, "mediatek,speaker-codec" and "mediatek,headset-codec" are sub nodes of sound but "mediatek,platform" and "mediatek,hdmi-codec" are the name of properties. So we can't get the sub node pointer through of_parse_phandle(). sound: mt8192-sound { compatible = "mediatek,mt8192_mt6359_rt1015_rt5682"; mediatek,platform = <&afe>; mediatek,hdmi-codec = <&anx_bridge_dp>; pinctrl-names = "aud_clk_mosi_off", "aud_clk_mosi_on"; pinctrl-0 = <&aud_clk_mosi_off>; pinctrl-1 = <&aud_clk_mosi_on>; mediatek,headset-codec { sound-dai = <&rt5682>; }; mediatek,speaker-codec { sound-dai = <&rt1015_l>, <&rt1015_r>; }; }; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1671CC433F5 for ; Mon, 21 Mar 2022 14:39:57 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 82C6316F7; Mon, 21 Mar 2022 15:39:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 82C6316F7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1647873595; bh=phaMutTyG4Wzwe/Kp/f/eDK/mbTNH/AiUP2nQxjzlUI=; h=Subject:From:To:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=XH8PcPJPzfgZpZvj8lKaNn5rk8H3HyoU9cbxf2PbO2wmGYbxJKazu7LgCc70ZEUOm oYDP8GtzEw7onAqGHjQMl1mMMOJDuAD4RBOWjxXTdmFZjwXidaW9EireMkZd4HNimF q+a/a37Piv4rZsiqudWEyoE4r1LimQDVLXpkrmrg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0CF43F801D8; Mon, 21 Mar 2022 15:39:05 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3D4FAF80227; Mon, 21 Mar 2022 15:39:03 +0100 (CET) Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id ADC1BF80109 for ; Mon, 21 Mar 2022 15:38:58 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz ADC1BF80109 X-UUID: 65bb2f0f74004d3d9c0c060ceb518971-20220321 X-UUID: 65bb2f0f74004d3d9c0c060ceb518971-20220321 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 312422891; Mon, 21 Mar 2022 22:38:50 +0800 Received: from mtkexhb01.mediatek.inc (172.21.101.102) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Mon, 21 Mar 2022 22:38:49 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb01.mediatek.inc (172.21.101.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 21 Mar 2022 22:38:49 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 21 Mar 2022 22:38:48 +0800 Message-ID: Subject: Re: [v5 3/4] ASoC: mediatek: mt8192: refactor for I2S8/I2S9 DAI links of headset From: Jiaxin Yu To: Tzung-Bi Shih Date: Mon, 21 Mar 2022 22:38:48 +0800 In-Reply-To: References: <20220319114111.11496-1-jiaxin.yu@mediatek.com> <20220319114111.11496-4-jiaxin.yu@mediatek.com> <17e6e8895ebc1113911481c7e097b394005db123.camel@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Cc: devicetree@vger.kernel.org, linmq006@gmail.com, alsa-devel@alsa-project.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com, broonie@kernel.org, linux-mediatek@lists.infradead.org, trevor.wu@mediatek.com, matthias.bgg@gmail.com, aaronyu@google.com, linux-arm-kernel@lists.infradead.org, angelogioacchino.delregno@collabora.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 2022-03-21 at 17:21 +0800, Tzung-Bi Shih wrote: > On Mon, Mar 21, 2022 at 05:14:08PM +0800, Jiaxin Yu wrote: > > On Mon, 2022-03-21 at 11:59 +0800, Tzung-Bi Shih wrote: > > > On Sat, Mar 19, 2022 at 07:41:10PM +0800, Jiaxin Yu wrote: > > > > @@ -1145,6 +1140,13 @@ static int > > > > mt8192_mt6359_dev_probe(struct > > > > platform_device *pdev) > > > > goto err_speaker_codec; > > > > } > > > > > > > > + headset_codec = of_get_child_by_name(pdev->dev.of_node, > > > > "mediatek,headset-codec"); > > > > + if (!headset_codec) { > > > > + ret = -EINVAL; > > > > + dev_err_probe(&pdev->dev, ret, "Property > > > > 'headset_codec' missing or invalid\n"); > > > > + goto err_headset_codec; > > > > + } > > > > > > (to be neat) Does it have any reason to prevent from using > > > of_parse_phandle() > > > but of_get_child_by_name()? > > > > "mediatek,headset-codec" is a child node of pdev->dev.of_node, so I > > use > > of_get_child_by_name() to get and pass it to > > snd_soc_of_get_dai_link_codecs(). > > "mediatek,platform" and "mediatek,hdmi-codec" are also children of > pdev->dev.of_node. I guess my question is: why doesn't it also use > of_parse_phandle() for "mediatek,headset-codec"? Did I > misunderstand? Hi Tzung-Bi, The following is from bindings, "mediatek,speaker-codec" and "mediatek,headset-codec" are sub nodes of sound but "mediatek,platform" and "mediatek,hdmi-codec" are the name of properties. So we can't get the sub node pointer through of_parse_phandle(). sound: mt8192-sound { compatible = "mediatek,mt8192_mt6359_rt1015_rt5682"; mediatek,platform = <&afe>; mediatek,hdmi-codec = <&anx_bridge_dp>; pinctrl-names = "aud_clk_mosi_off", "aud_clk_mosi_on"; pinctrl-0 = <&aud_clk_mosi_off>; pinctrl-1 = <&aud_clk_mosi_on>; mediatek,headset-codec { sound-dai = <&rt5682>; }; mediatek,speaker-codec { sound-dai = <&rt1015_l>, <&rt1015_r>; }; }; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BF8EC433EF for ; Mon, 21 Mar 2022 14:49:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xhiOsVdAN8Z/zE9RadQe3T3Sm0q03+elU3S1lYvP2/s=; b=qJMAyuBPyTrNcv SFHq7j8H12IS0N/7dA+d3IGVwj8z3YjOMLywJR07rwYfym4pYiYT1t+4iNiQqEU8ggw46oVYplSEo T5diSYIEc9PmUt4F72jsO15fOrB3x06id58AAIVZkd02g1SiunNXVucEouEyTLw2lYrzgtBIFY7tG oHQT6UbSZfvuGrvdN2rglso/iwFjrbWag9Igjh+mA24+RIm11cgyFeNy3isZiLcSUudeaqT/WGhoe MS+iNQbNz/QxFmR+E025vf4CYUz2motEtfuyuf51pxqX61o8r42Uu7yPseQSk81febsr8mbNf8AVW P3AsZcaRBKzpkVQRNCPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWJL9-0084wz-FG; Mon, 21 Mar 2022 14:48:59 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWJL5-0084w5-RG; Mon, 21 Mar 2022 14:48:58 +0000 X-UUID: 9309348abbbf420694731b3b1e9163d0-20220321 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=gykCg0clZoz78nUMV2so48mdtJcOUt7USfRg0Ey8tC0=; b=uE4wPtH+AMH564Vy3vQz4T/659DcuCDUuxdYqhMg46n/uyk4/zEO5ILTMlU9RayRks5dTQR5ogT+IrrmUnolyapKu1QKaSlHxyQqpa7ExqLTX1YSgnqb5Moq7tfC/FRv70Udl6aKv815ZRkXpI2sDg6Axt4shfWp6NWz05wsFDU=; X-UUID: 9309348abbbf420694731b3b1e9163d0-20220321 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 823571866; Mon, 21 Mar 2022 07:48:52 -0700 Received: from mtkexhb01.mediatek.inc (172.21.101.102) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 21 Mar 2022 07:38:50 -0700 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb01.mediatek.inc (172.21.101.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 21 Mar 2022 22:38:49 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 21 Mar 2022 22:38:48 +0800 Message-ID: Subject: Re: [v5 3/4] ASoC: mediatek: mt8192: refactor for I2S8/I2S9 DAI links of headset From: Jiaxin Yu To: Tzung-Bi Shih CC: , , , , , , , , , , , , Date: Mon, 21 Mar 2022 22:38:48 +0800 In-Reply-To: References: <20220319114111.11496-1-jiaxin.yu@mediatek.com> <20220319114111.11496-4-jiaxin.yu@mediatek.com> <17e6e8895ebc1113911481c7e097b394005db123.camel@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220321_074855_914882_24797F2F X-CRM114-Status: GOOD ( 17.65 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 2022-03-21 at 17:21 +0800, Tzung-Bi Shih wrote: > On Mon, Mar 21, 2022 at 05:14:08PM +0800, Jiaxin Yu wrote: > > On Mon, 2022-03-21 at 11:59 +0800, Tzung-Bi Shih wrote: > > > On Sat, Mar 19, 2022 at 07:41:10PM +0800, Jiaxin Yu wrote: > > > > @@ -1145,6 +1140,13 @@ static int > > > > mt8192_mt6359_dev_probe(struct > > > > platform_device *pdev) > > > > goto err_speaker_codec; > > > > } > > > > > > > > + headset_codec = of_get_child_by_name(pdev->dev.of_node, > > > > "mediatek,headset-codec"); > > > > + if (!headset_codec) { > > > > + ret = -EINVAL; > > > > + dev_err_probe(&pdev->dev, ret, "Property > > > > 'headset_codec' missing or invalid\n"); > > > > + goto err_headset_codec; > > > > + } > > > > > > (to be neat) Does it have any reason to prevent from using > > > of_parse_phandle() > > > but of_get_child_by_name()? > > > > "mediatek,headset-codec" is a child node of pdev->dev.of_node, so I > > use > > of_get_child_by_name() to get and pass it to > > snd_soc_of_get_dai_link_codecs(). > > "mediatek,platform" and "mediatek,hdmi-codec" are also children of > pdev->dev.of_node. I guess my question is: why doesn't it also use > of_parse_phandle() for "mediatek,headset-codec"? Did I > misunderstand? Hi Tzung-Bi, The following is from bindings, "mediatek,speaker-codec" and "mediatek,headset-codec" are sub nodes of sound but "mediatek,platform" and "mediatek,hdmi-codec" are the name of properties. So we can't get the sub node pointer through of_parse_phandle(). sound: mt8192-sound { compatible = "mediatek,mt8192_mt6359_rt1015_rt5682"; mediatek,platform = <&afe>; mediatek,hdmi-codec = <&anx_bridge_dp>; pinctrl-names = "aud_clk_mosi_off", "aud_clk_mosi_on"; pinctrl-0 = <&aud_clk_mosi_off>; pinctrl-1 = <&aud_clk_mosi_on>; mediatek,headset-codec { sound-dai = <&rt5682>; }; mediatek,speaker-codec { sound-dai = <&rt1015_l>, <&rt1015_r>; }; }; _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13F2AC433EF for ; Mon, 21 Mar 2022 14:50:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eaRYRaVAqXufvZpuojDP41/6RqaJWoCsnZnxOyJhN2E=; b=K9dkWg8FJGO1N8 oH1iQD/nTaCn44SIPQ6iiZVQU3Dofj2b/FWtJozJQ0YwiWoNbqlyLaUNpHqadIBxqsIUQ50WLJL1I zoUM8vmY9KKF6l5Rcu7IRq+RqD5LGpC9GvuF1XrqDfIz+o86UauGjZRQcliWN35kwYoC+sqwqDGOd yxdic+4mJbWU93jsNMH9kX7FjQxPm4IUMOkHBpiFJAOVmpK2qJDl+v7z+JvrQix/XQDePEPG0kOYA NcbK4+YAWQnAGOX8xjdtzR9KTCezrMbFn8t9Q6YRYigWa29JkbRxmBLivCQb8Jb2v089QAKle/frv e1L0LSy7SkKB5nmBJUfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWJLA-0084x8-W1; Mon, 21 Mar 2022 14:49:01 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWJL5-0084w5-RG; Mon, 21 Mar 2022 14:48:58 +0000 X-UUID: 9309348abbbf420694731b3b1e9163d0-20220321 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=gykCg0clZoz78nUMV2so48mdtJcOUt7USfRg0Ey8tC0=; b=uE4wPtH+AMH564Vy3vQz4T/659DcuCDUuxdYqhMg46n/uyk4/zEO5ILTMlU9RayRks5dTQR5ogT+IrrmUnolyapKu1QKaSlHxyQqpa7ExqLTX1YSgnqb5Moq7tfC/FRv70Udl6aKv815ZRkXpI2sDg6Axt4shfWp6NWz05wsFDU=; X-UUID: 9309348abbbf420694731b3b1e9163d0-20220321 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 823571866; Mon, 21 Mar 2022 07:48:52 -0700 Received: from mtkexhb01.mediatek.inc (172.21.101.102) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 21 Mar 2022 07:38:50 -0700 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb01.mediatek.inc (172.21.101.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 21 Mar 2022 22:38:49 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 21 Mar 2022 22:38:48 +0800 Message-ID: Subject: Re: [v5 3/4] ASoC: mediatek: mt8192: refactor for I2S8/I2S9 DAI links of headset From: Jiaxin Yu To: Tzung-Bi Shih CC: , , , , , , , , , , , , Date: Mon, 21 Mar 2022 22:38:48 +0800 In-Reply-To: References: <20220319114111.11496-1-jiaxin.yu@mediatek.com> <20220319114111.11496-4-jiaxin.yu@mediatek.com> <17e6e8895ebc1113911481c7e097b394005db123.camel@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220321_074855_914882_24797F2F X-CRM114-Status: GOOD ( 17.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2022-03-21 at 17:21 +0800, Tzung-Bi Shih wrote: > On Mon, Mar 21, 2022 at 05:14:08PM +0800, Jiaxin Yu wrote: > > On Mon, 2022-03-21 at 11:59 +0800, Tzung-Bi Shih wrote: > > > On Sat, Mar 19, 2022 at 07:41:10PM +0800, Jiaxin Yu wrote: > > > > @@ -1145,6 +1140,13 @@ static int > > > > mt8192_mt6359_dev_probe(struct > > > > platform_device *pdev) > > > > goto err_speaker_codec; > > > > } > > > > > > > > + headset_codec = of_get_child_by_name(pdev->dev.of_node, > > > > "mediatek,headset-codec"); > > > > + if (!headset_codec) { > > > > + ret = -EINVAL; > > > > + dev_err_probe(&pdev->dev, ret, "Property > > > > 'headset_codec' missing or invalid\n"); > > > > + goto err_headset_codec; > > > > + } > > > > > > (to be neat) Does it have any reason to prevent from using > > > of_parse_phandle() > > > but of_get_child_by_name()? > > > > "mediatek,headset-codec" is a child node of pdev->dev.of_node, so I > > use > > of_get_child_by_name() to get and pass it to > > snd_soc_of_get_dai_link_codecs(). > > "mediatek,platform" and "mediatek,hdmi-codec" are also children of > pdev->dev.of_node. I guess my question is: why doesn't it also use > of_parse_phandle() for "mediatek,headset-codec"? Did I > misunderstand? Hi Tzung-Bi, The following is from bindings, "mediatek,speaker-codec" and "mediatek,headset-codec" are sub nodes of sound but "mediatek,platform" and "mediatek,hdmi-codec" are the name of properties. So we can't get the sub node pointer through of_parse_phandle(). sound: mt8192-sound { compatible = "mediatek,mt8192_mt6359_rt1015_rt5682"; mediatek,platform = <&afe>; mediatek,hdmi-codec = <&anx_bridge_dp>; pinctrl-names = "aud_clk_mosi_off", "aud_clk_mosi_on"; pinctrl-0 = <&aud_clk_mosi_off>; pinctrl-1 = <&aud_clk_mosi_on>; mediatek,headset-codec { sound-dai = <&rt5682>; }; mediatek,speaker-codec { sound-dai = <&rt1015_l>, <&rt1015_r>; }; }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel