From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932185AbcHIPLF (ORCPT ); Tue, 9 Aug 2016 11:11:05 -0400 Received: from mga03.intel.com ([134.134.136.65]:30466 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752761AbcHIPLA convert rfc822-to-8bit (ORCPT ); Tue, 9 Aug 2016 11:11:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,495,1464678000"; d="scan'208";a="1011237373" Subject: Re: [Intel-wired-lan] e1000e: PHY cann't be initialized correctly on some I218 controllers To: Denis Turischev , intel-wired-lan@lists.osuosl.org, "Brown, Aaron F" , Jeff Kirsher References: <579F407E.9090602@compulab.co.il> <1e8f37ec-eda4-eb2d-64d2-e96a7aa71902@intel.com> <57A6F7A9.1030401@compulab.co.il> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Raanan Avargil Message-ID: Date: Tue, 9 Aug 2016 18:10:53 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <57A6F7A9.1030401@compulab.co.il> Content-Type: text/plain; charset="windows-1252"; format="flowed" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/7/2016 11:56, Denis Turischev wrote: > Hi Raanan, > > On 08/04/2016 07:18 PM, Raanan Avargil wrote: >> It is hard to determine what is exactly the problem here and what causes the -3 error, but this is not the place to perform hw reset and retry to init the phy. > I agree that may be this is not the correct place for hw reset, can you advice about another solution? > > It works, not only for me, for example it helps here: > http://www.linux.org.ru/forum/linux-hardware/10268216 > > Another fact that Windows drivers work fine with the same hw. > > Denis > Hi Denis, More suitable place to retry init the device would be in probe function. However, we haven't seen initialization issues like this on i218. Adding Aaron. @Aaron - have you seen initialization errors on i218 devices? Raanan --------------------------------------------------------------------- Intel Israel (74) Limited This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Raanan Avargil Date: Tue, 9 Aug 2016 18:10:53 +0300 Subject: [Intel-wired-lan] e1000e: PHY cann't be initialized correctly on some I218 controllers In-Reply-To: <57A6F7A9.1030401@compulab.co.il> References: <579F407E.9090602@compulab.co.il> <1e8f37ec-eda4-eb2d-64d2-e96a7aa71902@intel.com> <57A6F7A9.1030401@compulab.co.il> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On 8/7/2016 11:56, Denis Turischev wrote: > Hi Raanan, > > On 08/04/2016 07:18 PM, Raanan Avargil wrote: >> It is hard to determine what is exactly the problem here and what causes the -3 error, but this is not the place to perform hw reset and retry to init the phy. > I agree that may be this is not the correct place for hw reset, can you advice about another solution? > > It works, not only for me, for example it helps here: > http://www.linux.org.ru/forum/linux-hardware/10268216 > > Another fact that Windows drivers work fine with the same hw. > > Denis > Hi Denis, More suitable place to retry init the device would be in probe function. However, we haven't seen initialization issues like this on i218. Adding Aaron. @Aaron - have you seen initialization errors on i218 devices? Raanan --------------------------------------------------------------------- Intel Israel (74) Limited This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.