From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98E7DC433EF for ; Mon, 11 Oct 2021 09:09:27 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id C97E360F35 for ; Mon, 11 Oct 2021 09:09:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C97E360F35 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=oktetlabs.ru Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE97340E01; Mon, 11 Oct 2021 11:09:25 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id B1C0440142 for ; Mon, 11 Oct 2021 11:09:24 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id B7D217F51B; Mon, 11 Oct 2021 12:09:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B7D217F51B DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1633943364; bh=lmqARWmv8FgmJAQ9+2q9zUmulp+X97LIBG6K54Alg9I=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=b7vKghuUkVkntsQi1YDP1uCnPkJJLB+EtX2Ai/5ehF0GLDtiKFCxY7f+YthiRMFdY bZq1Q2jm0XovGn5ATiR01mjz1vOQb01iC6onk45kjxVUjC0WY0DXQw/TbSYanObVt9 XV9OmPKEUwSe8Zhg0QbGkDAewhm0zteRxh4/jF5M= To: Konstantin Ananyev , dev@dpdk.org Cc: xiaoyun.li@intel.com, anoobj@marvell.com, jerinj@marvell.com, ndabilpuram@marvell.com, adwivedi@marvell.com, shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com, john.miller@atomicrules.com, irusskikh@marvell.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, rahul.lakkireddy@chelsio.com, hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, haiyue.wang@intel.com, johndale@cisco.com, hyonkim@cisco.com, qi.z.zhang@intel.com, xiao.w.wang@intel.com, humin29@huawei.com, yisen.zhuang@huawei.com, oulijun@huawei.com, beilei.xing@intel.com, jingjing.wu@intel.com, qiming.yang@intel.com, matan@nvidia.com, viacheslavo@nvidia.com, sthemmin@microsoft.com, longli@microsoft.com, heinrich.kuhn@corigine.com, kirankumark@marvell.com, mczekaj@marvell.com, jiawenwu@trustnetic.com, jianwang@trustnetic.com, maxime.coquelin@redhat.com, chenbo.xia@intel.com, thomas@monjalon.net, ferruh.yigit@intel.com, mdr@ashroe.eu, jay.jayatheerthan@intel.com References: <20211004135603.20593-1-konstantin.ananyev@intel.com> <20211007112750.25526-1-konstantin.ananyev@intel.com> <20211007112750.25526-7-konstantin.ananyev@intel.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Mon, 11 Oct 2021 12:09:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211007112750.25526-7-konstantin.ananyev@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 6/7] ethdev: add API to retrieve multiple ethernet addresses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/7/21 2:27 PM, Konstantin Ananyev wrote: > Introduce rte_eth_macaddrs_get() to allow user to retrieve all ethernet > addresses assigned to given port. > Change testpmd to use this new function and avoid referencing directly > rte_eth_devices[]. > > Signed-off-by: Konstantin Ananyev [snip] > diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c > index 9f7a0cbb8c..83b57a7524 100644 > --- a/lib/ethdev/rte_ethdev.c > +++ b/lib/ethdev/rte_ethdev.c > @@ -3573,6 +3573,31 @@ rte_eth_dev_set_ptypes(uint16_t port_id, uint32_t ptype_mask, > return ret; > } > > +int > +rte_eth_macaddrs_get(uint16_t port_id, struct rte_ether_addr ma[], uint32_t num) Do we really need fixed size type in the case of num? Shouldn't it be just 'unsigned int' as the default choice for a number of elements? > +{ > + int32_t ret; > + struct rte_eth_dev *dev; > + struct rte_eth_dev_info dev_info; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > + dev = &rte_eth_devices[port_id]; > + > + ret = rte_eth_dev_info_get(port_id, &dev_info); > + if (ret != 0) > + return ret; In theory we can rely on port_id check in rte_eth_dev_info_get() on success to avoid duplicate checks. I'd do it and just highlight it in a comment. > + > + if (ma == NULL) { > + RTE_ETHDEV_LOG(ERR, "%s: invalid parameters\n", __func__); > + return -EINVAL; > + } > + > + num = RTE_MIN(dev_info.max_mac_addrs, num); > + memcpy(ma, dev->data->mac_addrs, num * sizeof(ma[0])); > + > + return num; > +} > + > int > rte_eth_macaddr_get(uint16_t port_id, struct rte_ether_addr *mac_addr) > { > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index c0e1a40681..77314ecf24 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -3037,6 +3037,27 @@ int rte_eth_dev_set_rx_queue_stats_mapping(uint16_t port_id, > */ > int rte_eth_macaddr_get(uint16_t port_id, struct rte_ether_addr *mac_addr); > > +/** > + * Retrieve the Ethernet addresses of an Ethernet device. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param ma > + * A pointer to an array of structures of type *ether_addr* to be filled with > + * the Ethernet addresses of the Ethernet device. > + * @param num > + * Number of elements in the *ma* array. *ma* -> @p ma > + * Note that rte_eth_dev_info::max_mac_addrs can be used to retrieve > + * max number of Ethernet addresses for given port. > + * @return > + * - number of retrieved addresses if successful > + * - (-ENODEV) if *port_id* invalid. > + * - (-EINVAL) if bad parameter. > + */ > +__rte_experimental > +int rte_eth_macaddrs_get(uint16_t port_id, struct rte_ether_addr *ma, > + uint32_t num); > + > /** > * Retrieve the contextual information of an Ethernet device. > * > diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map > index 79e62dcf61..2bad712958 100644 > --- a/lib/ethdev/version.map > +++ b/lib/ethdev/version.map > @@ -250,6 +250,9 @@ EXPERIMENTAL { > rte_mtr_meter_policy_delete; > rte_mtr_meter_policy_update; > rte_mtr_meter_policy_validate; > + > + # added in 21.11 > + rte_eth_macaddrs_get; > }; > > INTERNAL { >