From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8FF6C433E3 for ; Tue, 21 Jul 2020 06:16:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E4E9206E9 for ; Tue, 21 Jul 2020 06:16:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727809AbgGUGQf (ORCPT ); Tue, 21 Jul 2020 02:16:35 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:7802 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725294AbgGUGQf (ORCPT ); Tue, 21 Jul 2020 02:16:35 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 60ACBE0D13EC4424A248; Tue, 21 Jul 2020 14:16:32 +0800 (CST) Received: from [127.0.0.1] (10.174.178.16) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Tue, 21 Jul 2020 14:16:28 +0800 Subject: Re: [PATCH] net-sysfs: add a newline when printing 'tx_timeout' by sysfs To: David Miller CC: , , References: <1595243869-57100-1-git-send-email-wangxiongfeng2@huawei.com> <20200720.174432.702526374205425580.davem@davemloft.net> From: Xiongfeng Wang Message-ID: Date: Tue, 21 Jul 2020 14:16:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200720.174432.702526374205425580.davem@davemloft.net> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.16] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2020/7/21 8:44, David Miller wrote: > From: Xiongfeng Wang > Date: Mon, 20 Jul 2020 19:17:49 +0800 > >> - return sprintf(buf, "%lu", trans_timeout); >> + return sprintf(buf, "%lu\n", trans_timeout); > > Better to replace it with 'fmt_ulong'. Thanks for your advice. I will change it in the next version. Thanks, Xiongfeng > > . >