From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAE5FC433EF for ; Tue, 8 Mar 2022 17:50:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348709AbiCHRvY (ORCPT ); Tue, 8 Mar 2022 12:51:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236729AbiCHRvX (ORCPT ); Tue, 8 Mar 2022 12:51:23 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5DDE354FA8 for ; Tue, 8 Mar 2022 09:50:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646761826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HhVq4NG09Yd9b8QvgLRVbkikFbdePpQBri7vAnREkiw=; b=c3nVvjDYY+/sC6BIyguvMlprBpkpkVcsYhp7PJPAUk1iaOt6/s096ca0RIPx22TKrUeB7r 5YpWB/mXbYSayb4/RgHAWfTg/j1GS5V0uaPThU9X+Mb8LweN8DRZezoVmd/lr280dG3J0H WMv1DKoXtX4PDht5YiZE/Vb6bsINRrA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-9-5LHLgx3_PPaSrZ7d8xJVWA-1; Tue, 08 Mar 2022 12:50:25 -0500 X-MC-Unique: 5LHLgx3_PPaSrZ7d8xJVWA-1 Received: by mail-wm1-f72.google.com with SMTP id 14-20020a05600c104e00b003897a167353so1400186wmx.8 for ; Tue, 08 Mar 2022 09:50:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=HhVq4NG09Yd9b8QvgLRVbkikFbdePpQBri7vAnREkiw=; b=ny6A7kwcnOlmRcUB95B67NQDFkNBa1/hLmxw9kIomBELEbm2QKOLMHvv7nb6extZT2 SFFaf0/28JUUSiS2IuT71uB3NksLHJvzH/1VcW4tlrKTBlpY8SqwT4t/Ez24A40BrxwV SRyREIixiVnNhY0MzhbG5Mr+SOgJDfJzxJRXaVO0M4Ll0/MpBXE9k32RPu5eWSlOE3JT ZaaFSLVYoF4xX5Q8PJKvexxp6jFQV60DDpGWvJbrKdt3QqLWOJQM2KAYULGCSy7QTkKq 159vK5C+CawTuV0vOqBYdX6EJ3OlKd+YKFKZZA+npLQIpHvwSfrVfJNCNCwvTyk4o1lN nE4w== X-Gm-Message-State: AOAM530sdAQZtMRHFS7d77Y9uQvmXY0Klb93iejcQZEOj9Vmn96/pOuI EFoAUlKSHoNB+cDqgt0IeVQ1J6sP8h7uZR28h2qtT92wAp/JPgXBv9leOuv/l8VRA8I6aLJE/+I N436SvMaNYdvhwWGABHUavcpX X-Received: by 2002:a5d:4e83:0:b0:1ea:99dd:d335 with SMTP id e3-20020a5d4e83000000b001ea99ddd335mr13761151wru.16.1646761824303; Tue, 08 Mar 2022 09:50:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJxXaKH7qtJ3XhWUyVWnDr9kUvihmBN1ZTa2EX+LmoDkmO7GAo9fIS2kQhFvn2eyi1VE4qRY9w== X-Received: by 2002:a5d:4e83:0:b0:1ea:99dd:d335 with SMTP id e3-20020a5d4e83000000b001ea99ddd335mr13761137wru.16.1646761824103; Tue, 08 Mar 2022 09:50:24 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.googlemail.com with ESMTPSA id g6-20020a5d5406000000b001f049726044sm14439971wrv.79.2022.03.08.09.50.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Mar 2022 09:50:23 -0800 (PST) Message-ID: Date: Tue, 8 Mar 2022 18:50:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 11/25] KVM: x86/mmu: remove kvm_calc_shadow_root_page_role_common Content-Language: en-US To: Sean Christopherson Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, dmatlack@google.com References: <20220221162243.683208-1-pbonzini@redhat.com> <20220221162243.683208-12-pbonzini@redhat.com> From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/8/22 18:48, Sean Christopherson wrote: > On Mon, Feb 21, 2022, Paolo Bonzini wrote: >> kvm_calc_shadow_root_page_role_common is the same as >> kvm_calc_cpu_mode except for the level, which is overwritten >> afterwards in kvm_calc_shadow_mmu_root_page_role >> and kvm_calc_shadow_npt_root_page_role. >> >> role.base.direct is already set correctly for the CPU mode, >> and CR0.PG=1 is required for VMRUN so it will also be >> correct for nested NPT. > > Bzzzt, this is wrong, the nested NPT MMU is indirect but will be computed as direct. CR0.PG=1 means it's *not* direct: > + role.base.direct = !____is_cr0_pg(regs); Paolo