From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 630F3C433E0 for ; Tue, 16 Feb 2021 09:21:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B82964DA1 for ; Tue, 16 Feb 2021 09:21:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229780AbhBPJVP (ORCPT ); Tue, 16 Feb 2021 04:21:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229676AbhBPJVM (ORCPT ); Tue, 16 Feb 2021 04:21:12 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC47FC061574 for ; Tue, 16 Feb 2021 01:20:31 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id n4so9104019wrx.1 for ; Tue, 16 Feb 2021 01:20:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Y41IhIT5rmyhijmxjT00xgQ2ngQOKXy/8+FZLhjS7GU=; b=PxauwfY1W0W8GqfSltTB89uf6BjLJooazi+FICLO0MYpouhyA0zCMNy/swKF6XKIoh WsaHV9J+g1NdDbZ9mwlZF+9R9q2iEAAVGQYNGmT2dM45p72c9nsJVRHRYZKPWq0G0oA+ byAQAESeOHqZrMxjphuom8fRhS6b9fVv1OdeHUnEesoP3gb8Y7ZBO4k4N2AjsTxoocgL U2gSRuxYygA1CH18shWiRRHx10hdlr2tw6PZKhP3WdsEa+j0F7dT1YRG6V1q6R7QFFqy O3sbFg2uteZhZTzQvmOQlc9ejWpPs+SRndc/kWh0MeRlQ3iK8Sx+g/OHjazrikiPC6po deLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Y41IhIT5rmyhijmxjT00xgQ2ngQOKXy/8+FZLhjS7GU=; b=R7sjy9cXvk6Y7RxUZ9r1uKoUz4H3o26azmF6VQxvw01mcm2OWfMhN8dKz7QHGzyPHL QtayLcjoWa4Cr9f2qTbENM5JVIBBeKqb+tW9fNEJKr8lAkNi4N56MoqAYPt7DboTPr2R E/jDT/TqFE7A0mmd3kVtVepw3XofZiz2cTN/RRNneT7VVpWQmlfMGERhARdlYabihTGK Hm+fmSXZyn6TRvz7f9xpdH63pLJt3KSxa/4NJgrsA9/pYjpS5CsDW89wq1mUgu4cbcV9 BIsT/HTeyToSJsiGAoVqaXYU9aOa3hZxYeExqHzfn47Ftc/h3iB5v6Jjj8QrYbf7dkfY r2RA== X-Gm-Message-State: AOAM532Q7EGG82nkihY27rO16Er/ZB/wdBSot+3cbbjAwgG9bcDUiIFQ bSpheI/S9Iwx+CTnP3Nd9D9XGVQAGCI4qA== X-Google-Smtp-Source: ABdhPJw8rKubCzEnbeZl2jrx0DqZqg91MIvyR1rs/pdj5gKareeA2mPpfeRZmBDxtI2dC5k3rnMMiw== X-Received: by 2002:adf:dcd2:: with SMTP id x18mr22981959wrm.355.1613467230465; Tue, 16 Feb 2021 01:20:30 -0800 (PST) Received: from ?IPv6:2003:ea:8f39:5b00:ac39:e452:593c:61b5? (p200300ea8f395b00ac39e452593c61b5.dip0.t-ipconnect.de. [2003:ea:8f39:5b00:ac39:e452:593c:61b5]) by smtp.googlemail.com with ESMTPSA id w9sm2651356wmk.16.2021.02.16.01.20.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Feb 2021 01:20:30 -0800 (PST) Subject: Re: [PATCH v3] staging: fix coding style in driver/staging/qlge/qlge_main.c To: Du Cheng , Manish Chopra Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, netdev@vger.kernel.org References: <20210216085326.178912-1-ducheng2@gmail.com> From: Heiner Kallweit Message-ID: Date: Tue, 16 Feb 2021 10:20:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210216085326.178912-1-ducheng2@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 16.02.2021 09:53, Du Cheng wrote: > align * in block comments on each line > > changes v3: > - add SUBSYSTEM in subject line > - add explanation to past version of this patch > > changes v2: > - move closing of comment to the same line > > changes v1: > - align * in block comments > > Signed-off-by: Du Cheng > --- > drivers/staging/qlge/qlge_main.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c > index 5516be3af898..2682a0e474bd 100644 > --- a/drivers/staging/qlge/qlge_main.c > +++ b/drivers/staging/qlge/qlge_main.c > @@ -3815,8 +3815,7 @@ static int qlge_adapter_down(struct qlge_adapter *qdev) > > qlge_tx_ring_clean(qdev); > > - /* Call netif_napi_del() from common point. > - */ > + /* Call netif_napi_del() from common point. */ > for (i = 0; i < qdev->rss_ring_count; i++) > netif_napi_del(&qdev->rx_ring[i].napi); > > Typically such trivial patches aren't much appreciated for staging drivers. In the case here I have doubts that the comment as such provides any benefit. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50709C433E0 for ; Tue, 16 Feb 2021 09:20:35 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED27364DA1 for ; Tue, 16 Feb 2021 09:20:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED27364DA1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id A8FC487053; Tue, 16 Feb 2021 09:20:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SY-XUobp0Wxb; Tue, 16 Feb 2021 09:20:34 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 2EB6086FF9; Tue, 16 Feb 2021 09:20:34 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id C31931BF285 for ; Tue, 16 Feb 2021 09:20:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id BFD40855A1 for ; Tue, 16 Feb 2021 09:20:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CBxINQ06nX-u for ; Tue, 16 Feb 2021 09:20:32 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 16C348553B for ; Tue, 16 Feb 2021 09:20:32 +0000 (UTC) Received: by mail-wr1-f49.google.com with SMTP id v15so12079192wrx.4 for ; Tue, 16 Feb 2021 01:20:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Y41IhIT5rmyhijmxjT00xgQ2ngQOKXy/8+FZLhjS7GU=; b=PxauwfY1W0W8GqfSltTB89uf6BjLJooazi+FICLO0MYpouhyA0zCMNy/swKF6XKIoh WsaHV9J+g1NdDbZ9mwlZF+9R9q2iEAAVGQYNGmT2dM45p72c9nsJVRHRYZKPWq0G0oA+ byAQAESeOHqZrMxjphuom8fRhS6b9fVv1OdeHUnEesoP3gb8Y7ZBO4k4N2AjsTxoocgL U2gSRuxYygA1CH18shWiRRHx10hdlr2tw6PZKhP3WdsEa+j0F7dT1YRG6V1q6R7QFFqy O3sbFg2uteZhZTzQvmOQlc9ejWpPs+SRndc/kWh0MeRlQ3iK8Sx+g/OHjazrikiPC6po deLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Y41IhIT5rmyhijmxjT00xgQ2ngQOKXy/8+FZLhjS7GU=; b=tdu80Q9OW6GvD8Pd+lncs9+kE2ZoVNr5Ioav/2/2cXSH/ffMIUgf3pHikWkvoBWq8F iDXfWBzPbIBmBdmlw/jbnLf3evSiC92wHxHi4XjCyDiMkliFK7nlaJ35Fc4oQvkSs4lT TvTFA3QrOPd1ZUr/SvCFx5oVkCdD4I4Y6G9InQLVx31m1Bx1LgBY3eVDklrJE/jT30OP qrO32TId093EkXEpdSCqe+LU8PybsGSBwhbQ9SsSlkCbh8Bco9idwhzSr/Ls35W6UPSE UQU/czGEi7Rg2WYN+S+IZwpss7PElpaYV7GOfAIJHlX/MJ7a0Vn944KyyTaB6+uMTQh7 zSkg== X-Gm-Message-State: AOAM533L6sSO7Hz/ex75rHB6f0g2Tme6uG9NVcSdCqJ7XWtjCjnfHC01 YLSE02yRQDZ88ZhOVmIqxBc= X-Google-Smtp-Source: ABdhPJw8rKubCzEnbeZl2jrx0DqZqg91MIvyR1rs/pdj5gKareeA2mPpfeRZmBDxtI2dC5k3rnMMiw== X-Received: by 2002:adf:dcd2:: with SMTP id x18mr22981959wrm.355.1613467230465; Tue, 16 Feb 2021 01:20:30 -0800 (PST) Received: from ?IPv6:2003:ea:8f39:5b00:ac39:e452:593c:61b5? (p200300ea8f395b00ac39e452593c61b5.dip0.t-ipconnect.de. [2003:ea:8f39:5b00:ac39:e452:593c:61b5]) by smtp.googlemail.com with ESMTPSA id w9sm2651356wmk.16.2021.02.16.01.20.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Feb 2021 01:20:30 -0800 (PST) Subject: Re: [PATCH v3] staging: fix coding style in driver/staging/qlge/qlge_main.c To: Du Cheng , Manish Chopra References: <20210216085326.178912-1-ducheng2@gmail.com> From: Heiner Kallweit Message-ID: Date: Tue, 16 Feb 2021 10:20:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210216085326.178912-1-ducheng2@gmail.com> Content-Language: en-US X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , netdev@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On 16.02.2021 09:53, Du Cheng wrote: > align * in block comments on each line > > changes v3: > - add SUBSYSTEM in subject line > - add explanation to past version of this patch > > changes v2: > - move closing of comment to the same line > > changes v1: > - align * in block comments > > Signed-off-by: Du Cheng > --- > drivers/staging/qlge/qlge_main.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c > index 5516be3af898..2682a0e474bd 100644 > --- a/drivers/staging/qlge/qlge_main.c > +++ b/drivers/staging/qlge/qlge_main.c > @@ -3815,8 +3815,7 @@ static int qlge_adapter_down(struct qlge_adapter *qdev) > > qlge_tx_ring_clean(qdev); > > - /* Call netif_napi_del() from common point. > - */ > + /* Call netif_napi_del() from common point. */ > for (i = 0; i < qdev->rss_ring_count; i++) > netif_napi_del(&qdev->rx_ring[i].napi); > > Typically such trivial patches aren't much appreciated for staging drivers. In the case here I have doubts that the comment as such provides any benefit. _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel