From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Yongseok Koh <yskoh@mellanox.com>
Subject: [PATCH] net/mlx5: fix compilation issue in debug mode
Date: Mon, 3 Jul 2017 10:27:39 +0200 [thread overview]
Message-ID: <f9f45a384e9f9d9cd9c642b9e87417d1e4f0bcfc.1499070324.git.adrien.mazarguil@6wind.com> (raw)
In-Reply-To: <4bc47a8c50dc528f8061d95cdd0c0934e4e40b38.1498843072.git.adrien.mazarguil@6wind.com>
Even in C11, using types other than _Bool or signed/unsigned int for
bit-fields is an extension. Some GCC versions complain about that when
-pedantic checks are enabled.
The RTE_STD_C11 macro correctly prevented this issue with C99 but not with
C11 as it becomes a no-op. Forcing the extension keyword addresses it.
Fixes: 143c03925695 ("net/mlx: update C compliance standard")
Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Tested-by: Yongseok Koh <yskoh@mellanox.com>
---
Ferruh, squashing this commit with the previous one and discarding its
log is fine if you want. Thanks.
---
drivers/net/mlx5/mlx5_rxtx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h
index 450a569..4195665 100644
--- a/drivers/net/mlx5/mlx5_rxtx.h
+++ b/drivers/net/mlx5/mlx5_rxtx.h
@@ -240,7 +240,7 @@ struct hash_rxq {
};
/* TX queue descriptor. */
-RTE_STD_C11
+__extension__
struct txq {
uint16_t elts_head; /* Current index in (*elts)[]. */
uint16_t elts_tail; /* First element awaiting completion. */
--
2.1.4
next prev parent reply other threads:[~2017-07-03 8:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 17:19 [PATCH] net/mlx: update C compliance standard Adrien Mazarguil
2017-06-30 17:47 ` Ferruh Yigit
2017-06-30 18:14 ` Yongseok Koh
2017-06-30 18:25 ` Yongseok Koh
2017-07-01 15:58 ` Ferruh Yigit
2017-07-02 0:12 ` Yongseok Koh
2017-07-03 8:27 ` Adrien Mazarguil [this message]
2017-07-03 9:18 ` [PATCH] net/mlx5: fix compilation issue in debug mode Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9f45a384e9f9d9cd9c642b9e87417d1e4f0bcfc.1499070324.git.adrien.mazarguil@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.