Re: [PATCH 1/2] dt-bindings: add extended-range-enable property to lm90.yaml

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 10/05/2022 09:19, Holger Brunck wrote:
>> On 5/9/22 06:10, Holger Brunck wrote:
>>> Add a boolean extended-range-enable to make the extented temperature
>>> feature for some lm90 devices configurable.
>>>
>>> Signed-off-by: Holger Brunck <holger.brunck@hitachienergy.com>
>>> cc: Jean Delvare <jdelvare@suse.com>
>>> cc: Guenter Roeck <linux@roeck-us.net>
>>> cc: Rob Herring <robh+dt@kernel.org>
>>> cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
>>> ---
>>>   Documentation/devicetree/bindings/hwmon/national,lm90.yaml | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/hwmon/national,lm90.yaml
>>> b/Documentation/devicetree/bindings/hwmon/national,lm90.yaml
>>> index 30db92977937..98d01f6c9331 100644
>>> --- a/Documentation/devicetree/bindings/hwmon/national,lm90.yaml
>>> +++ b/Documentation/devicetree/bindings/hwmon/national,lm90.yaml
>>> @@ -52,6 +52,10 @@ properties:
>>>     vcc-supply:
>>>       description: phandle to the regulator that provides the +VCC
>>> supply
>>>
>>> +  extended-range-enable:
>>
>> This should probably be either "onsemi,extended-range-enable" (for
>> adt7461) or "ti,extended-range-enable" (for the supported TI chips).
>>
> 
> I can change that, but I thought a generic name would be better as the
> same property name is already used in drivers/hwmon/max6697.c.

That binding was never reviewed by Rob and it does not use vendor
prefixes for any of the fields, so it should not be treated as an example.

Custom properties should have vendor prefix, like Guenter suggested.


Best regards,
Krzysztof