All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	robert.foss@linaro.org, todor.too@gmail.com, agross@kernel.org,
	bjorn.andersson@linaro.org
Cc: mchehab@kernel.org, robh+dt@kernel.org, krzk+dt@kernel.org,
	linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, mmitkov@quicinc.com,
	jgrahsl@snap.com, hfink@snap.com,
	Konrad Dybcio <konrad.dybcio@somainline.org>
Subject: Re: [PATCH v2 3/4] arm64: dts: qcom: sm8250: camss: Define ports address/size cells
Date: Wed, 25 May 2022 10:31:48 +0300	[thread overview]
Message-ID: <f9fe758f-1ab7-5075-fa5a-f5a461a91c85@linaro.org> (raw)
In-Reply-To: <20220524140207.2758605-4-bryan.odonoghue@linaro.org>

On 5/24/22 17:02, Bryan O'Donoghue wrote:
> The ports {} address and size cells definition is the same for every
> derived 8250 board so, we should define it in the core sm8250.dtsi.
> 
> Suggested-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>   arch/arm64/boot/dts/qcom/sm8250.dtsi | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 2bc11cad3a44..aa9a13364865 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -3395,6 +3395,11 @@ camss: camss@ac6a000 {
>   					     "cam_hf_0_mnoc",
>   					     "cam_sf_0_mnoc",
>   					     "cam_sf_icp_mnoc";
> +
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +			};
>   		};
>   
>   		camcc: clock-controller@ad00000 {

Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>

--
Best wishes,
Vladimir

  reply	other threads:[~2022-05-25  7:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-24 14:02 [PATCH v2 0/4] Switch on IMX577 on RB5 with a new CCI fix Bryan O'Donoghue
2022-05-24 14:02 ` [PATCH v2 1/4] i2c: qcom-cci: Fix ordering of pm_runtime_xx and i2c_add_adapter Bryan O'Donoghue
2022-05-25  7:27   ` Vladimir Zapolskiy
2022-05-24 14:02 ` [PATCH v2 2/4] arm64: dts: qcom: sm8250: Disable camcc by default Bryan O'Donoghue
2022-05-24 14:02 ` [PATCH v2 3/4] arm64: dts: qcom: sm8250: camss: Define ports address/size cells Bryan O'Donoghue
2022-05-25  7:31   ` Vladimir Zapolskiy [this message]
2022-05-24 14:02 ` [PATCH v2 4/4] arm64: dts: qcom: qrb5165-rb5: Enable the IMX577 on cam2 Bryan O'Donoghue
2022-05-24 16:21   ` Dmitry Baryshkov
2022-05-24 16:44     ` Bryan O'Donoghue
2022-07-21 11:38 ` [PATCH v2 0/4] Switch on IMX577 on RB5 with a new CCI fix Benjamin Mugnier
2022-07-21 12:29   ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9fe758f-1ab7-5075-fa5a-f5a461a91c85@linaro.org \
    --to=vladimir.zapolskiy@linaro.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hfink@snap.com \
    --cc=jgrahsl@snap.com \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mmitkov@quicinc.com \
    --cc=robert.foss@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=todor.too@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.