From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB61DC2B9F4 for ; Tue, 15 Jun 2021 01:54:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2311361412 for ; Tue, 15 Jun 2021 01:54:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2311361412 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=comstyle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lsyHf-0006Fj-PA for qemu-devel@archiver.kernel.org; Mon, 14 Jun 2021 21:54:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42516) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lsyGV-0004kK-LU for qemu-devel@nongnu.org; Mon, 14 Jun 2021 21:53:19 -0400 Received: from speedy.comstyle.com ([2607:f938:3000:8::2]:20500 helo=mail.comstyle.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1lsyGS-0006c7-JB for qemu-devel@nongnu.org; Mon, 14 Jun 2021 21:53:19 -0400 Received: from mail.comstyle.com (localhost [127.0.0.1]) by mail.comstyle.com (Postfix) with ESMTP id 4G3rtq3dmYz8PbN; Mon, 14 Jun 2021 21:53:07 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=comstyle.com; h=message-id :date:mime-version:subject:to:cc:references:from:in-reply-to :content-type:content-transfer-encoding; s=default; bh=4hVwBjuo6 ImYY928IzYmQu8Ckg4=; b=V91GTYC0tqdW/qfQ8hbSlVRfw7Hp93uYzknT17fF6 ktnqbCfy7fplJHGp61bXOU/ZCBlEfw6Rjmt7/+XwsHN5W3jgVX0aq9W6MynOyQi3 rI7eHZJSd7uYkrlFG6jiShFIv1TTEsXbpjy+KWotNtlx160WVxsMiMSADvmMcNoz lo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=comstyle.com; h=message-id :date:mime-version:subject:to:cc:references:from:in-reply-to :content-type:content-transfer-encoding; q=dns; s=default; b=oGl NO1apsTa3S62S0uDiTNfWPAiOpjo5uxQZG7eihFEGgY0tdRiur+PbqFfTxvHxDjE 7AQz3LpaKd0/vSz/TlZTznyXhBCNze1xt/SBw7zGWHDBnTiL4KzjC9Ih0Zs3DEVQ bPjoIiC0DmhGCW0581yQ94JgZhd+hKcXUSpAVGDU= Received: from [192.168.6.30] (bras-base-toroon2719w-grc-50-142-114-10-211.dsl.bell.ca [142.114.10.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: brad) by mail.comstyle.com (Postfix) with ESMTPSA id 4G3rtq2hP4z8PbK; Mon, 14 Jun 2021 21:53:07 -0400 (EDT) Message-ID: Date: Mon, 14 Jun 2021 21:53:06 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Subject: Re: [PATCH] meson.build: Support ncurses on MacOS Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Stefan Weil , qemu-devel@nongnu.org Cc: =?UTF-8?Q?Daniel_P_=2e_Berrang=c3=a9?= References: <20210612080358.61176-1-sw@weilnetz.de> <202eedd1-eb24-5463-c17a-64e146b95421@comstyle.com> From: Brad Smith In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f938:3000:8::2; envelope-from=brad@comstyle.com; helo=mail.comstyle.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.489, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/14/2021 1:45 AM, Philippe Mathieu-Daud=C3=A9 wrote: > On 6/13/21 8:33 AM, Stefan Weil wrote: >> Am 13.06.21 um 03:40 schrieb Brad Smith: >> >>> This same problem also applies to OpenBSD as we have the same >>> version of ncurses with support for wide characters. I have a similar >>> patch in our QEMU port. >> >> Then we should either extend the conditional statement to handle OpenB= SD >> as well, or simply define both macros unconditionally: >> >> =C2=A0=C2=A0=C2=A0 # Newer versions of curses use NCURSES_WIDECHAR. >> =C2=A0=C2=A0=C2=A0 # Older versions (e. g. on MacOS, OpenBSD) still r= equire >> _XOPEN_SOURCE_EXTENDED. >> =C2=A0=C2=A0=C2=A0 curses_compile_args =3D ['-DNCURSES_WIDECHAR=3D1', >> '-D_XOPEN_SOURCE_EXTENDED=3D1'] >> >> Defining only _XOPEN_SOURCE_EXTENDED would also work with old and new >> versions, so that's another option. > It is simpler to ask Brad to upstream the OpenBSD patch :) That doesn't answer his question and that's the part that actually matter= s.