All of lore.kernel.org
 help / color / mirror / Atom feed
From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-spi@vger.kernel.org, linux-raid@vger.kernel.org,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>, Mark Brown <broonie@kernel.org>,
	Song Liu <song@kernel.org>
Subject: Re: [PATCH 3/3] raid: substitute empty_zero_page with helper ZERO_PAGE(0)
Date: Wed, 19 Oct 2022 18:12:18 +0200	[thread overview]
Message-ID: <fa21b2b9-50cc-48a5-eec1-e3360be9d296@benettiengineering.com> (raw)
In-Reply-To: <Y0/Yt4uJWg4knNoc@infradead.org>

Hi Christoph, All,

On 19/10/22 13:00, Christoph Hellwig wrote:
> On Tue, Oct 18, 2022 at 11:57:55PM +0200, Giulio Benetti wrote:
>>   #if RAID6_USE_EMPTY_ZERO_PAGE
>> -# define raid6_empty_zero_page empty_zero_page
>> +# define raid6_empty_zero_page ZERO_PAGE(0)
>>   #else
>>   extern const char raid6_empty_zero_page[PAGE_SIZE];
> 
> RAID6_USE_EMPTY_ZERO_PAGE is never set to a non-zero value.  So this
> is dead code and we can just remove all code related to the
> RAID6_USE_EMPTY_ZERO_PAGE case.

Here is a patch that removes that unused code:
https://lore.kernel.org/all/20221019160407.7550-1-giulio.benetti@benettiengineering.com/T/#u

and then makes this one useless so I ask to drop it please.

Thank you!

Best regards
-- 
Giulio Benetti
CEO/CTO@Benetti Engineering sas

  parent reply	other threads:[~2022-10-19 16:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18 21:57 [PATCH 1/3] ACPI: scan: substitute empty_zero_page with helper ZERO_PAGE(0) Giulio Benetti
2022-10-18 21:57 ` [PATCH 2/3] spi: fsl-cpm: " Giulio Benetti
2022-10-18 21:57 ` [PATCH 3/3] raid: " Giulio Benetti
2022-10-19 11:00   ` Christoph Hellwig
2022-10-19 13:19     ` Giulio Benetti
2022-10-19 16:04     ` [PATCH] lib/raid6: drop RAID6_USE_EMPTY_ZERO_PAGE Giulio Benetti
2022-10-19 16:10       ` Christoph Hellwig
2022-10-20 18:21         ` Song Liu
2022-10-19 16:12     ` Giulio Benetti [this message]
2022-10-19 14:56 ` (subset) [PATCH 1/3] ACPI: scan: substitute empty_zero_page with helper ZERO_PAGE(0) Mark Brown
2022-11-03 18:53 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa21b2b9-50cc-48a5-eec1-e3360be9d296@benettiengineering.com \
    --to=giulio.benetti@benettiengineering.com \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=hch@infradead.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.