From: Paolo Bonzini <pbonzini@redhat.com>
To: Claudio Fontana <cfontana@suse.de>
Cc: Alex Bennee <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [RFC v19 13/15] i386: slit svm_helper into softmmu and stub-only user
Date: Tue, 16 Feb 2021 11:58:38 +0100 [thread overview]
Message-ID: <fa2bd6a8-041c-0043-4b3a-dac69a0c0c3d@redhat.com> (raw)
In-Reply-To: <23e42c1d-0757-e5a8-3021-dce536276cf4@suse.de>
On 16/02/21 11:52, Claudio Fontana wrote:
> I noticed also a call to cpu_load_efer() in gdbstub.c,
>
> case IDX_CTL_EFER_REG:
> if (env->hflags & HF_CS64_MASK) {
> cpu_load_efer(env, ldq_p(mem_buf));
> return 8;
> }
> cpu_load_efer(env, ldl_p(mem_buf));
> return 4;
>
> }
>
> Should this somehow restricted for user-mode, as it has the potential to set HF_SVME ?
>
Yeah, it should. Likewise for CR0/CR2/CR3/TPR. Nice catch!
Paolo
next prev parent reply other threads:[~2021-02-16 11:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 10:46 [RFC v19 00/15] i386 cleanup PART 2 Claudio Fontana
2021-02-16 10:46 ` [RFC v19 01/15] i386: split cpu accelerators from cpu.c, using AccelCPUClass Claudio Fontana
2021-02-16 10:46 ` [RFC v19 02/15] cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn Claudio Fontana
2021-02-16 10:46 ` [RFC v19 03/15] accel: introduce new accessor functions Claudio Fontana
2021-02-16 10:46 ` [RFC v19 04/15] target/i386: fix host_cpu_adjust_phys_bits error handling Claudio Fontana
2021-02-16 10:46 ` [RFC v19 05/15] accel-cpu: make cpu_realizefn return a bool Claudio Fontana
2021-02-16 10:46 ` [RFC v19 06/15] meson: add target_user_arch Claudio Fontana
2021-02-16 10:46 ` [RFC v19 07/15] i386: split off softmmu-only functionality in tcg-cpu Claudio Fontana
2021-02-16 10:46 ` [RFC v19 08/15] i386: split smm helper (softmmu) Claudio Fontana
2021-02-16 10:46 ` [RFC v19 09/15] i386: split tcg excp_helper into softmmu and user parts Claudio Fontana
2021-02-16 10:46 ` [RFC v19 10/15] i386: move TCG btp_helper into softmmu/ Claudio Fontana
2021-02-16 11:58 ` Claudio Fontana
2021-02-16 17:36 ` Paolo Bonzini
2021-02-16 10:46 ` [RFC v19 11/15] i386: split misc helper into user and softmmu parts Claudio Fontana
2021-02-16 10:46 ` [RFC v19 12/15] i386: separate fpu_helper " Claudio Fontana
2021-02-16 10:46 ` [RFC v19 13/15] i386: slit svm_helper into softmmu and stub-only user Claudio Fontana
2021-02-16 10:52 ` Claudio Fontana
2021-02-16 10:58 ` Paolo Bonzini [this message]
2021-02-16 10:58 ` Paolo Bonzini
2021-02-16 19:34 ` Eric Blake
2021-02-16 20:44 ` Claudio Fontana
2021-02-16 10:46 ` [RFC v19 14/15] i386: split seg_helper into user-only and softmmu parts Claudio Fontana
2021-02-16 10:46 ` [RFC v19 15/15] i386: split off softmmu part of cpu.c Claudio Fontana
2021-02-16 11:06 ` [RFC v19 00/15] i386 cleanup PART 2 no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa2bd6a8-041c-0043-4b3a-dac69a0c0c3d@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=cfontana@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.