All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kumar, Abhay" <abhay.kumar@intel.com>
To: Gaurav K Singh <gaurav.k.singh@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Cc: "Nikula, Jani" <jani.nikula@intel.com>,
	"Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
Subject: Re: [PATCH] drm/i915/audio: Fix audio detection issue on GLK
Date: Tue, 17 Apr 2018 11:00:12 -0700	[thread overview]
Message-ID: <fa2f4ed4-48dc-ccfe-061b-378a0efef3bd@intel.com> (raw)
In-Reply-To: <1523949504-6428-1-git-send-email-gaurav.k.singh@intel.com>



On 4/17/2018 12:18 AM, Gaurav K Singh wrote:
> On Geminilake, sometimes audio card is not getting
> detected after reboot. This is a spurious issue happening on
> Geminilake. HW codec and HD audio controller link was going
> out of sync for which there was a fix in i915 driver but
> was not getting invoked for GLK. Extending this fix to GLK as well.
>
> Tested by Du,Wenkai on GLK board.
>
> Bspec: 21829
>
> v2: Instead of checking GEN9_BC, BXT and GLK macros, use IS_GEN9 macro
>
> Signed-off-by: Gaurav K Singh <gaurav.k.singh@intel.com>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Abhay Kumar <abhay.Kumar@intel.com>


> ---
>   drivers/gpu/drm/i915/intel_audio.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index 656f6c931341..3ea566f99450 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -729,7 +729,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
>   	struct drm_i915_private *dev_priv = kdev_to_i915(kdev);
>   	u32 tmp;
>   
> -	if (!IS_GEN9_BC(dev_priv) && !IS_BROXTON(dev_priv))
> +	if (!IS_GEN9(dev_priv))
>   		return;
>   
>   	i915_audio_component_get_power(kdev);

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-04-17 18:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-17  7:18 [PATCH] drm/i915/audio: Fix audio detection issue on GLK Gaurav K Singh
2018-04-17  8:00 ` ✗ Fi.CI.BAT: failure for drm/i915/audio: Fix audio detection issue on GLK (rev2) Patchwork
2018-04-17  8:05   ` Martin Peres
2018-04-17  8:02 ` [PATCH] drm/i915/audio: Fix audio detection issue on GLK Jani Nikula
2018-04-17  9:18 ` ✓ Fi.CI.BAT: success for drm/i915/audio: Fix audio detection issue on GLK (rev2) Patchwork
2018-04-17 10:05 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-04-17 18:00 ` Kumar, Abhay [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-04-17 18:22 [PATCH] drm/i915/audio: Fix audio detection issue on GLK Gaurav K Singh
2018-04-17 18:28 ` Du,Wenkai
2018-04-18  6:04   ` Singh, Gaurav K
2018-04-18  8:07     ` Jani Nikula
2018-04-08 13:36 Gaurav K Singh
2018-04-09 14:07 ` Jani Nikula
2018-04-09 19:10   ` Rodrigo Vivi
2018-04-09 19:18     ` Kumar, Abhay
2018-04-09 23:20       ` Dhinakaran Pandiyan
2018-04-09 23:13         ` Kumar, Abhay
2018-04-10 11:02           ` Jani Nikula
2018-04-11 19:27             ` Singh, Gaurav K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa2f4ed4-48dc-ccfe-061b-378a0efef3bd@intel.com \
    --to=abhay.kumar@intel.com \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=gaurav.k.singh@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.