All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: hs@denx.de, Adam Ford <aford173@gmail.com>,
	U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [PATCH] i2c: rcar_i2c: Enable configuring SCL rise and fall times
Date: Tue, 21 Sep 2021 06:20:03 +0200	[thread overview]
Message-ID: <fa484292-4861-d71b-ba3c-70f4b7f82ad1@denx.de> (raw)
In-Reply-To: <08bd1443-0e7c-98ff-b6ea-ecab5fdc243c@denx.de>

On 9/21/21 6:13 AM, Heiko Schocher wrote:
> Hello Adam,
> 
> On 20.09.21 14:21, Adam Ford wrote:
>> On Tue, Aug 24, 2021 at 9:10 AM Adam Ford <aford173@gmail.com> wrote:
>>>
>>> The Linux i2c driver supports i2c-scl-rising-time-ns,
>>> and i2c-scl-falling-time-ns, but U-Boot uses hard-coded values
>>> for these values.
>>>
>>> Update the calculation by fetching them from the device tree if
>>> present and use the previous values as the default if they are
>>> missing.
>>>
>>> Signed-off-by: Adam Ford <aford173@gmail.com>
>>>
>> Do I have the right people in copy?  I was hoping to get some feedback
>> on this.  My boards use the i2c-scl-rising-time-ns to help properly
>> set the i2c clocking.
> 
> No, I think all fine, for me the patch is okay, so:
> 
> Reviewed-by: Heiko Schocher <hs@denx.de>
> 
> Ah, I see, in patchwork the patch is assigned to Marek... added Marek
> to cc.
> 
> @Marek: Is it okay for you, if I pickup the patch, when new u-boot
> version is out? Else you can pick it up.

Looks good, pick it for next please.

  reply	other threads:[~2021-09-21  4:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24 14:10 [PATCH] i2c: rcar_i2c: Enable configuring SCL rise and fall times Adam Ford
2021-09-20 12:21 ` Adam Ford
2021-09-21  4:13   ` Heiko Schocher
2021-09-21  4:20     ` Marek Vasut [this message]
2021-09-28  6:30 ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa484292-4861-d71b-ba3c-70f4b7f82ad1@denx.de \
    --to=marex@denx.de \
    --cc=aford173@gmail.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.