Re: [PATCH] serial: zynq: Add support for serial parameters

[Kunihiko Hayashi <hayashi.kunihiko@socionext.com>]

Hi Michal,

On 2021/06/23 20:15, Michal Simek wrote:
> Hi Kunihiko,
> 
> On 6/23/21 12:52 PM, Kunihiko Hayashi wrote:
>> Hi Michal,
>>
>> On 2021/06/22 21:44, Michal Simek wrote:
>>> Hi,
>>>
>>> On 6/22/21 6:24 AM, Kunihiko Hayashi wrote:
>>>> This adds serial parameters that include stop bit mode, parity mode,
>>>> and character length. Mark parity and space parity modes are not
>>>> supported.
>>>>
>>>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>>>> ---
>>>>    drivers/serial/serial_zynq.c | 64
>>>> ++++++++++++++++++++++++++++++++++++++++++++
>>>>    1 file changed, 64 insertions(+)
>>
>> [snip]
>>
>>> I am just curious how you have tested it because only hook is in
>>> test/dm/serial.c and I can't see no way how to change this setting via
>>> u-boot command line.
>>
>> I was misunderstanding.
>>
>> Surely there is no way to execute .setconfig function, and
>> neither command line nor devicetree actually affects the serial mode.
>> The mode just inherits that of the previous firmware.
>>
>>> That being said I see that this change adds 184 bytes which is quite a
>>> lot especially for SPL on zynqmp. That's why would like to know how this
>>> feature should be used. If make sense for example to limit it to only
>>> full U-Boot.
>>
>> I see. I didn't think enough about the size limit of SPL.
>> Anyway, I withdraw this patch.
> 
> Up2you. Maybe someone will add any support for calling these functions.
> For me it is fine to add it to full U-Boot but not to SPL for DM testing.

Ok, I expect to such support.
I'll modify it to add the function when CONFIG_SPL_BUILD isn't defined
if there is no concern, and resend it.

Thank you,

---
Best Regards
Kunihiko Hayashi