From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4E41ECE587 for ; Tue, 1 Oct 2019 17:52:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC8F82070B for ; Tue, 1 Oct 2019 17:52:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="oj2/PZIW"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="lTkHXHKu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730348AbfJARwS (ORCPT ); Tue, 1 Oct 2019 13:52:18 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37462 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725844AbfJARwR (ORCPT ); Tue, 1 Oct 2019 13:52:17 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 233ED61156; Tue, 1 Oct 2019 17:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1569952336; bh=EqX6F8UDW8JnIw6Hk7q7L1dvCzSEMNOpUg0sXKY32yA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oj2/PZIWdgJsjvx+7sB/HBZhXwlRP+/bp7ky6LvLjqD4g9BiNDvcglCZ62SjD1tBq QAgX6+g9hprx8wVBP7v9QVjcT7vKvuZQPgA01lEQC46BDaHrF+QmyochFDLUPJwYM0 4m7xO8XStOzyEZlV7qC04Ce1g/yklG9gIRkBlQgg= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 104336083C; Tue, 1 Oct 2019 17:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1569952335; bh=EqX6F8UDW8JnIw6Hk7q7L1dvCzSEMNOpUg0sXKY32yA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lTkHXHKunAsS8EWDCTk+X0f1W5i2eyWsNoTkfA4JrXjUWLAdpwvRUvZwQy/sqsCha kE/4opxhjU4rATlKtRc59y0kRLw3/N3qA8EqPvRggNEEkhrNsP+u2hClns35iEAvhg rCNeqT75U1nPhoOrRrPqkFZOS/g7yYIjD6ij5xpI= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 01 Oct 2019 10:52:15 -0700 From: Sai Prakash Ranjan To: Jeffrey Hugo Cc: Mark Rutland , Rajendra Nayak , Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , MSM , Marc Gonzalez , lkml , Bjorn Andersson , David Brown , Andy Gross , Sibi Sankar , Leo Yan , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCHv9 2/3] arm64: dts: qcom: msm8998: Add Coresight support In-Reply-To: References: <90114e06825e537c3aafd3de5c78743a9de6fadc.1564550873.git.saiprakash.ranjan@codeaurora.org> <16212a577339204e901cf4eefa5e82f1@codeaurora.org> Message-ID: X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2019-10-01 10:14, Jeffrey Hugo wrote: > On Tue, Oct 1, 2019 at 11:04 AM Sai Prakash Ranjan > wrote: >> >> On 2019-10-01 09:13, Jeffrey Hugo wrote: >> > Sai, >> > >> > This patch breaks boot on the 835 laptops. However, I haven't seen >> > the same issue on the MTP. I wonder, is coresight expected to work >> > with production fused devices? I wonder if thats the difference >> > between the laptop and MTP that is causing the issue. >> > >> > Let me know what I can do to help debug. >> > >> >> I did test on MSM8998 MTP and didn't face any issue. I am guessing >> this >> is the same issue which you reported regarding cpuidle? Coresight ETM > > Yes, its the same issue. Right now, I need both patches reverted to > boot. > >> and cpuidle do not work well together since ETMs share the same power >> domain as CPU and they might get turned off when CPU enters idle >> states. >> Can you try with cpuidle.off=1 cmdline or just remove idle states from >> DT to confirm? If this is the issue, then we can try the below patch >> from Andrew Murray for ETM save and restore: >> >> https://patchwork.kernel.org/patch/11097893/ > > Is there still value in testing this if the idle states are removed, > yet the coresight nodes still cause issues? > > Funny enough, I'm using the arm64 defconfig which doesn't seem to > select CONFIG_CORESIGHT, so I'm not even sure what would be binding to > the DT devices... > Haan then likely it's the firmware issue. We should probably disable coresight in soc dtsi and enable only for MTP. For now you can add a status=disabled for all coresight nodes in msm8998.dtsi and I will send the patch doing the same in a day or two(sorry I am travelling currently). Thanks, Sai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 261CCECE587 for ; Tue, 1 Oct 2019 17:52:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F116E2168B for ; Tue, 1 Oct 2019 17:52:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ciCxQI0I"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="oj2/PZIW"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="lTkHXHKu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F116E2168B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3J/Vklkz25iFP+S7Eix8KGLll3qeRtgREcnMScaX1nM=; b=ciCxQI0ItJjZs7a/4Ohu/U4Ge qtJBqjLveqWgmZYY0pFsIumB4DNb4Zke0iERcqJqtbBLL7nyJ0j+L+tUdsEaZEF/QJYVKiVTIoxFD CHISqqe1stZxYjOXfEmOHABWinHbWZTL3uZcE8BvEWdILBTlqDPdTuMXpK4D5r46JOugFxe4daX+F UH/Gz6R+EGn1LefxG/ELl8nVC1G+p4k80KT+M2lKbfE1UVDHbIwZH4T51WFJXroFujlSYRWZ+WYsR xuptxmE3RA8DV5/wOc6J2QzsrGwDIHZAfkZgEtUIs+71B15Wr0PKIRY8gkvJFGHXs7KAvIIbuHo7d 5USns7dCg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFMJv-0004ju-Bh; Tue, 01 Oct 2019 17:52:19 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFMJs-0004jM-Gn for linux-arm-kernel@lists.infradead.org; Tue, 01 Oct 2019 17:52:18 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id F111E6083C; Tue, 1 Oct 2019 17:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1569952336; bh=EqX6F8UDW8JnIw6Hk7q7L1dvCzSEMNOpUg0sXKY32yA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oj2/PZIWdgJsjvx+7sB/HBZhXwlRP+/bp7ky6LvLjqD4g9BiNDvcglCZ62SjD1tBq QAgX6+g9hprx8wVBP7v9QVjcT7vKvuZQPgA01lEQC46BDaHrF+QmyochFDLUPJwYM0 4m7xO8XStOzyEZlV7qC04Ce1g/yklG9gIRkBlQgg= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 104336083C; Tue, 1 Oct 2019 17:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1569952335; bh=EqX6F8UDW8JnIw6Hk7q7L1dvCzSEMNOpUg0sXKY32yA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lTkHXHKunAsS8EWDCTk+X0f1W5i2eyWsNoTkfA4JrXjUWLAdpwvRUvZwQy/sqsCha kE/4opxhjU4rATlKtRc59y0kRLw3/N3qA8EqPvRggNEEkhrNsP+u2hClns35iEAvhg rCNeqT75U1nPhoOrRrPqkFZOS/g7yYIjD6ij5xpI= MIME-Version: 1.0 Date: Tue, 01 Oct 2019 10:52:15 -0700 From: Sai Prakash Ranjan To: Jeffrey Hugo Subject: Re: [PATCHv9 2/3] arm64: dts: qcom: msm8998: Add Coresight support In-Reply-To: References: <90114e06825e537c3aafd3de5c78743a9de6fadc.1564550873.git.saiprakash.ranjan@codeaurora.org> <16212a577339204e901cf4eefa5e82f1@codeaurora.org> Message-ID: X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191001_105216_598119_9977FC7C X-CRM114-Status: GOOD ( 16.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Rajendra Nayak , Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , MSM , Marc Gonzalez , lkml , Bjorn Andersson , David Brown , Andy Gross , Sibi Sankar , Leo Yan , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2019-10-01 10:14, Jeffrey Hugo wrote: > On Tue, Oct 1, 2019 at 11:04 AM Sai Prakash Ranjan > wrote: >> >> On 2019-10-01 09:13, Jeffrey Hugo wrote: >> > Sai, >> > >> > This patch breaks boot on the 835 laptops. However, I haven't seen >> > the same issue on the MTP. I wonder, is coresight expected to work >> > with production fused devices? I wonder if thats the difference >> > between the laptop and MTP that is causing the issue. >> > >> > Let me know what I can do to help debug. >> > >> >> I did test on MSM8998 MTP and didn't face any issue. I am guessing >> this >> is the same issue which you reported regarding cpuidle? Coresight ETM > > Yes, its the same issue. Right now, I need both patches reverted to > boot. > >> and cpuidle do not work well together since ETMs share the same power >> domain as CPU and they might get turned off when CPU enters idle >> states. >> Can you try with cpuidle.off=1 cmdline or just remove idle states from >> DT to confirm? If this is the issue, then we can try the below patch >> from Andrew Murray for ETM save and restore: >> >> https://patchwork.kernel.org/patch/11097893/ > > Is there still value in testing this if the idle states are removed, > yet the coresight nodes still cause issues? > > Funny enough, I'm using the arm64 defconfig which doesn't seem to > select CONFIG_CORESIGHT, so I'm not even sure what would be binding to > the DT devices... > Haan then likely it's the firmware issue. We should probably disable coresight in soc dtsi and enable only for MTP. For now you can add a status=disabled for all coresight nodes in msm8998.dtsi and I will send the patch doing the same in a day or two(sorry I am travelling currently). Thanks, Sai _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel