All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiong Wang <jiong.wang@netronome.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: borkmann@iogearbox.net, ecree@solarflare.com,
	netdev@vger.kernel.org, oss-drivers@netronome.com
Subject: Re: [PATCH bpf-next 0/3] bpf: cleanups on managing subprog information
Date: Wed, 2 May 2018 17:59:50 +0100	[thread overview]
Message-ID: <fa61c0ca-db3d-bc7b-f6ac-521335f539ed@netronome.com> (raw)
In-Reply-To: <20180501222257.cogbkcsncrmg54p5@ast-mbp>

On 01/05/2018 23:22, Alexei Starovoitov wrote:
...
> [   27.784931]  ? bpf_int_jit_compile+0x7ac/0xab0
> [   27.785475]  bpf_int_jit_compile+0x2b6/0xab0
> [   27.786001]  ? do_jit+0x6020/0x6020
> [   27.786428]  ? kasan_kmalloc+0xa0/0xd0
> [   27.786885]  bpf_check+0x2c05/0x4c40
> [   27.787346]  ? fixup_bpf_calls+0x1140/0x1140
> [   27.787865]  ? kasan_unpoison_shadow+0x30/0x40
> [   27.788406]  ? kasan_kmalloc+0xa0/0xd0
> [   27.788865]  ? memset+0x1f/0x40
> [   27.789255]  ? bpf_obj_name_cpy+0x2d/0x200
> [   27.789750]  bpf_prog_load+0xb07/0xeb0
>
> simply running test_verifier with JIT and kasan on.

Ah, sorry, I should add "sysctl net/core/bpf_jit_enable=1" to my test
script, error reproduced.

convert_ctx_accesses and fixup_bpf_calls might insert ebpf insns that
prog->len would change.

The new fake "exit" subprog whose .start offset is prog->len should be
updated as well.

The "for" condition in adjust_subprog_starts:

   for (i = 0; i < env->subprog_cnt; i++) {

need to be changed into:

   for (i = 0; i <= env->subprog_cnt; i++) {

Will respin the patch set.

Thanks.

Regards,
Jiong

  reply	other threads:[~2018-05-02 16:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30 22:28 [PATCH bpf-next 0/3] bpf: cleanups on managing subprog information Jiong Wang
2018-04-30 22:28 ` [PATCH bpf-next 1/3] bpf: unify main prog and subprog Jiong Wang
2018-04-30 22:28 ` [PATCH bpf-next 2/3] bpf: centre subprog information fields Jiong Wang
2018-04-30 22:28 ` [PATCH bpf-next 3/3] bpf: add faked "ending" subprog Jiong Wang
2018-05-01 22:22 ` [PATCH bpf-next 0/3] bpf: cleanups on managing subprog information Alexei Starovoitov
2018-05-02 16:59   ` Jiong Wang [this message]
2018-05-02 17:24     ` John Fastabend
2018-05-02 19:22       ` Jiong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa61c0ca-db3d-bc7b-f6ac-521335f539ed@netronome.com \
    --to=jiong.wang@netronome.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=borkmann@iogearbox.net \
    --cc=ecree@solarflare.com \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@netronome.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.