From: Hans Verkuil <hverkuil@xs4all.nl>
To: Jacopo Mondi <jacopo@jmondi.org>, linux-media@vger.kernel.org
Cc: naush@raspberrypi.com, dave.stevenson@raspberrypi.com,
laurent.pinchart@ideasonboard.com,
kieran.bingham@ideasonboard.com, niklas.soderlund@ragnatech.se,
sakari.ailus@iki.fi, nsaenzjulienne@suse.de,
mchehab+huawei@kernel.org
Subject: Re: [PATCH v3 2/5] media: uapi: Add MEDIA_BUS_FMT_SENSOR_DATA media bus format
Date: Fri, 6 Nov 2020 10:26:33 +0100 [thread overview]
Message-ID: <fa626121-3875-4fcc-f530-ef6449a7a34b@xs4all.nl> (raw)
In-Reply-To: <20201102165258.408049-3-jacopo@jmondi.org>
On 02/11/2020 17:52, Jacopo Mondi wrote:
> From: Naushir Patuck <naush@raspberrypi.com>
>
> This patch adds MEDIA_BUS_FMT_SENSOR_DATA used by the bcm2835-unicam
> driver to support CSI-2 embedded data streams from camera sensors.
>
> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
This patch needs rebasing after MEDIA_BUS_FMT_METADATA_FIXED was added.
> ---
> .../media/v4l/subdev-formats.rst | 32 +++++++++++++++++++
> include/uapi/linux/media-bus-format.h | 3 ++
> 2 files changed, 35 insertions(+)
>
> diff --git a/Documentation/userspace-api/media/v4l/subdev-formats.rst b/Documentation/userspace-api/media/v4l/subdev-formats.rst
> index c9b7bb3ca089d..113d3ac9272ac 100644
> --- a/Documentation/userspace-api/media/v4l/subdev-formats.rst
> +++ b/Documentation/userspace-api/media/v4l/subdev-formats.rst
> @@ -7899,3 +7899,35 @@ formats.
> - 0x5001
> - Interleaved raw UYVY and JPEG image format with embedded meta-data
> used by Samsung S3C73MX camera sensors.
> +
> +
> +
> +.. _v4l2-mbus-sensor-data:
> +
> +Sensor Ancillary Metadata Formats
> +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> +
> +This section lists ancillary data generated by a camera sensor and
> +transmitted over a stream on the camera bus.
> +
> +The following table lists the existing sensor ancillary metadata formats:
> +
> +
> +.. _v4l2-mbus-pixelcode-sensor-metadata:
> +
> +.. tabularcolumns:: |p{8.0cm}|p{1.4cm}|p{7.7cm}|
> +
> +.. flat-table:: Sensor ancillary metadata formats
> + :header-rows: 1
> + :stub-columns: 0
> +
> + * - Identifier
> + - Code
> + - Comments
> + * .. _MEDIA_BUS_FMT_SENSOR_DATA:
> +
> + - MEDIA_BUS_FMT_SENSOR_DATA
> + - 0x7001
> + - Sensor vendor specific ancillary metadata. Some vendors follow a generic
> + CSI-2/SMIA embedded data format as described in the `CSI-2 specification.
Same comment as for the previous patch: this needs to be split up into two formats:
MEDIA_BUS_FMT_METADATA_CSI2_SENSOR_DATA and MEDIA_BUS_FMT_METADATA_CUSTOM_SENSOR_DATA.
> + <https://mipi.org/specifications/csi-2>`_
> diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h
> index 84fa53ffb13fc..3c2848e91c1b2 100644
> --- a/include/uapi/linux/media-bus-format.h
> +++ b/include/uapi/linux/media-bus-format.h
> @@ -156,4 +156,7 @@
> /* HSV - next is 0x6002 */
> #define MEDIA_BUS_FMT_AHSV8888_1X32 0x6001
>
> +/* Sensor ancillary metadata formats - next is 0x7002 */
> +#define MEDIA_BUS_FMT_SENSOR_DATA 0x7001
> +
> #endif /* __LINUX_MEDIA_BUS_FORMAT_H */
>
Regards,
Hans
next prev parent reply other threads:[~2020-11-06 9:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 16:52 [PATCH v3 0/5] media: staging: Add bcm2835-unicam driver Jacopo Mondi
2020-11-02 16:52 ` [PATCH v3 1/5] media: uapi: v4l2-core: Add sensor ancillary data V4L2 fourcc type Jacopo Mondi
2020-11-06 9:23 ` Hans Verkuil
2020-11-06 11:26 ` Dave Stevenson
2020-11-06 11:39 ` Hans Verkuil
2020-11-10 11:26 ` Jacopo Mondi
2020-11-11 17:19 ` Sakari Ailus
2020-11-12 9:38 ` Jacopo Mondi
2020-11-02 16:52 ` [PATCH v3 2/5] media: uapi: Add MEDIA_BUS_FMT_SENSOR_DATA media bus format Jacopo Mondi
2020-11-04 11:12 ` Dafna Hirschfeld
2020-11-06 9:26 ` Hans Verkuil [this message]
2020-11-02 16:52 ` [PATCH v3 3/5] dt-bindings: media: Document BCM283x CSI2/CCP2 receiver Jacopo Mondi
2020-11-02 16:52 ` [PATCH v3 4/5] media: bcm2835-unicam: Driver for CCP2/CSI2 camera interface Jacopo Mondi
2020-11-04 12:14 ` Dafna Hirschfeld
2020-11-04 14:35 ` Dave Stevenson
2020-11-06 10:16 ` Hans Verkuil
2020-11-02 16:52 ` [PATCH v3 5/5] ARM: dts: bcm2711: Add Unicam DT nodes Jacopo Mondi
2020-11-02 17:03 ` [PATCH v3 0/5] media: staging: Add bcm2835-unicam driver Dave Stevenson
2020-11-06 9:50 ` Hans Verkuil
2020-11-06 9:52 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa626121-3875-4fcc-f530-ef6449a7a34b@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=dave.stevenson@raspberrypi.com \
--cc=jacopo@jmondi.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=naush@raspberrypi.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=nsaenzjulienne@suse.de \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.