From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH 0/4 v2] Merge OF dynamic patches Date: Fri, 20 Nov 2009 14:40:22 -0700 Message-ID: References: <4B06AF33.1000400@austin.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <4B06AF33.1000400-V7BBcbaFuwjMbYB6QlFGEg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Nathan Fontenot Cc: microblaze-uclinux-rVRm/Wmeqae7NGdpmJTKYQ@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, Nov 20, 2009 at 8:01 AM, Nathan Fontenot wro= te: > This set of patches merges the common dynamic device tree > updating routines of_attach_node() and of_detach_node() to > drivers/of/of_dynamic.c. > > Built and tested on powerpc, I have no access to build/test > this on microblaze. Heh. Actually, I've got a patch in my tree that does the same thing (except to a different location). I could pick up your version and drop mine, but you need to rework it to be bi-sectable. As the series exists right now, the build will fail if only part of the series is applied. This change is simple enough that you can do the whole thing in a single patch. Or, fix the Kconfig and include stuff in the first patch with the merge of of_attach_node, and then move of_detach_node in the second. But I'm really close to posting my 3rd series, so it may be better to wait until that is published and build a patch on top of that to move them into of_dynamic.c Cheers, g. > --- > > 1/4 - Merge of_attach_node > 2/4 - Merge of_detach_node > 3/4 - Makefile/Kconfig updates > 4/4 - Update powerpc/pseries to include of_dynamic.h > > arch/microblaze/Kconfig =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 =A01 > arch/microblaze/include/asm/prom.h =A0 =A0 =A0 =A0| =A0 =A04 - > arch/microblaze/kernel/prom.c =A0 =A0 =A0 =A0 =A0 =A0 | =A0 59 ----------= ------------- > arch/powerpc/Kconfig =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 =A01 > arch/powerpc/include/asm/prom.h =A0 =A0 =A0 =A0 =A0 | =A0 =A04 - > arch/powerpc/kernel/prom.c =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 59 ------= ----------------- > arch/powerpc/platforms/pseries/reconfig.c | =A0 =A01 drivers/of/Kconfig > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 =A04 + > drivers/of/Makefile =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 =A0= 1 drivers/of/of_dynamic.c > =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 75 ++++++++++++++++++++++++++++++ > include/linux/of_dynamic.h =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 27 ++++++= ++++ > 11 files changed, 110 insertions(+), 126 deletions(-) > -- = Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 Sender: glikely@secretlab.ca In-Reply-To: <4B06AF33.1000400@austin.ibm.com> References: <4B06AF33.1000400@austin.ibm.com> From: Grant Likely Date: Fri, 20 Nov 2009 14:40:22 -0700 Message-ID: Subject: Re: [PATCH 0/4 v2] Merge OF dynamic patches To: Nathan Fontenot Content-Type: text/plain; charset=ISO-8859-1 Cc: microblaze-uclinux@itee.uq.edu.au, devicetree-discuss@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Nov 20, 2009 at 8:01 AM, Nathan Fontenot wro= te: > This set of patches merges the common dynamic device tree > updating routines of_attach_node() and of_detach_node() to > drivers/of/of_dynamic.c. > > Built and tested on powerpc, I have no access to build/test > this on microblaze. Heh. Actually, I've got a patch in my tree that does the same thing (except to a different location). I could pick up your version and drop mine, but you need to rework it to be bi-sectable. As the series exists right now, the build will fail if only part of the series is applied. This change is simple enough that you can do the whole thing in a single patch. Or, fix the Kconfig and include stuff in the first patch with the merge of of_attach_node, and then move of_detach_node in the second. But I'm really close to posting my 3rd series, so it may be better to wait until that is published and build a patch on top of that to move them into of_dynamic.c Cheers, g. > --- > > 1/4 - Merge of_attach_node > 2/4 - Merge of_detach_node > 3/4 - Makefile/Kconfig updates > 4/4 - Update powerpc/pseries to include of_dynamic.h > > arch/microblaze/Kconfig =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 =A01 > arch/microblaze/include/asm/prom.h =A0 =A0 =A0 =A0| =A0 =A04 - > arch/microblaze/kernel/prom.c =A0 =A0 =A0 =A0 =A0 =A0 | =A0 59 ----------= ------------- > arch/powerpc/Kconfig =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 =A0= 1 > arch/powerpc/include/asm/prom.h =A0 =A0 =A0 =A0 =A0 | =A0 =A04 - > arch/powerpc/kernel/prom.c =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 59 ------= ----------------- > arch/powerpc/platforms/pseries/reconfig.c | =A0 =A01 drivers/of/Kconfig > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 =A04 + > drivers/of/Makefile =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 =A0= 1 drivers/of/of_dynamic.c > =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 75 ++++++++++++++++++++++++++++++ > include/linux/of_dynamic.h =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 27 ++++++= ++++ > 11 files changed, 110 insertions(+), 126 deletions(-) > --=20 Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.