From: Grant Likely <grant.likely@secretlab.ca>
To: "Albrecht Dreß" <albrecht.dress@arcor.de>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [Patch v.2] mpc5200b/uart: improve baud rate calculation (reach high baud rates, better accuracy)
Date: Thu, 4 Mar 2010 06:27:53 -0700 [thread overview]
Message-ID: <fa686aa41003040527wdf794admd56fe5cf713ea4f8@mail.gmail.com> (raw)
In-Reply-To: <16827431.1267696606015.JavaMail.ngmail@webmail13.arcor-online.net>
On Thu, Mar 4, 2010 at 2:56 AM, Albrecht Dre=DF <albrecht.dress@arcor.de> w=
rote:
>> That way each set_divisor() can do whatever makes the most sense for
>> the divisors available to it. =A0The 5121 for example has both a /10 and
>> a /32 divisor, plus it can use an external clock.
>
> Ouch. =A0I don't have a 512x, but isn't the current code plain wrong then=
? =A0It uses mpc5xxx_get_bus_frequency() as input for the baud rate calcula=
tion, and if the serial code assumes /16 instead of /10, the result must be=
terribly off. =A0Or did I miss something here?
If you are, then I'm missing the same thing. Do you best to keep the
5121 calculation work out to the same value it uses now. We'll ask
someone with a 5121 to test it out before I add the patch to my -next
branch.
g.
prev parent reply other threads:[~2010-03-04 13:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 18:23 [Patch v.2] mpc5200b/uart: improve baud rate calculation (reach high baud rates, better accuracy) Albrecht Dreß
2010-03-03 21:07 ` Grant Likely
2010-03-04 9:56 ` Albrecht Dreß
2010-03-04 13:27 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa41003040527wdf794admd56fe5cf713ea4f8@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=albrecht.dress@arcor.de \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.