From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v2 05/28] drm: omapdrm: Infer the OMAP version from the SoC family Date: Tue, 9 May 2017 12:02:14 +0300 Message-ID: References: <20170508113303.27521-1-laurent.pinchart@ideasonboard.com> <20170508113303.27521-6-laurent.pinchart@ideasonboard.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0909186932==" Return-path: Received: from lelnx194.ext.ti.com (lelnx194.ext.ti.com [198.47.27.80]) by gabe.freedesktop.org (Postfix) with ESMTPS id 03B9A6E309 for ; Tue, 9 May 2017 09:02:18 +0000 (UTC) In-Reply-To: <20170508113303.27521-6-laurent.pinchart@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0909186932== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sm10x85F6ljggWwhV1IWcEJWMBtvXMnES" --sm10x85F6ljggWwhV1IWcEJWMBtvXMnES Content-Type: multipart/mixed; boundary="pfhpELTe5S2PS6PpLhrAglX8ErWVrvuEB"; protected-headers="v1" From: Tomi Valkeinen To: Laurent Pinchart , dri-devel@lists.freedesktop.org Message-ID: Subject: Re: [PATCH v2 05/28] drm: omapdrm: Infer the OMAP version from the SoC family References: <20170508113303.27521-1-laurent.pinchart@ideasonboard.com> <20170508113303.27521-6-laurent.pinchart@ideasonboard.com> In-Reply-To: <20170508113303.27521-6-laurent.pinchart@ideasonboard.com> --pfhpELTe5S2PS6PpLhrAglX8ErWVrvuEB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/05/17 14:32, Laurent Pinchart wrote: > The omapdrm exposes the SoC version to userspace through an integer tha= t > contains the OMAP model (e.g. 0x3430 for the OMAP3430). This is an > unfortunate choice of userspace API as it's both conceptually wrong > (userspace nowadays should use /sys/bus/soc/ for that purpose) and > inaccurate as many models with different features are reported with the= > same version number. >=20 > The only known user of this API is the xomap X11 driver. Even if it has= > been deprecated for some time we can't drop the kernel API yet. We can,= > however, infer the version number from the SoC family to avoid the need= > to pass the version number through platform data. >=20 > Do this, which makes the omapdrm platform data not needed anymore, and > ready to be removed. >=20 > Signed-off-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/omap_drv.c | 14 ++++++++++++-- > drivers/gpu/drm/omapdrm/omap_drv.h | 1 - > 2 files changed, 12 insertions(+), 3 deletions(-) Reviewed-by: Tomi Valkeinen Tomi --pfhpELTe5S2PS6PpLhrAglX8ErWVrvuEB-- --sm10x85F6ljggWwhV1IWcEJWMBtvXMnES Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZEYWWAAoJEPo9qoy8lh71c6EP/3QF0TLrAu0mhxbR65j/ro4V eZH+NtufFAZWdPXMhuQH6Jb8JP41pzvFGpoZ2k9U6X/ZXu8GDDlxScgelUHBOPz2 KSMpAgkNX36ZSfeK/Wm7X/Io08+6MmcPSq9RT5d1Cir+1rhWbexH9cm0t3voB65L oFZclRtNvBH/i8dsdvmaow34hyIC8Sx2Q7gZ+Zj6dyjof0XLEz7H3kws6u59fNd3 9ClKiGFmoA3da7shXbf3TlGJ95yM7DQRym+lFXtwS+i14WzqlOyub8ogg6PC9b7T /2ZCn3Jo/Eno1mX2C7SvCAfsBma4e6gF1reeuwwkjTkqqQmkO6B0LacEnxflc6PI 8eK+/DkY4mlGok5KMr1eU7MkCcGsCqnAk8+WgUSKOfHbA+hZkJMlLTFzDvBF9OAP rO5pXQwbO0yrCzJ5bM9J0zFQfNmibLhVwFZwdPmUMPblDepd0VTKoodKYagZzm1h Vb5wE1/2t0S5xb6XJI15kByyOv6oP5RGnTRDeRKR+Mkjvb7O/RdPycbX9aNFh81F GDSZXXEC/PExyeOCHV6v6/jAxtKjot98HZL0/h3pSxGH/eWhF37iSz1AV4BqfKk+ ObBELx8d6TeLjS7DwGRYokbV8iul0NVLDKuiUS9apBAvAHMMakwUrxaqEI+kl55E y5Gi08nDKnxZM7c6567R =lFjX -----END PGP SIGNATURE----- --sm10x85F6ljggWwhV1IWcEJWMBtvXMnES-- --===============0909186932== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0909186932==--