From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14376C4167B for ; Mon, 26 Dec 2022 10:27:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229500AbiLZK1p (ORCPT ); Mon, 26 Dec 2022 05:27:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231773AbiLZK1j (ORCPT ); Mon, 26 Dec 2022 05:27:39 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C75CD25C4 for ; Mon, 26 Dec 2022 02:27:36 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id bg10so7348029wmb.1 for ; Mon, 26 Dec 2022 02:27:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=KALJq/V5r25unN7gpBUsW9CyIRW7TsaG7eOK1RtrxG4=; b=XzoOX9nL0mKaY5BM2p/ifqJKZH4E/8KMeSnguCGzpxWpEBvgYTmiK+K1kVTtCCt5ux OyeIMNGwB/MHMmzj4+0bTPPRaXqZJYUtFh8+g3Int9c4AnhoS6LOwB4zNkd40tvX2IFm D07fTPm/juu0sQOmHMoKo96EpBDk9YKJJTvnEa6MUGtyvlTJMFtHsV2ezn3fhkfhVAEv uQwMrri1uBw4vqyHiz5Mn38wOqmP/b8UtUC0vynz3Y5gGeG9nVIScx+Zy+rAMPzDeu3e /FQ4P4KDt9S1O2HqkspgszzZSn5be/Vush6RLNcG+RoOwUGv9MPa0k9fB79P+aPZSb6W aZ3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KALJq/V5r25unN7gpBUsW9CyIRW7TsaG7eOK1RtrxG4=; b=1B8TZGBs+W4zZL+yqQeo5/QIplGoOyD3QXBKw18Vf1FZ75aA8L3+6Ot1ycTLUdVtFW bl/lJJARNoh3sW+BdYPJY2RjjevvyB4d1aS8Ol6ZNtnwz3kHb4iyTOtenzqgJdztPX+i Y7Oh1aBWicHI59R6gzNPbuD8JC4BreSHJ/Q7QPK8ah4sdTcJCdFezi+jmvOBf3UwlaUN G4P6ZP8ot4LQAnCV96cfdzcTyPhAaVJjVMsMoksS7BxGV6hI5/8GlBEQ2K1kLWvRpGtP EkqlIqgHiloY+dp9sBXEqAcy/heQHmRswE1VtkhSKFsCxdFLqqQGN5OviXn4HjxW5pa1 oXtA== X-Gm-Message-State: AFqh2kpiJgf+fJgrVYRiuxycA19rH5Teh/35BkYnVQYhrUEHipmh2YJP xDG+YSo7rbCQSr2sKaf5Ml0d8A== X-Google-Smtp-Source: AMrXdXvPOLaWe2a9phpQit63w0mHUGY18F/dL/xLYS/XbGC0BC2+uZqL8drVpMoEOVKN6hV2HSTLSQ== X-Received: by 2002:a05:600c:3209:b0:3cf:5fd2:87a0 with SMTP id r9-20020a05600c320900b003cf5fd287a0mr12566712wmp.40.1672050455288; Mon, 26 Dec 2022 02:27:35 -0800 (PST) Received: from [192.168.0.20] (117.215.132.195.rev.sfr.net. [195.132.215.117]) by smtp.gmail.com with ESMTPSA id l17-20020adfe9d1000000b0024165454262sm9841286wrn.11.2022.12.26.02.27.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Dec 2022 02:27:34 -0800 (PST) Message-ID: Date: Mon, 26 Dec 2022 11:27:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v7 4/4] thermal: mediatek: add another get_temp ops for thermal sensors From: Amjad Ouled-Ameur To: Daniel Lezcano Cc: AngeloGioacchino Del Regno , Fabien Parent , Matthias Brugger , Markus Schneider-Pargmann , linux-pm@vger.kernel.org, Rob Herring , Michael Kao , linux-kernel@vger.kernel.org, Hsin-Yi Wang , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org References: <20221018-up-i350-thermal-bringup-v7-0-ebf08ff2eddb@baylibre.com> <20221018-up-i350-thermal-bringup-v7-4-ebf08ff2eddb@baylibre.com> <4121bb6b-30db-7a23-f4c8-40afdda7a0b5@linaro.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, On 12/6/22 10:18, Amjad Ouled-Ameur wrote: > Hi Daniel, > On Mon Dec 5, 2022 at 8:39 PM CET, Daniel Lezcano wrote: >> Hi Amjad, >> >> >> On 05/12/2022 11:41, Amjad Ouled-Ameur wrote: >> >> [ ... ] >> >>>>> @@ -1161,11 +1197,24 @@ static int mtk_thermal_probe(struct platform_device *pdev) >>>>> >>>>> platform_set_drvdata(pdev, mt); >>>>> >>>>> - tzdev = devm_thermal_of_zone_register(&pdev->dev, 0, mt, >>>>> - &mtk_thermal_ops); >>>>> - if (IS_ERR(tzdev)) { >>>>> - ret = PTR_ERR(tzdev); >>>>> - goto err_disable_clk_peri_therm; >>>>> + for (i = 0; i < mt->conf->num_sensors + 1; i++) { >>>>> + tz = devm_kmalloc(&pdev->dev, sizeof(*tz), GFP_KERNEL); >>>>> + if (!tz) >>>>> + return -ENOMEM; >>>>> + >>>>> + tz->mt = mt; >>>>> + tz->id = i; >>>>> + >>>>> + tzdev = devm_thermal_of_zone_register(&pdev->dev, i, tz, (i == 0) ? >>>>> + &mtk_thermal_ops : >>>>> + &mtk_thermal_sensor_ops); >>>> Here you use again the aggregation >>> I addressed this concern in V6, could you please take a look and let me >>> know what you think [0]. >>> >>> [0]: https://lore.kernel.org/all/5eb0cdc2-e9f9-dd42-bf80-b7dcd8bcc196@baylibre.com/ >> May I misunderstanding but AFAICS, this patch is setting the >> mtk_thermal_ops if the sensor id is zero. The get_temp is computing the >> max temperature in this ops which is what we don't want to do. > Correct, but I think that is out of scope of this patchset, as the current > driver already uses mtk_thermal_ops for sensor 0. The focus of this patchset > is to add support for the other sensors. > > Besides, what do you suggest as a clean implementation if the current one > no longer meets thermal core requirements ? Could you please address this ? Kindly, Amjad > Regards, > Amjad >> >> -- >> Linaro.org │ Open source software for ARM SoCs >> >> Follow Linaro: Facebook | >> Twitter | >> Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EF12C4167B for ; Mon, 26 Dec 2022 10:28:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1BQCVqWoRJcjFO+PO8MQ/4UaHtZKhDHhqZuDTlQ+dnw=; b=NhX5rDqAOvKahp XS4OiAnEO7jXYEgRWcZ7rOVFqX1E14SbH67L6VV0TjrFSrsKmh7SEcMmVwXIZ5Jr8m03oZS296/wi 1KnPV7bz+IGFN+ZtSc0jJl8CvGb3GhaMBHmkYpucbuhffTanLzGmVCJ9D6rqLtuD7MCwBgQnH0HnF rdhN4QeqPYAR/hzN/KPv27D3RKMdtw5dI8bC3PbmWOPOlq4pheJCkmQCG6evTyhz6KzM/WTjhXgZQ undHpjVRK7lkRLIxylXnskWdOzc/tTuafEak25jqV29TO7vCE/re793yuffwzV0o2VVXOw7vWW4kh gvbqut3o5Dd283Hir6kA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p9ki0-003BIn-3S; Mon, 26 Dec 2022 10:27:52 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p9khm-003BA2-JX for linux-arm-kernel@lists.infradead.org; Mon, 26 Dec 2022 10:27:48 +0000 Received: by mail-wm1-x334.google.com with SMTP id ay40so7355058wmb.2 for ; Mon, 26 Dec 2022 02:27:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=KALJq/V5r25unN7gpBUsW9CyIRW7TsaG7eOK1RtrxG4=; b=XzoOX9nL0mKaY5BM2p/ifqJKZH4E/8KMeSnguCGzpxWpEBvgYTmiK+K1kVTtCCt5ux OyeIMNGwB/MHMmzj4+0bTPPRaXqZJYUtFh8+g3Int9c4AnhoS6LOwB4zNkd40tvX2IFm D07fTPm/juu0sQOmHMoKo96EpBDk9YKJJTvnEa6MUGtyvlTJMFtHsV2ezn3fhkfhVAEv uQwMrri1uBw4vqyHiz5Mn38wOqmP/b8UtUC0vynz3Y5gGeG9nVIScx+Zy+rAMPzDeu3e /FQ4P4KDt9S1O2HqkspgszzZSn5be/Vush6RLNcG+RoOwUGv9MPa0k9fB79P+aPZSb6W aZ3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KALJq/V5r25unN7gpBUsW9CyIRW7TsaG7eOK1RtrxG4=; b=0xLCdGEqRVuYiXgXd+PZ6xp7YO4PPBkgfeefrSiuWicuxnZEK6+MXaNWveHEZi9PG0 vnNThq1QiQQ++fwMrqfFyTS0A3keW92DGlugq6iIDmnWOM0XptBZ1qJ/c7JypGpJQ7VS LMA3WR9+7St+8Ypx5XjEIVVL8xmFOqvZXf42ljwVGRktH6tUW2p3DGx9fNDeDaLePrNU Th9NX8BrEG3kl2pcbWVRWuikK5J50hX4l9yj9j2s1vzKNRnLd/L7OlXT/rKMEtvghu7W ZP90e9Cx4k2OQ6HE/Mhg/7Bfkj7Bkch+BMZS8Uv0uF6TXw7qewkrY3GHuOSJreEjiFgu ibAA== X-Gm-Message-State: AFqh2kpKiLlBlVemSsL2mubLrGxJj7XtIbx5Z4ZMU8da9V0oVgoLOBJ9 9EbI1FyaYXsghEk3AUaoRwQYeA== X-Google-Smtp-Source: AMrXdXvPOLaWe2a9phpQit63w0mHUGY18F/dL/xLYS/XbGC0BC2+uZqL8drVpMoEOVKN6hV2HSTLSQ== X-Received: by 2002:a05:600c:3209:b0:3cf:5fd2:87a0 with SMTP id r9-20020a05600c320900b003cf5fd287a0mr12566712wmp.40.1672050455288; Mon, 26 Dec 2022 02:27:35 -0800 (PST) Received: from [192.168.0.20] (117.215.132.195.rev.sfr.net. [195.132.215.117]) by smtp.gmail.com with ESMTPSA id l17-20020adfe9d1000000b0024165454262sm9841286wrn.11.2022.12.26.02.27.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Dec 2022 02:27:34 -0800 (PST) Message-ID: Date: Mon, 26 Dec 2022 11:27:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v7 4/4] thermal: mediatek: add another get_temp ops for thermal sensors From: Amjad Ouled-Ameur To: Daniel Lezcano Cc: AngeloGioacchino Del Regno , Fabien Parent , Matthias Brugger , Markus Schneider-Pargmann , linux-pm@vger.kernel.org, Rob Herring , Michael Kao , linux-kernel@vger.kernel.org, Hsin-Yi Wang , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org References: <20221018-up-i350-thermal-bringup-v7-0-ebf08ff2eddb@baylibre.com> <20221018-up-i350-thermal-bringup-v7-4-ebf08ff2eddb@baylibre.com> <4121bb6b-30db-7a23-f4c8-40afdda7a0b5@linaro.org> Content-Language: en-US In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221226_022738_971500_2710FAAA X-CRM114-Status: GOOD ( 21.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgRGFuaWVsLAoKT24gMTIvNi8yMiAxMDoxOCwgQW1qYWQgT3VsZWQtQW1ldXIgd3JvdGU6Cj4g SGkgRGFuaWVsLAo+IE9uIE1vbiBEZWMgNSwgMjAyMiBhdCA4OjM5IFBNIENFVCwgRGFuaWVsIExl emNhbm8gd3JvdGU6Cj4+IEhpIEFtamFkLAo+Pgo+Pgo+PiBPbiAwNS8xMi8yMDIyIDExOjQxLCBB bWphZCBPdWxlZC1BbWV1ciB3cm90ZToKPj4KPj4gWyAuLi4gXQo+Pgo+Pj4+PiBAQCAtMTE2MSwx MSArMTE5NywyNCBAQCBzdGF0aWMgaW50IG10a190aGVybWFsX3Byb2JlKHN0cnVjdCBwbGF0Zm9y bV9kZXZpY2UgKnBkZXYpCj4+Pj4+ICAgICAKPj4+Pj4gICAgIAlwbGF0Zm9ybV9zZXRfZHJ2ZGF0 YShwZGV2LCBtdCk7Cj4+Pj4+ICAgICAKPj4+Pj4gLQl0emRldiA9IGRldm1fdGhlcm1hbF9vZl96 b25lX3JlZ2lzdGVyKCZwZGV2LT5kZXYsIDAsIG10LAo+Pj4+PiAtCQkJCQkgICAgICAmbXRrX3Ro ZXJtYWxfb3BzKTsKPj4+Pj4gLQlpZiAoSVNfRVJSKHR6ZGV2KSkgewo+Pj4+PiAtCQlyZXQgPSBQ VFJfRVJSKHR6ZGV2KTsKPj4+Pj4gLQkJZ290byBlcnJfZGlzYWJsZV9jbGtfcGVyaV90aGVybTsK Pj4+Pj4gKwlmb3IgKGkgPSAwOyBpIDwgbXQtPmNvbmYtPm51bV9zZW5zb3JzICsgMTsgaSsrKSB7 Cj4+Pj4+ICsJCXR6ID0gZGV2bV9rbWFsbG9jKCZwZGV2LT5kZXYsIHNpemVvZigqdHopLCBHRlBf S0VSTkVMKTsKPj4+Pj4gKwkJaWYgKCF0eikKPj4+Pj4gKwkJCXJldHVybiAtRU5PTUVNOwo+Pj4+ PiArCj4+Pj4+ICsJCXR6LT5tdCA9IG10Owo+Pj4+PiArCQl0ei0+aWQgPSBpOwo+Pj4+PiArCj4+ Pj4+ICsJCXR6ZGV2ID0gZGV2bV90aGVybWFsX29mX3pvbmVfcmVnaXN0ZXIoJnBkZXYtPmRldiwg aSwgdHosIChpID09IDApID8KPj4+Pj4gKwkJCQkJCQkgICAgICZtdGtfdGhlcm1hbF9vcHMgOgo+ Pj4+PiArCQkJCQkJCSAgICAgJm10a190aGVybWFsX3NlbnNvcl9vcHMpOwo+Pj4+IEhlcmUgeW91 IHVzZSBhZ2FpbiB0aGUgYWdncmVnYXRpb24KPj4+IEkgYWRkcmVzc2VkIHRoaXMgY29uY2VybiBp biBWNiwgY291bGQgeW91IHBsZWFzZSB0YWtlIGEgbG9vayBhbmQgbGV0IG1lCj4+PiBrbm93IHdo YXQgeW91IHRoaW5rIFswXS4KPj4+Cj4+PiBbMF06IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2Fs bC81ZWIwY2RjMi1lOWY5LWRkNDItYmY4MC1iN2RjZDhiY2MxOTZAYmF5bGlicmUuY29tLwo+PiBN YXkgSSBtaXN1bmRlcnN0YW5kaW5nIGJ1dCBBRkFJQ1MsIHRoaXMgcGF0Y2ggaXMgc2V0dGluZyB0 aGUKPj4gbXRrX3RoZXJtYWxfb3BzIGlmIHRoZSBzZW5zb3IgaWQgaXMgemVyby4gVGhlIGdldF90 ZW1wIGlzIGNvbXB1dGluZyB0aGUKPj4gbWF4IHRlbXBlcmF0dXJlIGluIHRoaXMgb3BzIHdoaWNo IGlzIHdoYXQgd2UgZG9uJ3Qgd2FudCB0byBkby4KPiBDb3JyZWN0LCBidXQgSSB0aGluayB0aGF0 IGlzIG91dCBvZiBzY29wZSBvZiB0aGlzIHBhdGNoc2V0LCBhcyB0aGUgY3VycmVudAo+IGRyaXZl ciBhbHJlYWR5IHVzZXMgbXRrX3RoZXJtYWxfb3BzIGZvciBzZW5zb3IgMC4gVGhlIGZvY3VzIG9m IHRoaXMgcGF0Y2hzZXQKPiBpcyB0byBhZGQgc3VwcG9ydCBmb3IgdGhlIG90aGVyIHNlbnNvcnMu Cj4KPiBCZXNpZGVzLCB3aGF0IGRvIHlvdSBzdWdnZXN0IGFzIGEgY2xlYW4gaW1wbGVtZW50YXRp b24gaWYgdGhlIGN1cnJlbnQgb25lCj4gbm8gbG9uZ2VyIG1lZXRzIHRoZXJtYWwgY29yZSByZXF1 aXJlbWVudHMgPwoKQ291bGQgeW91IHBsZWFzZSBhZGRyZXNzIHRoaXMgPwoKCktpbmRseSwKCkFt amFkCgo+IFJlZ2FyZHMsCj4gQW1qYWQKPj4KPj4gLS0gCj4+IDxodHRwOi8vd3d3LmxpbmFyby5v cmcvPiBMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKPj4K Pj4gRm9sbG93IExpbmFybzogIDxodHRwOi8vd3d3LmZhY2Vib29rLmNvbS9wYWdlcy9MaW5hcm8+ IEZhY2Vib29rIHwKPj4gPGh0dHA6Ly90d2l0dGVyLmNvbS8jIS9saW5hcm9vcmc+IFR3aXR0ZXIg fAo+PiA8aHR0cDovL3d3dy5saW5hcm8ub3JnL2xpbmFyby1ibG9nLz4gQmxvZwoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=