Hi Peter,

On 23/08/2019 00:31, Peter Krystad wrote:
> 
> Hi Matthieu -
> 
> It seems a hunk went missing when this was split and squashed. The following
> piece of code from this patch does not appear in mptcp_incoming_options() in
> the current export branch as I would expect to.
> 
> +       if (msk && mp_opt->add_addr) {
> +               if (mp_opt->family == MPTCP_ADDR_IPVERSION_4)
> +                       pm_add_addr(msk, &mp_opt->addr, mp_opt->addr_id);
> +#if IS_ENABLED(CONFIG_IPV6)
> +               else if (mp_opt->family == MPTCP_ADDR_IPVERSION_6)
> +                       pm_add_addr6(msk, &mp_opt->addr6, mp_opt->addr_id);
> +#endif
> +               mp_opt->add_addr = 0;
> +       }
> +
> 
> This causes the received ADD_ADDR option to not be passed up to the path
> manager. I'll send a patch.

Oh sorry, I thought I carefully checked that everything was there. I
will apply this missing part ASAP!

Cheers,
Matt
-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium