From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH] arch: arm: uDPU: fix PHY mode definition to sgmii-2500
Date: Tue, 26 May 2020 16:01:01 +0200 [thread overview]
Message-ID: <fa925600-733b-7afa-f374-293198b78fa7@denx.de> (raw)
In-Reply-To: <c3771626-9a8d-e4e1-15e4-83a4da8db643@sartura.hr>
Hi Jakov,
On 23.05.20 20:23, Jakov Petrina wrote:
> On 12/05/2020 12:02, Jakov Petrina wrote:
>> Commit f49ac7e1c4 switched the default PHY speed to 3.125Gbit to resolve
>> issues with SFP modules. However, U-Boot does not have a "2500base-x"
>> phy-mode.
>>
>> Resolve this by using "sgmii-2500" instead.
>>
>> Signed-off-by: Jakov Petrina <jakov.petrina@sartura.hr>
>> Signed-off-by: Vladimir Vid <vladimir.vid@sartura.hr>
>> Cc: Luka Perkov <luka.perkov@sartura.hr>
>> Cc: Stefan Roese <sr@denx.de>
>> ---
>> ? arch/arm/dts/armada-3720-uDPU.dts | 4 ++--
>> ? 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>
> Hi Stefan,
>
> I'm curious if there are any feedback or blockers on this patch?
Sorry for the delay. I'll take care of it shortly.
Thanks,
Stefan
>
> Thanks,
> Jakov
>
>> diff --git a/arch/arm/dts/armada-3720-uDPU.dts
>> b/arch/arm/dts/armada-3720-uDPU.dts
>> index 07c7b91175..7f4b8222f4 100644
>> --- a/arch/arm/dts/armada-3720-uDPU.dts
>> +++ b/arch/arm/dts/armada-3720-uDPU.dts
>> @@ -125,14 +125,14 @@
>> ? ð0 {
>> ????? pinctrl-0 = <&pcie_pins>;
>> ????? status = "okay";
>> -??? phy-mode = "2500base-x";
>> +??? phy-mode = "sgmii-2500";
>> ????? managed = "in-band-status";
>> ????? phy = <ðphy0>;
>> ? };
>> ? ð1 {
>> ????? status = "okay";
>> -??? phy-mode = "2500base-x";
>> +??? phy-mode = "sgmii-2500";
>> ????? managed = "in-band-status";
>> ????? phy = <ðphy1>;
>> ? };
>>
>
>
Viele Gr??e,
Stefan
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de
next prev parent reply other threads:[~2020-05-26 14:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 10:02 [PATCH] arch: arm: uDPU: fix PHY mode definition to sgmii-2500 Jakov Petrina
2020-05-23 18:23 ` Jakov Petrina
2020-05-26 14:01 ` Stefan Roese [this message]
2020-05-27 7:09 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa925600-733b-7afa-f374-293198b78fa7@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.