From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuo Handa Subject: Re: [PATCH (resend)] reiserfs: update reiserfs_xattrs_initialized() condition Date: Fri, 26 Mar 2021 00:36:15 +0900 Message-ID: References: <000000000000f5be7f05afcf862a@google.com> <20210221050957.3601-1-penguin-kernel@I-love.SAKURA.ne.jp> <700fcc0a-0da7-6d70-620e-af0ed956cd85@i-love.sakura.ne.jp> <20210322153142.GF31783@quack2.suse.cz> <4852ceee-26b1-ff2c-ac33-602e82ff3db7@i-love.sakura.ne.jp> <7d7a884a-5a94-5b0e-3cf5-82d12e1b0992@suse.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-ID: Content-Type: text/plain; charset="us-ascii" To: Jeff Mahoney , Jan Kara Cc: reiserfs-devel@vger.kernel.org On 2021/03/25 15:19, Tetsuo Handa wrote: > On 2021/03/25 0:20, Jeff Mahoney wrote: >> Tetsuo's patch is fine but it needs a similar fix in reiserfs_xattr_set, >> as you noted. Whether it's required is another question. ReiserFS is >> absolutely loaded with fuzzer bugs. > > Can we apply this patch as-is? Since this is currently 5th top crasher, > applying this patch as soon as possible helps utilizing syzbot's resource > for finding further bugs. > Will you explain why we need a similar fix in reiserfs_xattr_set() ? Debug print patch ( https://syzkaller.appspot.com/x/patch.diff?x=1112d621d00000 ) and console output ( https://syzkaller.appspot.com/x/log.txt?x=13e76921d00000 ) says "reiserfs_xattr_init returns -95" which indicates that reiserfs_fill_super() from mount attempts for such crafted filesystem images fails with -EOPNOTSUPP error. Given that such crafted filesystem images cannot be mounted, how can reiserfs_xattr_set() be called and cause problems?