From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 513A7C433F5 for ; Mon, 21 Mar 2022 09:55:52 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.292847.497332 (Exim 4.92) (envelope-from ) id 1nWElJ-0001Hl-Rp; Mon, 21 Mar 2022 09:55:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 292847.497332; Mon, 21 Mar 2022 09:55:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nWElJ-0001He-On; Mon, 21 Mar 2022 09:55:41 +0000 Received: by outflank-mailman (input) for mailman id 292847; Mon, 21 Mar 2022 09:55:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nWElI-0001Dd-O4 for xen-devel@lists.xenproject.org; Mon, 21 Mar 2022 09:55:40 +0000 Received: from smarthost01b.ixn.mail.zen.net.uk (smarthost01b.ixn.mail.zen.net.uk [212.23.1.21]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 103bbc10-a8fd-11ec-8fbc-03012f2f19d4; Mon, 21 Mar 2022 10:55:39 +0100 (CET) Received: from [82.70.146.41] (helo=pear.davidvrabel.org.uk) by smarthost01b.ixn.mail.zen.net.uk with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWElH-00040p-1H; Mon, 21 Mar 2022 09:55:39 +0000 Received: from apple.davidvrabel.org.uk ([82.70.146.43]) by pear.davidvrabel.org.uk with esmtp (Exim 4.92) (envelope-from ) id 1nWElF-0001mL-Ub; Mon, 21 Mar 2022 09:55:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 103bbc10-a8fd-11ec-8fbc-03012f2f19d4 Message-ID: Date: Mon, 21 Mar 2022 09:55:39 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-GB To: Raphael Ning , xen-devel@lists.xenproject.org Cc: Raphael Ning , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , David Vrabel References: <6b84a20b2753130cc62406a0fd14d2708f6f504b.1647455219.git.raphning@amazon.com> From: David Vrabel In-Reply-To: <6b84a20b2753130cc62406a0fd14d2708f6f504b.1647455219.git.raphning@amazon.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 82.70.146.43 X-SA-Exim-Mail-From: dvrabel@cantab.net Subject: Re: [XEN PATCH] evtchn/fifo: Don't set PENDING bit if guest misbehaves X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on pear.davidvrabel.org.uk) X-Originating-smarthost01b-IP: [82.70.146.41] Feedback-ID: 82.70.146.41 On 16/03/2022 18:38, Raphael Ning wrote: > Currently, evtchn_fifo_set_pending() will mark the event as PENDING even > if it fails to lock the FIFO event queue(s), or if the guest has not > initialized the FIFO control block for the target vCPU. A well-behaved > guest should never trigger either of these cases. Reviewed-by: David Vrabel David