From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH 1/4] wdt: Add CONFIG_DESIGNWARE_WATCHDOG to Kconfig
Date: Sun, 2 Feb 2020 18:40:02 +0100 [thread overview]
Message-ID: <faaed633-f0be-85d3-0336-f43296e88759@denx.de> (raw)
In-Reply-To: <d5ec1e24-a291-772c-ef59-9b21e089cf0c@gmail.com>
On 2/2/20 6:23 PM, Sean Anderson wrote:
> On 2/2/20 12:15 PM, Marek Vasut wrote:
>> On 2/2/20 6:10 PM, Sean Anderson wrote:
>>> Currently this is set from headers. No board has this set by default
>>
>> Please check where socfpga_common.h and socfpga_soc64_common.h are
>> included. This should then make it clear that this statement in not true.
>>
>> , so we
>>> don't need to modify any configs.
>
> CONFIG_DESIGNWARE_WATCHDOG is only defined if CONFIG_HW_WATCHDOG is
> defined, and this is never defined in headers (or in the defconfigs).
This is what I see in socfpga_soc64_common.h on u-boot/master:
153 #ifdef CONFIG_SPL_BUILD
154 #define CONFIG_HW_WATCHDOG
>> The patch is wrong, see above. Also, it's missing a SoB line.
>
> Ah, I just noticed that, thanks for pointing that out.
Note that I updated u-boot-socfpga/master and sent a PR just now (thanks
for reminding me of that), it contains the DW WDT patches that were
posted to the ML some time ago. You want to rebase the series on top of
that.
next prev parent reply other threads:[~2020-02-02 17:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-02 17:10 [PATCH 1/4] wdt: Add CONFIG_DESIGNWARE_WATCHDOG to Kconfig Sean Anderson
2020-02-02 17:12 ` [PATCH 2/4] arm: Move asm/utils.h to log2.h Sean Anderson
2020-02-02 17:24 ` Sean Anderson
2020-02-03 0:04 ` Simon Glass
2020-02-03 8:12 ` Marek Vasut
2020-02-03 15:11 ` Simon Glass
2020-02-03 15:27 ` Sean Anderson
2020-02-03 15:31 ` Simon Glass
2020-02-02 17:12 ` [PATCH 3/4] wdt: Remove dependencies on CONFIG_DW_WDT_* from Designware WDT Sean Anderson
2020-02-02 17:25 ` Sean Anderson
2020-02-02 17:13 ` [PATCH 4/4] wdt: Add DM support for " Sean Anderson
2020-02-02 17:25 ` Sean Anderson
2020-02-03 0:04 ` Simon Glass
2020-02-03 1:18 ` Sean Anderson
2020-02-03 4:03 ` Simon Glass
2020-02-02 17:15 ` [PATCH 1/4] wdt: Add CONFIG_DESIGNWARE_WATCHDOG to Kconfig Marek Vasut
2020-02-02 17:23 ` Sean Anderson
2020-02-02 17:40 ` Marek Vasut [this message]
2020-02-02 17:48 ` Sean Anderson
2020-02-02 17:52 ` Marek Vasut
2020-02-02 18:02 ` Sean Anderson
2020-02-03 8:13 ` Marek Vasut
2020-02-19 21:37 ` Sean Anderson
2020-02-20 16:39 ` Marek Vasut
2020-02-02 17:24 ` Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faaed633-f0be-85d3-0336-f43296e88759@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.