From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: Toshiaki Makita <toshiaki.makita1@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH RFC 2/9] veth: Add driver XDP
Date: Thu, 26 Apr 2018 19:46:26 +0900 [thread overview]
Message-ID: <faba5cf5-8659-e953-d828-ad1f472ac0c9@lab.ntt.co.jp> (raw)
In-Reply-To: <20180425223852.0be2fd67@brouer.com>
Hi Jesper,
Thanks for taking a look!
On 2018/04/26 5:39, Jesper Dangaard Brouer wrote:
> On Tue, 24 Apr 2018 23:39:16 +0900
> Toshiaki Makita <toshiaki.makita1@gmail.com> wrote:
>
>> This is basic implementation of veth driver XDP.
>>
>> Incoming packets are sent from the peer veth device in the form of skb,
>> so this is generally doing the same thing as generic XDP.
>
> I'm unsure that context you are calling veth_xdp_rcv_skb() from. The
> XDP (RX side) depend heavily on the protection provided by NAPI context.
> It looks like you are adding NAPI handler later.
This is called from softirq or bh disabled context.
I can see XDP REDIRECT depends on NAPI since it uses per-cpu temporary
storage which is used in ndo_xdp_flush. I thought DROP and PASS is safe
here. Also this is basically the same context as generic XDP, which is
called from netif_rx_internal.
Anyway this is a temporary state and not needed. It looks like this does
not help review so I'll squash this and patch 4 (napi patch).
--
Toshiaki Makita
next prev parent reply other threads:[~2018-04-26 10:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 14:39 [PATCH RFC 0/9] veth: Driver XDP Toshiaki Makita
2018-04-24 14:39 ` [PATCH RFC 1/9] net: Export skb_headers_offset_update and skb_copy_header Toshiaki Makita
2018-04-24 14:39 ` [PATCH RFC 2/9] veth: Add driver XDP Toshiaki Makita
2018-04-25 20:39 ` Jesper Dangaard Brouer
2018-04-26 10:46 ` Toshiaki Makita [this message]
2018-04-24 14:39 ` [PATCH RFC 3/9] veth: Avoid drops by oversized packets when XDP is enabled Toshiaki Makita
2018-04-24 14:39 ` [PATCH RFC 4/9] veth: Use NAPI for XDP Toshiaki Makita
2018-05-01 7:50 ` Jesper Dangaard Brouer
2018-05-01 8:02 ` Toshiaki Makita
2018-05-01 8:43 ` Jesper Dangaard Brouer
2018-05-02 3:37 ` Toshiaki Makita
2018-04-24 14:39 ` [PATCH RFC 5/9] veth: Handle xdp_frame in xdp napi ring Toshiaki Makita
2018-04-24 14:39 ` [PATCH RFC 6/9] veth: Add ndo_xdp_xmit Toshiaki Makita
2018-04-25 20:24 ` Jesper Dangaard Brouer
2018-04-26 10:52 ` Toshiaki Makita
2018-04-30 17:27 ` Jesper Dangaard Brouer
2018-05-01 1:02 ` Toshiaki Makita
2018-05-01 8:14 ` Jesper Dangaard Brouer
2018-05-02 3:33 ` Toshiaki Makita
2018-05-02 5:56 ` Jesper Dangaard Brouer
2018-04-24 14:39 ` [PATCH RFC 7/9] veth: Add XDP TX and REDIRECT Toshiaki Makita
2018-04-24 14:39 ` [PATCH RFC 8/9] veth: Avoid per-packet spinlock of XDP napi ring on dequeueing Toshiaki Makita
2018-04-24 14:39 ` [PATCH RFC 9/9] veth: Avoid per-packet spinlock of XDP napi ring on enqueueing Toshiaki Makita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faba5cf5-8659-e953-d828-ad1f472ac0c9@lab.ntt.co.jp \
--to=makita.toshiaki@lab.ntt.co.jp \
--cc=brouer@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=toshiaki.makita1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.