From: Tom Rix <trix@redhat.com>
To: Vinod Koul <vkoul@kernel.org>, Mark Brown <broonie@kernel.org>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: soundwire: remove unsed header mod_devicetable.h
Date: Sat, 29 Aug 2020 11:22:57 -0700 [thread overview]
Message-ID: <fabb9c26-febc-1767-54b1-7a71a643517f@redhat.com> (raw)
In-Reply-To: <20200829103939.4007097-1-vkoul@kernel.org>
On 8/29/20 3:39 AM, Vinod Koul wrote:
> mod_devicetable.h does not seem to be required for this file, so
> remove it.
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> drivers/base/regmap/regmap-sdw.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/base/regmap/regmap-sdw.c b/drivers/base/regmap/regmap-sdw.c
> index 50a66382d87d..c92d614b4943 100644
> --- a/drivers/base/regmap/regmap-sdw.c
> +++ b/drivers/base/regmap/regmap-sdw.c
> @@ -2,7 +2,6 @@
> // Copyright(c) 2015-17 Intel Corporation.
>
> #include <linux/device.h>
> -#include <linux/mod_devicetable.h>
> #include <linux/module.h>
> #include <linux/soundwire/sdw.h>
This looks ok because mod_devicetable.h is #include-ed in soundwire/sdw.h
Tom
> #include "internal.h"
next prev parent reply other threads:[~2020-08-29 18:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 10:39 [PATCH] regmap: soundwire: remove unsed header mod_devicetable.h Vinod Koul
2020-08-29 18:22 ` Tom Rix [this message]
2020-08-31 14:12 ` Pierre-Louis Bossart
2020-09-01 11:07 ` Vinod Koul
2020-09-01 14:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fabb9c26-febc-1767-54b1-7a71a643517f@redhat.com \
--to=trix@redhat.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.