From: Kalyan Chakravarthy <chakkal@iit.edu>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Arik Nemtsov <arik@wizery.com>, linux-wireless@vger.kernel.org
Subject: Re: [RFC 1/5] nl80211: support sending TDLS commands/frames
Date: Wed, 21 Sep 2011 20:36:22 -0400 [thread overview]
Message-ID: <fac0da2d1631a.4e7a4ac6@iit.edu> (raw)
In-Reply-To: <1316606076.3940.19.camel@jlt3.sipsolutions.net>
I thought ATTR_FRAME would be more appropriate since it carries multiple IE's, such as RSN, FTIE etc.
----- Original Message -----
From: Johannes Berg <johannes@sipsolutions.net>
Date: Wednesday, September 21, 2011 7:54 am
Subject: Re: [RFC 1/5] nl80211: support sending TDLS commands/frames
> On Thu, 2011-09-15 at 13:25 +0300, Arik Nemtsov wrote:
>
> > +static int nl80211_tdls_mgmt(struct sk_buff *skb, struct
> genl_info *info)
> > +{
> > + struct cfg80211_registered_device *rdev = info->user_ptr[0];
> > + struct net_device *dev = info->user_ptr[1];
> > + u8 action_code, dialog_token;
> > + u16 status_code;
> > + u8 *peer;
> > +
> > + if (!rdev->ops->tdls_mgmt)
> > + return -EOPNOTSUPP;
> > +
> > + if (!info->attrs[NL80211_ATTR_TDLS_ACTION] ||
> > + !info->attrs[NL80211_ATTR_STATUS_CODE] ||
> > + !info->attrs[NL80211_ATTR_TDLS_DIALOG_TOKEN] ||
> > + !info->attrs[NL80211_ATTR_FRAME] ||
> > + !info->attrs[NL80211_ATTR_MAC])
> > + return -EINVAL;
>
> Should that really use ATTR_FRAME as opposed to ATTR_IE?
>
> johannes
>
>
next prev parent reply other threads:[~2011-09-22 0:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 10:25 [RFC 0/5] TDLS support for nl80211/mac80211 drivers Arik Nemtsov
2011-09-15 10:25 ` [RFC 1/5] nl80211: support sending TDLS commands/frames Arik Nemtsov
2011-09-21 11:54 ` Johannes Berg
2011-09-22 0:36 ` Kalyan Chakravarthy [this message]
2011-09-22 7:55 ` Johannes Berg
2011-09-22 7:44 ` Arik Nemtsov
2011-09-15 10:25 ` [RFC 2/5] mac80211: handle TDLS high-level commands and frames Arik Nemtsov
2011-09-16 12:59 ` Johannes Berg
2011-09-16 16:57 ` Arik Nemtsov
2011-09-21 12:05 ` Johannes Berg
2011-09-22 7:34 ` Arik Nemtsov
2011-09-22 11:40 ` Johannes Berg
2011-09-22 18:38 ` Arik Nemtsov
2011-09-15 10:25 ` [RFC 3/5] nl80211/mac80211: allow adding TDLS peers as stations Arik Nemtsov
2011-09-21 12:06 ` Johannes Berg
2011-09-22 7:37 ` Arik Nemtsov
2011-09-15 10:25 ` [RFC 4/5] mac80211: add a HW flag for TDLS support Arik Nemtsov
2011-09-19 19:52 ` Arik Nemtsov
2011-09-21 12:06 ` Johannes Berg
2011-09-22 7:39 ` Arik Nemtsov
2011-09-15 10:25 ` [RFC 5/5] mac80211: send data directly to TDLS peers Arik Nemtsov
2011-09-16 13:03 ` Johannes Berg
2011-09-16 17:01 ` Arik Nemtsov
2011-09-21 12:07 ` Johannes Berg
2011-09-22 7:42 ` Arik Nemtsov
2011-09-16 12:58 ` [RFC 0/5] TDLS support for nl80211/mac80211 drivers Johannes Berg
2011-09-16 16:48 ` Arik Nemtsov
2011-09-19 12:20 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fac0da2d1631a.4e7a4ac6@iit.edu \
--to=chakkal@iit.edu \
--cc=arik@wizery.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.