All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaroslav Kysela <perex@perex.cz>
To: Takashi Iwai <tiwai@suse.de>, John Veness <john-linux@pelago.org.uk>
Cc: alsa-devel@alsa-project.org, Hector Martin <marcan@marcan.st>
Subject: Re: Quirks for MacroSilicon MS2100/MS2106
Date: Thu, 23 Jun 2022 09:18:29 +0200	[thread overview]
Message-ID: <fac65634-a702-84c4-da8d-60e01d309c7c@perex.cz> (raw)
In-Reply-To: <878rpnncov.wl-tiwai@suse.de>

On 23. 06. 22 7:58, Takashi Iwai wrote:

>> Even with this patch, there is a remaining problem, which is not present
>> in the MS2109. The sound sample values range from 0x0000 to 0x7fff, with
>> silence around 0x4000, i.e. 15-bit-ish audio. This actually sounds OK to
>> the ear (although half as loud as it should be), but looks odd when
>> looking at the waveform, and makes volume meters always think the sound
>> is very loud.
>>
>> To convert to s16le, I can bitshift one bit left, and subtract 32768.
>> I'm told that this isn't something that can or should be done in the
>> kernel, but should be in userspace. Any more advice on how to fix this
>> remaining quirk would be very welcome.
> 
> Ouch, this is painful.  We haven't had any devices that require a
> 15 bit unsigned format, and maybe we don't want to add it to the
> common standard format just for one funky device, either.  Such data
> processing could be done in alsa-lib, but for the proper interaction
> with the user-space, the kernel should provide some information so
> that user-space can process the data accordingly.  However, we have no
> proper way defined for it generically, so far.
> 
> Maybe an easy way would be to create an alsa-lib external plugin, and
> apply it per device.  Jaroslav, could it be done via UCM?

I agree that we may start with a special plugin for this format. The UCM can 
use any alsa-lib configuration now. So PA/PW should work with this very 
specific hardware when properly configured.

Note that we have SNDRV_PCM_FORMAT_SPECIAL for such cases. It will imply that 
the applications will fail when the special conversion plugin is not used. The 
minor issue may be with the silence routines (which is already with the 
improper format).

					Jaroslav

-- 
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

  reply	other threads:[~2022-06-23  7:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-22 20:23 Quirks for MacroSilicon MS2100/MS2106 John Veness
2022-06-23  5:58 ` Takashi Iwai
2022-06-23  7:18   ` Jaroslav Kysela [this message]
2022-06-23  8:24     ` Takashi Sakamoto
2022-06-23  8:51       ` Jaroslav Kysela
2022-06-25  3:08         ` Takashi Sakamoto
2022-06-25 10:17           ` John Veness
2022-06-24 14:11   ` John Veness

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fac65634-a702-84c4-da8d-60e01d309c7c@perex.cz \
    --to=perex@perex.cz \
    --cc=alsa-devel@alsa-project.org \
    --cc=john-linux@pelago.org.uk \
    --cc=marcan@marcan.st \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.