From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 13/18] drm/amdgpu:fix driver unloading bug Date: Mon, 18 Sep 2017 13:53:46 +0200 Message-ID: References: <1505715122-23904-1-git-send-email-Monk.Liu@amd.com> <1505715122-23904-14-git-send-email-Monk.Liu@amd.com> <1821bf91-83d8-c933-704d-fcd8db07def1@gmail.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Liu, Monk" , "Koenig, Christian" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" Cc: "Chen, Horace" QW0gMTguMDkuMjAxNyB1bSAxMjoxMiBzY2hyaWViIExpdSwgTW9uazoKPiBDaHJpc3RpYW4sCj4K PiBMZXQncyBkaXNjdXNzIHRoaXMgcGF0Y2ggYW5kIHRoZSBvbmUgZm9sbG93cyB3aGljaCBza2lw IHRoZSBLSVEgTVFEIGZyZWUgdG8gYXZvaWQgU0FWRV9GQUlMIGlzc3VlLgo+Cj4KPiBGb3Igc2tp cHBpbmcgS0lRIE1RRCBkZWFsbG9jYXRpb24gcGF0Y2gsIEkgdGhpbmsgSSB3aWxsIGRyb3AgaXQg YW5kIHVzZSBhIG5ldyB3YXk6Cj4gV2UgYWxsb2NhdGUgS0lRIE1RRCBpbiBWUkFNIGRvbWFpbiBh bmQgdGhpcyBCTyBjYW4gYmUgc2FmZWx5IGZyZWVkIGFmdGVyIGRyaXZlciB1bmxvYWRlZCwgYmVj YXVzZSBhZnRlciBkcml2ZXIgdW5sb2FkZWQgbm8gb25lIHdpbGwgY2hhbmdlIHRoZSBkYXRhIGlu IHRoaXMgQk8gKnVzdWFsbHkqLgo+IGUuZy4gc29tZSByb290ICBhcHAgY2FuIG1hcCB2aXNpYmxl IHZyYW0gYW5kIGFsdGVyIHRoZSB2YWx1ZSBpbiBpdAoKVGhhdCBzb3VuZHMgYXQgbGVhc3QgYSBi aXQgYmV0dGVyLiBCdXQgbXkgcXVlc3Rpb24gaXMgd2h5IGRvZXNuJ3QgdGhpcyAKd29yayBsaWtl IGl0IGRvZXMgb24gVG9uZ2EsIGUuZy4gY29ycmVjdGx5IGNsZWFuIHRoaW5ncyB1cD8KCj4KPiBm b3IgdGhpcyBwYXRjaCAidG8gc2tpcHBpbmcgdW5iaW5kIHRoZSBHQVJUIG1hcHBpbmcgdG8ga2Vl cCBLSVEgTVFEIGFsd2F5cyB2YWxpZCI6Cj4gU2luY2UgaHlwZXJ2aXNvciBzaWRlIGFsd2F5cyBo YXZlIGNvdXBsZSBodyBjb21wb25lbnQgd29ya2luZywgYW5kIHRoZXkgcmVseSBvbiBHTUMga2Vw dCBhbGl2ZSwgc28gdGhpcyBpcyB2ZXJ5IGRpZmZlcmVudCB3aXRoIEJBUkUtTUVUQUwuIFRoYXQn cyB0byBzYXkgd2UgY2FuIG9ubHkgZG8gbGlrZSB0aGlzIHdheS4KClllYWgsIGd1dCBrZWVwaW5n IHRoZSBHQVJUIG1hcHBpbmcgYWxpdmUgaXMgY29tcGxldGUgbm9uc2Vuc2UuIFdoZW4gdGhlIApk cml2ZXIgdW5sb2FkcyBhbGwgbWVtb3J5IHNob3VsZCBiZSByZXR1cm5lZCB0byB0aGUgT1MuCgpT byB3ZSBlaXRoZXIga2VlcCBhIEdBUlQgbWFwcGluZyB0byBwYWdlcyB3aGljaCBhcmUgYWJvdXQg dG8gYmUgcmV1c2VkIAphbmQgb3ZlcndyaXR0ZW4sIG9yIHdlIGxlYWsgbWVtb3J5IG9uIGRyaXZl ciBzaHV0ZG93bi4KCk5laXRoZXIgb3B0aW9ucyBzb3VuZHMgdmVyeSBnb29kLApDaHJpc3RpYW4u Cgo+Cj4gQmVzaWRlcywgd2UnbGwgaGF2ZSBtb3JlIHBhdGNoZXMgaW4gZnV0dXJlIGZvciBMMSBz ZWN1cmUgbW9kZSwgd2hpY2ggZm9yYmlkZGVuIFZGIGFjY2VzcyBHTUMgcmVnaXN0ZXJzLCBzbyB1 bmRlciBMMSBzZWN1cmUgbW9kZSBkcml2ZXIgd2lsbCBhbHdheXMgc2tpcCBHTUMgcHJvZ3JhbWlu ZyB1bmRlciBTUklPViBib3RoIGluIGluaXQgYW5kIGZpbmksIGJ1dCB0aGF0IHdpbGwgY29tZSBs YXRlcgo+Cj4gQlIgTW9uawo+Cj4KPgo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4gRnJv bTogQ2hyaXN0aWFuIEvDtm5pZyBbbWFpbHRvOmNrb2VuaWcubGVpY2h0enVtZXJrZW5AZ21haWwu Y29tXQo+IFNlbnQ6IDIwMTflubQ55pyIMTjml6UgMTc6MjgKPiBUbzogTGl1LCBNb25rIDxNb25r LkxpdUBhbWQuY29tPjsgYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBDYzogQ2hlbiwg SG9yYWNlIDxIb3JhY2UuQ2hlbkBhbWQuY29tPgo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMTMvMThd IGRybS9hbWRncHU6Zml4IGRyaXZlciB1bmxvYWRpbmcgYnVnCj4KPiBBbSAxOC4wOS4yMDE3IHVt IDA4OjExIHNjaHJpZWIgTW9uayBMaXU6Cj4+IFtTV0RFVi0xMjY2MzFdIC0gZml4IGh5cGVydmlz b3Igc2F2ZV92ZiBmYWlsIHRoYXQgb2NjdXJlZCBhZnRlciBkcml2ZXIKPj4gcmVtb3ZlZDoKPj4g MS4gQmVjYXVzZSB0aGUgS0lRIGFuZCBLQ1Egd2VyZSBub3QgdW1tYXBwZWQsIHNhdmVfdmYgd2ls bCBmYWlsIGlmIGRyaXZlciBmcmVlZCBtcWQgb2YgS0lRIGFuZCBLQ1EuCj4+IDIuIEtJUSBjYW4n dCBiZSB1bm1hcHBlZCBzaW5jZSBSTENWIGFsd2F5cyBuZWVkIGl0LCB0aGUgYm9fZnJlZSBvbiBL SVEKPj4gc2hvdWxkIGJlIHNraXBwZWQgMy4gS0NRIGNhbiBiZSB1bm1hcHBlZCwgYW5kIHNob3Vs ZCBiZSB1bm1hcHBlZAo+PiBkdXJpbmcgaHdfZmluaSwgNC4gUkxDViBzdGlsbCBuZWVkIHRvIGFj Y2VzcyBvdGhlciBtYyBhZGRyZXNzIGZyb20gc29tZSBodyBldmVuIGFmdGVyIGRyaXZlciB1bmxv YWRlZCwKPj4gICAgICBTbyB3ZSBzaG91bGQgbm90IHVuYmluZCBnYXJ0IGZvciBWRi4KPj4KPj4g Q2hhbmdlLUlkOiBJMzIwNDg3YTlhODQ4ZjQxNDg0YzVmOGNjMTFiZTM0YWNhODA3YjQyNAo+PiBT aWduZWQtb2ZmLWJ5OiBIb3JhY2UgQ2hlbiA8aG9yYWNlLmNoZW5AYW1kLmNvbT4KPj4gU2lnbmVk LW9mZi1ieTogTW9uayBMaXUgPE1vbmsuTGl1QGFtZC5jb20+Cj4gSSBhYnNvbHV0ZWx5IGNhbid0 IGp1ZGdlIGlmIHRoaXMgaXMgY29ycmVjdCBvciBub3QsIGJ1dCBrZWVwaW5nIHRoZSBHQVJUIGFu ZCBLSVEgYWxpdmUgYWZ0ZXIgdGhlIGRyaXZlciBpcyB1bmxvYWRlZCBzb3VuZHMgcmVhbGx5IGZp c2h5IHRvIG1lLgo+Cj4gSXNuJ3QgdGhlcmUgYW55IG90aGVyIGNsZWFuIHdheSBvZiBoYW5kbGlu ZyB0aGlzPwo+Cj4gQ2hyaXN0aWFuLgo+Cj4+IC0tLQo+PiAgICBkcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfZ2FydC5jIHwgIDMgKy0KPj4gICAgZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X2dmeC5jICB8ICA1ICsrKwo+PiAgICBkcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9nZnhfdjlfMC5jICAgIHwgNjAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0K Pj4gICAgMyBmaWxlcyBjaGFuZ2VkLCA2NiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dhcnQu Ywo+PiBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9nYXJ0LmMKPj4gaW5kZXgg ZjQzNzAwOC4uMmZlZTA3MSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1X2dhcnQuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRn cHVfZ2FydC5jCj4+IEBAIC0zOTQsNyArMzk0LDggQEAgaW50IGFtZGdwdV9nYXJ0X2luaXQoc3Ry dWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4+ICAgICAqLwo+PiAgICB2b2lkIGFtZGdwdV9nYXJ0 X2Zpbmkoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4+ICAgIHsKPj4gLQlpZiAoYWRldi0+ Z2FydC5yZWFkeSkgewo+PiArCS8qIGdhcnQgaXMgc3RpbGwgdXNlZCBieSBvdGhlciBodyB1bmRl ciBTUklPViwgZG9uJ3QgdW5iaW5kIGl0ICovCj4+ICsJaWYgKGFkZXYtPmdhcnQucmVhZHkgJiYg IWFtZGdwdV9zcmlvdl92ZihhZGV2KSkgewo+PiAgICAJCS8qIHVuYmluZCBwYWdlcyAqLwo+PiAg ICAJCWFtZGdwdV9nYXJ0X3VuYmluZChhZGV2LCAwLCBhZGV2LT5nYXJ0Lm51bV9jcHVfcGFnZXMp Owo+PiAgICAJfQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k Z3B1X2dmeC5jCj4+IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dmeC5jCj4+ IGluZGV4IDRmNmM2OGYuLmJmNjY1NmYgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L2FtZGdwdV9nZnguYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS9hbWRncHVfZ2Z4LmMKPj4gQEAgLTMwOSw2ICszMDksMTEgQEAgdm9pZCBhbWRncHVfZ2Z4X2Nv bXB1dGVfbXFkX3N3X2Zpbmkoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4+ICAgIAkJCQkg ICAgICAmcmluZy0+bXFkX3B0cik7Cj4+ICAgIAl9Cj4+ICAgIAo+PiArCS8qIGRvbid0IGRlYWxs b2NhdGUgS0lRIG1xZCBiZWNhdXNlIHRoZSBibyBpcyBzdGlsbCB1c2VkIGJ5IFJMQ1YgZXZlbgo+ PiArCXRoZSBndWVzdCBWTSBpcyBzaHV0ZG93biAqLwo+PiArCWlmIChhbWRncHVfc3Jpb3ZfdmYo YWRldikpCj4+ICsJCXJldHVybjsKPj4gKwo+PiAgICAJcmluZyA9ICZhZGV2LT5nZngua2lxLnJp bmc7Cj4+ICAgIAlrZnJlZShhZGV2LT5nZngubWVjLm1xZF9iYWNrdXBbQU1ER1BVX01BWF9DT01Q VVRFX1JJTkdTXSk7Cj4+ICAgIAlhbWRncHVfYm9fZnJlZV9rZXJuZWwoJnJpbmctPm1xZF9vYmos Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nZnhfdjlfMC5jCj4+ IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZ2Z4X3Y5XzAuYwo+PiBpbmRleCA0NDk2MGIz Li5hNTc3YmJjIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nZnhf djlfMC5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dmeF92OV8wLmMKPj4g QEAgLTI4OTIsMTQgKzI4OTIsNzIgQEAgc3RhdGljIGludCBnZnhfdjlfMF9od19pbml0KHZvaWQg KmhhbmRsZSkKPj4gICAgCXJldHVybiByOwo+PiAgICB9Cj4+ICAgIAo+PiArc3RhdGljIGludCBn ZnhfdjlfMF9rY3FfZGlzYWJsZShzdHJ1Y3QgYW1kZ3B1X3JpbmcgKmtpcV9yaW5nLHN0cnVjdAo+ PiArYW1kZ3B1X3JpbmcgKnJpbmcpIHsKPj4gKwlzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiA9 IGtpcV9yaW5nLT5hZGV2Owo+PiArCXVpbnQzMl90IHNjcmF0Y2gsIHRtcCA9IDA7Cj4+ICsJaW50 IHIsIGk7Cj4+ICsKPj4gKwlyID0gYW1kZ3B1X2dmeF9zY3JhdGNoX2dldChhZGV2LCAmc2NyYXRj aCk7Cj4+ICsJaWYgKHIpIHsKPj4gKwkJRFJNX0VSUk9SKCJGYWlsZWQgdG8gZ2V0IHNjcmF0Y2gg cmVnICglZCkuXG4iLCByKTsKPj4gKwkJcmV0dXJuIHI7Cj4+ICsJfQo+PiArCVdSRUczMihzY3Jh dGNoLCAweENBRkVERUFEKTsKPj4gKwo+PiArCXIgPSBhbWRncHVfcmluZ19hbGxvYyhraXFfcmlu ZywgMTApOwo+PiArCWlmIChyKSB7Cj4+ICsJCURSTV9FUlJPUigiRmFpbGVkIHRvIGxvY2sgS0lR ICglZCkuXG4iLCByKTsKPj4gKwkJYW1kZ3B1X2dmeF9zY3JhdGNoX2ZyZWUoYWRldiwgc2NyYXRj aCk7Cj4+ICsJCXJldHVybiByOwo+PiArCX0KPj4gKwo+PiArCS8qIHVubWFwIHF1ZXVlcyAqLwo+ PiArCWFtZGdwdV9yaW5nX3dyaXRlKGtpcV9yaW5nLCBQQUNLRVQzKFBBQ0tFVDNfVU5NQVBfUVVF VUVTLCA0KSk7Cj4+ICsJYW1kZ3B1X3Jpbmdfd3JpdGUoa2lxX3JpbmcsIC8qIFFfc2VsOiAwLCB2 bWlkOiAwLCBlbmdpbmU6IDAsIG51bV9ROiAxICovCj4+ICsJCQkJCQlQQUNLRVQzX1VOTUFQX1FV RVVFU19BQ1RJT04oMSkgfCAvKiBSRVNFVF9RVUVVRVMgKi8KPj4gKwkJCQkJCVBBQ0tFVDNfVU5N QVBfUVVFVUVTX1FVRVVFX1NFTCgwKSB8Cj4+ICsJCQkJCQlQQUNLRVQzX1VOTUFQX1FVRVVFU19F TkdJTkVfU0VMKDApIHwKPj4gKwkJCQkJCVBBQ0tFVDNfVU5NQVBfUVVFVUVTX05VTV9RVUVVRVMo MSkpOwo+PiArCWFtZGdwdV9yaW5nX3dyaXRlKGtpcV9yaW5nLCBQQUNLRVQzX1VOTUFQX1FVRVVF U19ET09SQkVMTF9PRkZTRVQwKHJpbmctPmRvb3JiZWxsX2luZGV4KSk7Cj4+ICsJYW1kZ3B1X3Jp bmdfd3JpdGUoa2lxX3JpbmcsIDApOwo+PiArCWFtZGdwdV9yaW5nX3dyaXRlKGtpcV9yaW5nLCAw KTsKPj4gKwlhbWRncHVfcmluZ193cml0ZShraXFfcmluZywgMCk7Cj4+ICsJLyogd3JpdGUgdG8g c2NyYXRjaCBmb3IgY29tcGxldGlvbiAqLwo+PiArCWFtZGdwdV9yaW5nX3dyaXRlKGtpcV9yaW5n LCBQQUNLRVQzKFBBQ0tFVDNfU0VUX1VDT05GSUdfUkVHLCAxKSk7Cj4+ICsJYW1kZ3B1X3Jpbmdf d3JpdGUoa2lxX3JpbmcsIChzY3JhdGNoIC0gUEFDS0VUM19TRVRfVUNPTkZJR19SRUdfU1RBUlQp KTsKPj4gKwlhbWRncHVfcmluZ193cml0ZShraXFfcmluZywgMHhERUFEQkVFRik7Cj4+ICsJYW1k Z3B1X3JpbmdfY29tbWl0KGtpcV9yaW5nKTsKPj4gKwo+PiArCWZvciAoaSA9IDA7IGkgPCBhZGV2 LT51c2VjX3RpbWVvdXQ7IGkrKykgewo+PiArCQl0bXAgPSBSUkVHMzIoc2NyYXRjaCk7Cj4+ICsJ CWlmICh0bXAgPT0gMHhERUFEQkVFRikKPj4gKwkJCWJyZWFrOwo+PiArCQlEUk1fVURFTEFZKDEp Owo+PiArCX0KPj4gKwlpZiAoaSA+PSBhZGV2LT51c2VjX3RpbWVvdXQpIHsKPj4gKwkJRFJNX0VS Uk9SKCJLQ1EgZGlzYWJsZWQgZmFpbGVkIChzY3JhdGNoKDB4JTA0WCk9MHglMDhYKVxuIiwgc2Ny YXRjaCwgdG1wKTsKPj4gKwkJciA9IC1FSU5WQUw7Cj4+ICsJfQo+PiArCWFtZGdwdV9nZnhfc2Ny YXRjaF9mcmVlKGFkZXYsIHNjcmF0Y2gpOwo+PiArCXJldHVybiByOwo+PiArfQo+PiArCj4+ICsK Pj4gICAgc3RhdGljIGludCBnZnhfdjlfMF9od19maW5pKHZvaWQgKmhhbmRsZSkKPj4gICAgewo+ PiAgICAJc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYgPSAoc3RydWN0IGFtZGdwdV9kZXZpY2Ug KiloYW5kbGU7Cj4+ICsJaW50IGksIHI7Cj4+ICAgIAo+PiAgICAJYW1kZ3B1X2lycV9wdXQoYWRl diwgJmFkZXYtPmdmeC5wcml2X3JlZ19pcnEsIDApOwo+PiAgICAJYW1kZ3B1X2lycV9wdXQoYWRl diwgJmFkZXYtPmdmeC5wcml2X2luc3RfaXJxLCAwKTsKPj4gICAgCWlmIChhbWRncHVfc3Jpb3Zf dmYoYWRldikpIHsKPj4gLQkJcHJfZGVidWcoIkZvciBTUklPViBjbGllbnQsIHNob3VsZG4ndCBk byBhbnl0aGluZy5cbiIpOwo+PiArCQkvKiBkaXNhYmxlIEtDUSB0byBhdm9pZCBDUEMgdG91Y2gg bWVtb3J5IG5vdCB2YWxpZCBhbnltb3JlICovCj4+ICsJCWZvciAoaSA9IDA7IGkgPCBhZGV2LT5n ZngubnVtX2NvbXB1dGVfcmluZ3M7IGkrKykgewo+PiArCQkJciA9IGdmeF92OV8wX2tjcV9kaXNh YmxlKCZhZGV2LT5nZngua2lxLnJpbmcsICZhZGV2LT5nZnguY29tcHV0ZV9yaW5nW2ldKTsKPj4g KwkJCWlmIChyKQo+PiArCQkJCXJldHVybiByOwo+PiArCQl9Cj4+ICAgIAkJcmV0dXJuIDA7Cj4+ ICAgIAl9Cj4+ICAgIAlnZnhfdjlfMF9jcF9lbmFibGUoYWRldiwgZmFsc2UpOwo+Cj4gX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBhbWQtZ2Z4IG1haWxp bmcgbGlzdAo+IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4CgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1k LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==