From: Doug Berger <opendmb@gmail.com>
To: YueHaibing <yuehaibing@huawei.com>,
davem@davemloft.net, f.fainelli@gmail.com,
bcm-kernel-feedback-list@broadcom.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: bcmgenet: use devm_platform_ioremap_resource() to simplify code
Date: Wed, 21 Aug 2019 15:27:29 -0700 [thread overview]
Message-ID: <fae4a0f8-65c5-76ff-1be7-e7b33c9a5466@gmail.com> (raw)
In-Reply-To: <20190821134131.57780-1-yuehaibing@huawei.com>
On 8/21/19 6:41 AM, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> index d3a0b61..2108e59 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> @@ -3437,7 +3437,6 @@ static int bcmgenet_probe(struct platform_device *pdev)
> struct bcmgenet_priv *priv;
> struct net_device *dev;
> const void *macaddr;
> - struct resource *r;
> unsigned int i;
> int err = -EIO;
> const char *phy_mode_str;
> @@ -3477,8 +3476,7 @@ static int bcmgenet_probe(struct platform_device *pdev)
> macaddr = pd->mac_address;
> }
>
> - r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->base = devm_ioremap_resource(&pdev->dev, r);
> + priv->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->base)) {
> err = PTR_ERR(priv->base);
> goto err;
>
Acked-by: Doug Berger <opendmb@gmail.com>
prev parent reply other threads:[~2019-08-21 22:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 13:41 [PATCH net-next] net: bcmgenet: use devm_platform_ioremap_resource() to simplify code YueHaibing
2019-08-21 16:59 ` Florian Fainelli
2019-08-21 20:52 ` David Miller
2019-08-21 22:27 ` Doug Berger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fae4a0f8-65c5-76ff-1be7-e7b33c9a5466@gmail.com \
--to=opendmb@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.