All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>, buildroot@buildroot.org
Cc: Jared Bents <jared.bents@rockwellcollins.com>
Subject: Re: [Buildroot] [PATCH v3, 1/2] package/lvm2: make a standard install for host
Date: Mon, 27 Sep 2021 16:35:00 +0200	[thread overview]
Message-ID: <fafa164f-8b15-d0a7-2aa9-ab72ef87df20@mind.be> (raw)
In-Reply-To: <20210926203429.261419-1-fontaine.fabrice@gmail.com>



On 26/09/2021 22:34, Fabrice Fontaine wrote:
> Use the standard install for the host, so e.g. pvcreate is installed as
> well. pvcreate is needed for libvirt.
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Both applied ot master, thanks.

  Regards,
  Arnout

> ---
> Changes v2 -> v3 (after review of Arnout Vandecappelle):
>   - Update commit message and drop HOST_LVM2_INSTALL_OPTS
> Changes v1 -> v2 (after review of Yann E. Morin):
>   - Use --with-confdir instead of DESTDIR
> 
>   package/lvm2/lvm2.mk | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
> index 3a94aebfd4..70da10696c 100644
> --- a/package/lvm2/lvm2.mk
> +++ b/package/lvm2/lvm2.mk
> @@ -71,9 +71,8 @@ HOST_LVM2_CONF_OPTS = \
>   	--disable-dmeventd \
>   	--disable-fsadm \
>   	--disable-readline \
> -	--disable-selinux
> -HOST_LVM2_MAKE_OPTS = device-mapper
> -HOST_LVM2_INSTALL_OPTS = install_device-mapper
> +	--disable-selinux \
> +	--with-confdir=$(HOST_DIR)/etc
>   
>   $(eval $(autotools-package))
>   $(eval $(host-autotools-package))
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2021-09-27 14:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-26 20:34 [Buildroot] [PATCH v3, 1/2] package/lvm2: make a standard install for host Fabrice Fontaine
2021-09-26 20:34 ` [Buildroot] [PATCH v3, 2/2] package/libvirt: add host-lvm2 dependency Fabrice Fontaine
2021-10-06 14:18   ` Peter Korsgaard
2021-09-27 14:35 ` Arnout Vandecappelle [this message]
2021-10-06 14:17 ` [Buildroot] [PATCH v3, 1/2] package/lvm2: make a standard install for host Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fafa164f-8b15-d0a7-2aa9-ab72ef87df20@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=jared.bents@rockwellcollins.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.