From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932392AbdDFXvW (ORCPT ); Thu, 6 Apr 2017 19:51:22 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:34220 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753077AbdDFXvM (ORCPT ); Thu, 6 Apr 2017 19:51:12 -0400 Subject: Re: [PATCH v6 19/39] media: Add i.MX media core driver To: Philipp Zabel References: <1490661656-10318-1-git-send-email-steve_longerbeam@mentor.com> <1490661656-10318-20-git-send-email-steve_longerbeam@mentor.com> <1491471814.2392.11.camel@pengutronix.de> Cc: robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org, kernel@pengutronix.de, fabio.estevam@nxp.com, linux@armlinux.org.uk, mchehab@kernel.org, hverkuil@xs4all.nl, nick@shmanahar.org, markus.heiser@darmarIT.de, laurent.pinchart+renesas@ideasonboard.com, bparrot@ti.com, geert@linux-m68k.org, arnd@arndb.de, sudipm.mukherjee@gmail.com, minghsiu.tsai@mediatek.com, tiffany.lin@mediatek.com, jean-christophe.trotin@st.com, horms+renesas@verge.net.au, niklas.soderlund+renesas@ragnatech.se, robert.jarzmik@free.fr, songjun.wu@microchip.com, andrew-ct.chen@mediatek.com, gregkh@linuxfoundation.org, shuah@kernel.org, sakari.ailus@linux.intel.com, pavel@ucw.cz, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, Steve Longerbeam From: Steve Longerbeam Message-ID: Date: Thu, 6 Apr 2017 16:51:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1491471814.2392.11.camel@pengutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/06/2017 02:43 AM, Philipp Zabel wrote: > On Mon, 2017-03-27 at 17:40 -0700, Steve Longerbeam wrote: >> Add the core media driver for i.MX SOC. >> >> Signed-off-by: Steve Longerbeam > [...] >> diff --git a/drivers/staging/media/imx/imx-media-of.c b/drivers/staging/media/imx/imx-media-of.c >> new file mode 100644 >> index 0000000..b383be4 >> --- /dev/null >> +++ b/drivers/staging/media/imx/imx-media-of.c >> @@ -0,0 +1,267 @@ > [...] >> +/* >> + * find the remote device node and remote port id (remote pad #) >> + * given local endpoint node >> + */ >> +static void of_get_remote_pad(struct device_node *epnode, >> + struct device_node **remote_node, >> + int *remote_pad) >> +{ >> + struct device_node *rp, *rpp; >> + struct device_node *remote; >> + >> + rp = of_graph_get_remote_port(epnode); >> + rpp = of_graph_get_remote_port_parent(epnode); >> + >> + if (of_device_is_compatible(rpp, "fsl,imx6q-ipu")) { >> + /* the remote is one of the CSI ports */ >> + remote = rp; >> + *remote_pad = 0; >> + of_node_put(rpp); >> + } else { >> + remote = rpp; >> + of_property_read_u32(rp, "reg", remote_pad); > > If this fails because there is no reg property, *remote_pad will keep > the previous value. It should be set to 0 in this case. Ok, I will apply this change. Steve > > ----------8<---------- > --- a/drivers/staging/media/imx/imx-media-of.c > +++ b/drivers/staging/media/imx/imx-media-of.c > @@ -85,7 +85,9 @@ static void of_get_remote_pad(struct device_node *epnode, > of_node_put(rpp); > } else { > remote = rpp; > - of_property_read_u32(rp, "reg", remote_pad); > + /* FIXME port number and pad index are not the same */ > + if (of_property_read_u32(rp, "reg", remote_pad)) > + *remote_pad = 0; > of_node_put(rp); > } > > ---------->8---------- > > regards > Philipp > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Longerbeam Subject: Re: [PATCH v6 19/39] media: Add i.MX media core driver Date: Thu, 6 Apr 2017 16:51:08 -0700 Message-ID: References: <1490661656-10318-1-git-send-email-steve_longerbeam@mentor.com> <1490661656-10318-20-git-send-email-steve_longerbeam@mentor.com> <1491471814.2392.11.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1491471814.2392.11.camel@pengutronix.de> Sender: linux-kernel-owner@vger.kernel.org To: Philipp Zabel Cc: robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org, kernel@pengutronix.de, fabio.estevam@nxp.com, linux@armlinux.org.uk, mchehab@kernel.org, hverkuil@xs4all.nl, nick@shmanahar.org, markus.heiser@darmarIT.de, laurent.pinchart+renesas@ideasonboard.com, bparrot@ti.com, geert@linux-m68k.org, arnd@arndb.de, sudipm.mukherjee@gmail.com, minghsiu.tsai@mediatek.com, tiffany.lin@mediatek.com, jean-christophe.trotin@st.com, horms+renesas@verge.net.au, niklas.soderlund+renesas@ragnatech.se, robert.jarzmik@free.fr, songjun.wu@microchip.com, andrew-ct.chen@mediatek.com, gregkh@linuxfoundation.org, shuah@kernel.org, sakari.ailus@linux.intel.com, pavel@ucw.cz, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org List-Id: devicetree@vger.kernel.org On 04/06/2017 02:43 AM, Philipp Zabel wrote: > On Mon, 2017-03-27 at 17:40 -0700, Steve Longerbeam wrote: >> Add the core media driver for i.MX SOC. >> >> Signed-off-by: Steve Longerbeam > [...] >> diff --git a/drivers/staging/media/imx/imx-media-of.c b/drivers/staging/media/imx/imx-media-of.c >> new file mode 100644 >> index 0000000..b383be4 >> --- /dev/null >> +++ b/drivers/staging/media/imx/imx-media-of.c >> @@ -0,0 +1,267 @@ > [...] >> +/* >> + * find the remote device node and remote port id (remote pad #) >> + * given local endpoint node >> + */ >> +static void of_get_remote_pad(struct device_node *epnode, >> + struct device_node **remote_node, >> + int *remote_pad) >> +{ >> + struct device_node *rp, *rpp; >> + struct device_node *remote; >> + >> + rp = of_graph_get_remote_port(epnode); >> + rpp = of_graph_get_remote_port_parent(epnode); >> + >> + if (of_device_is_compatible(rpp, "fsl,imx6q-ipu")) { >> + /* the remote is one of the CSI ports */ >> + remote = rp; >> + *remote_pad = 0; >> + of_node_put(rpp); >> + } else { >> + remote = rpp; >> + of_property_read_u32(rp, "reg", remote_pad); > > If this fails because there is no reg property, *remote_pad will keep > the previous value. It should be set to 0 in this case. Ok, I will apply this change. Steve > > ----------8<---------- > --- a/drivers/staging/media/imx/imx-media-of.c > +++ b/drivers/staging/media/imx/imx-media-of.c > @@ -85,7 +85,9 @@ static void of_get_remote_pad(struct device_node *epnode, > of_node_put(rpp); > } else { > remote = rpp; > - of_property_read_u32(rp, "reg", remote_pad); > + /* FIXME port number and pad index are not the same */ > + if (of_property_read_u32(rp, "reg", remote_pad)) > + *remote_pad = 0; > of_node_put(rp); > } > > ---------->8---------- > > regards > Philipp > From mboxrd@z Thu Jan 1 00:00:00 1970 From: slongerbeam@gmail.com (Steve Longerbeam) Date: Thu, 6 Apr 2017 16:51:08 -0700 Subject: [PATCH v6 19/39] media: Add i.MX media core driver In-Reply-To: <1491471814.2392.11.camel@pengutronix.de> References: <1490661656-10318-1-git-send-email-steve_longerbeam@mentor.com> <1490661656-10318-20-git-send-email-steve_longerbeam@mentor.com> <1491471814.2392.11.camel@pengutronix.de> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04/06/2017 02:43 AM, Philipp Zabel wrote: > On Mon, 2017-03-27 at 17:40 -0700, Steve Longerbeam wrote: >> Add the core media driver for i.MX SOC. >> >> Signed-off-by: Steve Longerbeam > [...] >> diff --git a/drivers/staging/media/imx/imx-media-of.c b/drivers/staging/media/imx/imx-media-of.c >> new file mode 100644 >> index 0000000..b383be4 >> --- /dev/null >> +++ b/drivers/staging/media/imx/imx-media-of.c >> @@ -0,0 +1,267 @@ > [...] >> +/* >> + * find the remote device node and remote port id (remote pad #) >> + * given local endpoint node >> + */ >> +static void of_get_remote_pad(struct device_node *epnode, >> + struct device_node **remote_node, >> + int *remote_pad) >> +{ >> + struct device_node *rp, *rpp; >> + struct device_node *remote; >> + >> + rp = of_graph_get_remote_port(epnode); >> + rpp = of_graph_get_remote_port_parent(epnode); >> + >> + if (of_device_is_compatible(rpp, "fsl,imx6q-ipu")) { >> + /* the remote is one of the CSI ports */ >> + remote = rp; >> + *remote_pad = 0; >> + of_node_put(rpp); >> + } else { >> + remote = rpp; >> + of_property_read_u32(rp, "reg", remote_pad); > > If this fails because there is no reg property, *remote_pad will keep > the previous value. It should be set to 0 in this case. Ok, I will apply this change. Steve > > ----------8<---------- > --- a/drivers/staging/media/imx/imx-media-of.c > +++ b/drivers/staging/media/imx/imx-media-of.c > @@ -85,7 +85,9 @@ static void of_get_remote_pad(struct device_node *epnode, > of_node_put(rpp); > } else { > remote = rpp; > - of_property_read_u32(rp, "reg", remote_pad); > + /* FIXME port number and pad index are not the same */ > + if (of_property_read_u32(rp, "reg", remote_pad)) > + *remote_pad = 0; > of_node_put(rp); > } > > ---------->8---------- > > regards > Philipp >