All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Wilck <mwilck@suse.com>
To: lixiaokeng <lixiaokeng@huawei.com>,
	Benjamin Marzinski <bmarzins@redhat.com>,
	Christophe Varoqui <christophe.varoqui@opensvc.com>,
	dm-devel@redhat.com
Cc: linfeilong@huawei.com, liuzhiqiang26@huawei.com
Subject: Re: [PATCH 3/5] multipathd: add reclear_pp_from_mpp in ev_remove_path
Date: Tue, 18 Aug 2020 18:36:59 +0200	[thread overview]
Message-ID: <fb04916036613edb59dfd470c449a1a199cd03ff.camel@suse.com> (raw)
In-Reply-To: <8fd64929-cb4b-5267-1899-15a82e2ff678@huawei.com>

On Tue, 2020-08-18 at 21:08 +0800, lixiaokeng wrote:
> Add reclear_pp_from_mpp in ev_remove_path to make sure that pp is
> cleared in mpp.
> 
> When multipathd del path xxx, multipathd -v2, multipathd add path xxx
> and multipath -U
> dm-x are executed simultaneously, multipath -U dm-x will case
> coredump.
> 
> The reason is that there are two paths with same dev_t in dm_table.
> The process
> is as follows:

Thanks for the report.

With which code have you tested this? I have reason to believe that 
it would behave differently with my last patch series (in particular,
part V "removed path handling") applied. I'm not sure if my series
would fix the issue, but it would probably need a different fix.

Regards,
Martin

  reply	other threads:[~2020-08-18 16:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18 12:59 [PATCH 0/5] multipath-tools series: coredump and memory leak bugfix lixiaokeng
2020-08-18 13:02 ` [PATCH 1/5 v4] libmultipath fix a memory leak in set_ble_device lixiaokeng
2020-08-18 15:57   ` Martin Wilck
2020-08-18 13:06 ` [PATCH 2/5] libmultipath fix NULL dereference in select_action lixiaokeng
2020-08-18 16:28   ` Martin Wilck
2020-08-21  4:41     ` lixiaokeng
2020-08-18 13:08 ` [PATCH 3/5] multipathd: add reclear_pp_from_mpp in ev_remove_path lixiaokeng
2020-08-18 16:36   ` Martin Wilck [this message]
2020-08-20 14:51     ` lixiaokeng
2020-08-20 15:22       ` Martin Wilck
2020-08-24 13:07         ` lixiaokeng
2020-08-18 13:09 ` [PATCH 4/5] multipathd: disable queueing for recreated map in uev_remove_map lixiaokeng
2020-08-18 19:23   ` Martin Wilck
2020-08-19  8:48     ` lixiaokeng
2020-08-19  9:27   ` Martin Wilck
2020-08-18 13:11 ` [PATCH 5/5] libmultipath fix daemon memory leak in disassemble_map lixiaokeng
2020-08-19  1:42   ` lixiaokeng
2020-08-19  1:50 ` lixiaokeng
2020-08-19  8:26   ` Martin Wilck
2020-08-19  8:45     ` lixiaokeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb04916036613edb59dfd470c449a1a199cd03ff.camel@suse.com \
    --to=mwilck@suse.com \
    --cc=bmarzins@redhat.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    --cc=linfeilong@huawei.com \
    --cc=liuzhiqiang26@huawei.com \
    --cc=lixiaokeng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.