From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50F75C10DCE for ; Wed, 18 Mar 2020 19:48:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2515A20754 for ; Wed, 18 Mar 2020 19:48:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727082AbgCRTsx (ORCPT ); Wed, 18 Mar 2020 15:48:53 -0400 Received: from poy.remlab.net ([94.23.215.26]:40956 "EHLO ns207790.ip-94-23-215.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726647AbgCRTsw (ORCPT ); Wed, 18 Mar 2020 15:48:52 -0400 Received: from roundcube.remlab.net (ip6-localhost [IPv6:::1]) by ns207790.ip-94-23-215.eu (Postfix) with ESMTP id 36FB45FB07; Wed, 18 Mar 2020 20:48:50 +0100 (CET) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 18 Mar 2020 21:48:50 +0200 From: Remi Denis-Courmont To: Catalin Marinas Cc: mark.rutland@arm.com, will@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] arm64: clean up trampoline vector loads Organization: Remlab Tmi In-Reply-To: <8127163.Epc2VWTDuo@basile.remlab.net> References: <20200316124046.103844-1-remi@remlab.net> <20200318175709.GD94111@arrakis.emea.arm.com> <20200318180630.GE94111@arrakis.emea.arm.com> <8127163.Epc2VWTDuo@basile.remlab.net> Message-ID: X-Sender: remi@remlab.net User-Agent: Roundcube Webmail/1.2.3 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 2020-03-18 20:29, Rémi Denis-Courmont a écrit : > Le keskiviikkona 18. maaliskuuta 2020, 20.06.30 EET Catalin Marinas a > écrit : >> On Wed, Mar 18, 2020 at 05:57:09PM +0000, Catalin Marinas wrote: >> > On Mon, Mar 16, 2020 at 02:40:44PM +0200, Rémi Denis-Courmont wrote: >> > > From: Rémi Denis-Courmont >> > > >> > > This switches from custom instruction patterns to the regular large >> > > memory model sequence with ADRP and LDR. In doing so, the ADD >> > > instruction can be eliminated in the SDEI handler, and the code no >> > > longer assumes that the trampoline vectors and the vectors address both >> > > start on a page boundary. >> > > >> > > Signed-off-by: Rémi Denis-Courmont >> > >> > I queued the 3 trampoline patches for 5.7. Thanks. >> >> ... and removed. I applied them on top of arm64 >> for-next/asm-annotations >> and with defconfig I get: >> >> LD .tmp_vmlinux1 >> arch/arm64/kernel/entry.o: in function `tramp_vectors': >> arch/arm64/kernel/entry.S:838:(.entry.tramp.text+0x43c): relocation >> truncated to fit: R_AARCH64_LDST64_ABS_LO12_NC against symbol >> `__entry_tramp_data_start' defined in .rodata section in >> >> I haven't bisected to see which patch caused this issue. It's the third patch. > Uho, right :-( It only builds with SDEI enabled :-$ > > I'll check further. It seems that the SYM_DATA_START macro does not align the data on its natural boundary. I guess that is all fine on x86 where data needs not be aligned, but it leads to this kind of mischief on arm64. Though even then, the address is of course actually aligned correctly on an 8-bytes boundary, so I suppose binutils is just being pointlessly pedantic here? -- Rémi Denis-Courmont From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A37E3C10DCE for ; Wed, 18 Mar 2020 19:49:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7930220754 for ; Wed, 18 Mar 2020 19:49:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hsmoarST" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7930220754 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=remlab.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M9Ql0BHUMfLdusLad+3Fzr5GNeB21pGd2nHUOwbCi3k=; b=hsmoarSTd6hlR9GkZ5Rf9usuT +2ONOwWr+wL6XVRq7YQrmvktW9LDfNDODlAYVTJdcAobP0bl676W+J84K+Po7B07b1p/HVfItmpSm as0zmkGRGIY79XFlGN0r9Tci0zSGomsuks1JdMch8QHc1pbS1+QZofrAfA6LFPBa0mCZm5tAbeYS6 8CF7b4sotlcbEWENzHEu9AIffCVIcdaaVkDZETjFTNT41UAS5ybPSBfvRq8s3HXlUFvRnEwBFasJj YOJXGFfGEOCuOSK6ZmtxAygUHvUO5wE7tBWk5FNHsBTJkeSFFCd7T3wEgTBiz3NbOPpzLLyE2cvZl 319HLolLg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEegh-0006Sx-Iu; Wed, 18 Mar 2020 19:49:11 +0000 Received: from poy.remlab.net ([2001:41d0:2:5a1a::] helo=ns207790.ip-94-23-215.eu) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEegd-0006SJ-Qr for linux-arm-kernel@lists.infradead.org; Wed, 18 Mar 2020 19:49:09 +0000 Received: from roundcube.remlab.net (ip6-localhost [IPv6:::1]) by ns207790.ip-94-23-215.eu (Postfix) with ESMTP id 36FB45FB07; Wed, 18 Mar 2020 20:48:50 +0100 (CET) MIME-Version: 1.0 Date: Wed, 18 Mar 2020 21:48:50 +0200 From: Remi Denis-Courmont To: Catalin Marinas Subject: Re: [PATCH 1/3] arm64: clean up trampoline vector loads Organization: Remlab Tmi In-Reply-To: <8127163.Epc2VWTDuo@basile.remlab.net> References: <20200316124046.103844-1-remi@remlab.net> <20200318175709.GD94111@arrakis.emea.arm.com> <20200318180630.GE94111@arrakis.emea.arm.com> <8127163.Epc2VWTDuo@basile.remlab.net> Message-ID: X-Sender: remi@remlab.net User-Agent: Roundcube Webmail/1.2.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200318_124908_013090_FE6FDAEA X-CRM114-Status: GOOD ( 12.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, will@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org TGUgMjAyMC0wMy0xOCAyMDoyOSwgUsOpbWkgRGVuaXMtQ291cm1vbnQgYSDDqWNyaXTCoDoKPiBM ZSBrZXNraXZpaWtrb25hIDE4LiBtYWFsaXNrdXV0YSAyMDIwLCAyMC4wNi4zMCBFRVQgQ2F0YWxp biBNYXJpbmFzIGEgCj4gw6ljcml0IDoKPj4gT24gV2VkLCBNYXIgMTgsIDIwMjAgYXQgMDU6NTc6 MDlQTSArMDAwMCwgQ2F0YWxpbiBNYXJpbmFzIHdyb3RlOgo+PiA+IE9uIE1vbiwgTWFyIDE2LCAy MDIwIGF0IDAyOjQwOjQ0UE0gKzAyMDAsIFLDqW1pIERlbmlzLUNvdXJtb250IHdyb3RlOgo+PiA+ ID4gRnJvbTogUsOpbWkgRGVuaXMtQ291cm1vbnQgPHJlbWkuZGVuaXMuY291cm1vbnRAaHVhd2Vp LmNvbT4KPj4gPiA+Cj4+ID4gPiBUaGlzIHN3aXRjaGVzIGZyb20gY3VzdG9tIGluc3RydWN0aW9u IHBhdHRlcm5zIHRvIHRoZSByZWd1bGFyIGxhcmdlCj4+ID4gPiBtZW1vcnkgbW9kZWwgc2VxdWVu Y2Ugd2l0aCBBRFJQIGFuZCBMRFIuIEluIGRvaW5nIHNvLCB0aGUgQURECj4+ID4gPiBpbnN0cnVj dGlvbiBjYW4gYmUgZWxpbWluYXRlZCBpbiB0aGUgU0RFSSBoYW5kbGVyLCBhbmQgdGhlIGNvZGUg bm8KPj4gPiA+IGxvbmdlciBhc3N1bWVzIHRoYXQgdGhlIHRyYW1wb2xpbmUgdmVjdG9ycyBhbmQg dGhlIHZlY3RvcnMgYWRkcmVzcyBib3RoCj4+ID4gPiBzdGFydCBvbiBhIHBhZ2UgYm91bmRhcnku Cj4+ID4gPgo+PiA+ID4gU2lnbmVkLW9mZi1ieTogUsOpbWkgRGVuaXMtQ291cm1vbnQgPHJlbWku ZGVuaXMuY291cm1vbnRAaHVhd2VpLmNvbT4KPj4gPgo+PiA+IEkgcXVldWVkIHRoZSAzIHRyYW1w b2xpbmUgcGF0Y2hlcyBmb3IgNS43LiBUaGFua3MuCj4+IAo+PiAuLi4gYW5kIHJlbW92ZWQuIEkg YXBwbGllZCB0aGVtIG9uIHRvcCBvZiBhcm02NCAKPj4gZm9yLW5leHQvYXNtLWFubm90YXRpb25z Cj4+IGFuZCB3aXRoIGRlZmNvbmZpZyBJIGdldDoKPj4gCj4+ICAgTEQgICAgICAudG1wX3ZtbGlu dXgxCj4+IGFyY2gvYXJtNjQva2VybmVsL2VudHJ5Lm86IGluIGZ1bmN0aW9uIGB0cmFtcF92ZWN0 b3JzJzoKPj4gYXJjaC9hcm02NC9rZXJuZWwvZW50cnkuUzo4Mzg6KC5lbnRyeS50cmFtcC50ZXh0 KzB4NDNjKTogcmVsb2NhdGlvbgo+PiB0cnVuY2F0ZWQgdG8gZml0OiBSX0FBUkNINjRfTERTVDY0 X0FCU19MTzEyX05DIGFnYWluc3Qgc3ltYm9sCj4+IGBfX2VudHJ5X3RyYW1wX2RhdGFfc3RhcnQn IGRlZmluZWQgaW4gLnJvZGF0YSBzZWN0aW9uIGluCj4+IAo+PiBJIGhhdmVuJ3QgYmlzZWN0ZWQg dG8gc2VlIHdoaWNoIHBhdGNoIGNhdXNlZCB0aGlzIGlzc3VlLgoKSXQncyB0aGUgdGhpcmQgcGF0 Y2guCgo+IFVobywgcmlnaHQgOi0oIEl0IG9ubHkgYnVpbGRzIHdpdGggU0RFSSBlbmFibGVkIDot JAo+IAo+IEknbGwgY2hlY2sgZnVydGhlci4KCkl0IHNlZW1zIHRoYXQgdGhlIFNZTV9EQVRBX1NU QVJUIG1hY3JvIGRvZXMgbm90IGFsaWduIHRoZSBkYXRhIG9uIGl0cyAKbmF0dXJhbCBib3VuZGFy eS4gSSBndWVzcyB0aGF0IGlzIGFsbCBmaW5lIG9uIHg4NiB3aGVyZSBkYXRhIG5lZWRzIG5vdCAK YmUgYWxpZ25lZCwgYnV0IGl0IGxlYWRzIHRvIHRoaXMga2luZCBvZiBtaXNjaGllZiBvbiBhcm02 NC4gVGhvdWdoIGV2ZW4gCnRoZW4sIHRoZSBhZGRyZXNzIGlzIG9mIGNvdXJzZSBhY3R1YWxseSBh bGlnbmVkIGNvcnJlY3RseSBvbiBhbiA4LWJ5dGVzIApib3VuZGFyeSwgc28gSSBzdXBwb3NlIGJp bnV0aWxzIGlzIGp1c3QgYmVpbmcgcG9pbnRsZXNzbHkgcGVkYW50aWMgaGVyZT8KCi0tIApSw6lt aSBEZW5pcy1Db3VybW9udAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo=