From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, Thomas Huth <thuth@redhat.com>
Cc: qemu-ppc <qemu-ppc@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH] hw/ppc: Deprecate the ref405ep and taihu machines and the 405 CPU models
Date: Fri, 1 Oct 2021 14:57:00 +0200 [thread overview]
Message-ID: <fb1aa5e4-8dda-baa5-f48d-8743dccc3355@redhat.com> (raw)
In-Reply-To: <CAFEAcA_Vjvi8JvELyG1DghCoHbUR1fzodPoaU2n-QPcf9bGwCg@mail.gmail.com>
On 10/1/21 14:46, Peter Maydell wrote:
> On Fri, 1 Oct 2021 at 13:22, Thomas Huth <thuth@redhat.com> wrote:
>> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
>> index 2f7db9a98d..27c03ef624 100644
>> --- a/docs/about/deprecated.rst
>> +++ b/docs/about/deprecated.rst
>> @@ -238,6 +238,11 @@ The ``I7200`` guest CPU relies on the nanoMIPS ISA, which is deprecated
>> (the ISA has never been upstreamed to a compiler toolchain). Therefore
>> this CPU is also deprecated.
>>
>> +PPC 405 CPU models (since 6.2)
>> +''''''''''''''''''''''''''''''
>> +
>> +The related boards ``ref405ep`` and ``taihu`` are marked as deprecated, too.
>> +
>
> What is this "too" a reference to? The immediately preceding section
> in the document is about the MIPS I7200 CPU model.
>
> The not-being-deprecated sam460ex board also uses the ppc405 CPU
> I think, so I don't think we can drop the CPU models.
>> + mc->deprecation_reason = "ppc405 CPU is deprecated";
>> }
>
> We're not deprecating the machine types because we're deprecating
> the CPU types. We're deprecating them because we believe that
> nobody's using them.
OTOH we mostly test default CPUs. I am a bit worried about CPU
coverage in general. I'm not suggesting we should remove old
CPUs along with their machines, because we can still test an ISA,
just worried about having so many code paths uncovered.
next prev parent reply other threads:[~2021-10-01 12:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 12:19 [PATCH] hw/ppc: Deprecate the ref405ep and taihu machines and the 405 CPU models Thomas Huth
2021-10-01 12:22 ` Cédric Le Goater
2021-10-01 12:46 ` Peter Maydell
2021-10-01 12:57 ` Philippe Mathieu-Daudé [this message]
2021-10-01 13:01 ` Thomas Huth
2021-10-01 13:12 ` Daniel P. Berrangé
2021-10-01 13:19 ` Peter Maydell
2021-10-01 13:41 ` BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb1aa5e4-8dda-baa5-f48d-8743dccc3355@redhat.com \
--to=philmd@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.