From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA3B1C433EF for ; Thu, 14 Oct 2021 20:50:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C041E60F9E for ; Thu, 14 Oct 2021 20:50:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232043AbhJNUw5 (ORCPT ); Thu, 14 Oct 2021 16:52:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:31469 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231527AbhJNUw4 (ORCPT ); Thu, 14 Oct 2021 16:52:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634244650; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sypR1zkCMni3m2sdFQ3BSQIDoKFbj8FkIME4KbCvGjw=; b=Lbb7o2HzS0ccFdG0tIWW6o6pHki3clrSzkzi3kNpyucVJE3FssQhwce2PDsyMz3zg0GL0v HncDS0fE56tDKZE3cJU1hQjv+uPwij+3RMRsOSR0eOncooeCnnaYhfRYAfk9W1g5AHcpYp zzE1qNKYXtcokZfRohYt3sOF2xjC2+E= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-557-rVoIOx29OKiLfO7zS1vN0A-1; Thu, 14 Oct 2021 16:50:49 -0400 X-MC-Unique: rVoIOx29OKiLfO7zS1vN0A-1 Received: by mail-ed1-f70.google.com with SMTP id e14-20020a056402088e00b003db6ebb9526so6228880edy.22 for ; Thu, 14 Oct 2021 13:50:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=sypR1zkCMni3m2sdFQ3BSQIDoKFbj8FkIME4KbCvGjw=; b=NOsWrTC9KIiaAuUMIkkGhMX4dU2dsOM+41tPLEHHWUTexSCiguoXZFIGPToGofz19B Pkblt5vOLs12SzVqOE0atnwnNorssQXJHgwjbgegk09LFzOJw+/e31241/foA67g4SzW G/YfLnGX2nJ8KpMazDEhzYJgsC1lupO+aLhE1mEmvQz0XLx+reU9zD8FDr1o4kXQvgU8 LxOvxol7oUjwpBxewp8WbVFJf2NgNkpqWM9n7ddpoObXY5lCB+3F/b6P0pqJQLw4UwLU rhA22aqqVzNUl9sXk5y6cify8MK/e4rOedXe+c5sV+CGPEWtu8pEtidANeWmuxhu1D2I AiyA== X-Gm-Message-State: AOAM533JIdWZ6u1SUvNkWziut6CavGzCWq7KBXuRO8PlyibkGXEhgOrx E9rEfUuU95NvAq977dchz8KbgTtn+EyjJJcJwsjcYOFMSW7zbd+xTHMCSvLY5Lpvf6fYozeyrW2 wvyXvTn0rFwFZeSd0qnPIToAI X-Received: by 2002:a17:906:16d0:: with SMTP id t16mr1604029ejd.199.1634244648003; Thu, 14 Oct 2021 13:50:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJsui/zLztmaCtq7PZZAnYLvjtuLTIY7DyTbjU6/j2AfstfTpweChWvh8P8EnNk983+ht2hw== X-Received: by 2002:a17:906:16d0:: with SMTP id t16mr1603992ejd.199.1634244647742; Thu, 14 Oct 2021 13:50:47 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.gmail.com with ESMTPSA id s24sm3044871edy.38.2021.10.14.13.50.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Oct 2021 13:50:47 -0700 (PDT) Message-ID: Date: Thu, 14 Oct 2021 22:50:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [BUG] [5.15] Compilation error in arch/x86/kvm/mmu/spte.h with clang-14 Content-Language: en-US To: Nick Desaulniers , Sean Christopherson Cc: Nathan Chancellor , Jim Mattson , torvic9@mailbox.org, "vkuznets@redhat.com" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "bp@alien8.de" References: <1446878298.170497.1633338512925@office.mailbox.org> <936688112.157288.1633339838738@office.mailbox.org> From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/10/21 21:06, Nick Desaulniers wrote: >> If we want to fix this, my vote is for casting to an int and updating the comment > > At the least, I think bitwise operations should only be performed on > unsigned types. This is not a bitwise operation, it's a non-short-circuiting boolean operation. I'll apply Jim's suggestion. Paolo