From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD2E7C433DB for ; Tue, 9 Feb 2021 16:55:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1190C64EB8 for ; Tue, 9 Feb 2021 16:55:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1190C64EB8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=eik.bme.hu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9WIq-00036F-Ti for qemu-devel@archiver.kernel.org; Tue, 09 Feb 2021 11:55:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42846) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9WGG-0001fU-7g for qemu-devel@nongnu.org; Tue, 09 Feb 2021 11:53:12 -0500 Received: from zero.eik.bme.hu ([152.66.115.2]:40801) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9WGB-0008Ns-Kn for qemu-devel@nongnu.org; Tue, 09 Feb 2021 11:53:11 -0500 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id D8E767462FD; Tue, 9 Feb 2021 17:53:03 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 9E5767462D6; Tue, 9 Feb 2021 17:53:03 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id 9D0B57462D3; Tue, 9 Feb 2021 17:53:03 +0100 (CET) Date: Tue, 9 Feb 2021 17:53:03 +0100 (CET) From: BALATON Zoltan To: qemu-devel@nongnu.org Subject: Re: [PATCH 0/6] m68k: Overhaul of MOVEC instruction to support exception/MSP In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Received-SPF: pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Lucien Murray-Pitts Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 1 Feb 2021, BALATON Zoltan wrote: > Hello, > > This is Lucien's m68k series rebased on and fixed up to work with > current master as per previous discussion: > https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg02840.html > > I've left previous Reviewed-by tags for reference but these should > probably be reviewed again. I've only lightly tested it so I don't > know if everything is correct but it does seem to fix the problem my > original patch tried to fix at least. More testing, review and help to > finish this so it can be merged at last is welcome. Ping? > Regards, > BALATON Zoltan > > Lucien Murray-Pitts (6): > m68k: improve cpu instantiation comments > m68k: cascade m68k_features by m680xx_cpu_initfn() to improve > readability > m68k: improve comments on m68k_move_to/from helpers > m68k: add missing BUSCR/PCR CR defines, and BUSCR/PCR/CAAR CR to > m68k_move_to/from > m68k: MOVEC insn. should generate exception if wrong CR is accessed > m68k: add MSP detection support for stack pointer swap helpers > > target/m68k/cpu.c | 116 ++++++++++++++------ > target/m68k/cpu.h | 64 +++++++---- > target/m68k/helper.c | 234 +++++++++++++++++++++++++++++++--------- > target/m68k/translate.c | 2 +- > 4 files changed, 309 insertions(+), 107 deletions(-) > >