All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 04/15] env: Make the env save message a bit more explicit
Date: Tue, 16 Jan 2018 10:16:40 +0100	[thread overview]
Message-ID: <fb4570e173ecc41955abab25b17568fb23825e70.1516094113.git-series.maxime.ripard@free-electrons.com> (raw)
In-Reply-To: <cover.fedfb8856bdb3ebff3ce72afb6d0e1e0bcb9675c.1516094113.git-series.maxime.ripard@free-electrons.com>

Since we'll soon have support for multiple environments, the environment
saving message might end up being printed multiple times if the higher
priority environment cannot be used.

That might confuse the user, so let's make it explicit if the operation
failed or not.

Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Lukasz Majewski <lukma@denx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 env/env.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/env/env.c b/env/env.c
index 4dc39b384c1e..afffab4c002a 100644
--- a/env/env.c
+++ b/env/env.c
@@ -144,8 +144,9 @@ int env_save(void)
 		if (!drv->save)
 			continue;
 
-		printf("Saving Environment to %s...\n", drv->name);
+		printf("Saving Environment to %s... ", drv->name);
 		ret = drv->save();
+		printf("%s\n", ret ? "Failed" : "OK");
 		if (!ret)
 			return 0;
 
-- 
git-series 0.9.1

  parent reply	other threads:[~2018-01-16  9:16 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-16  9:16 [U-Boot] [PATCH v2 00/15] env: Multiple env support and env transition for sunxi Maxime Ripard
2018-01-16  9:16 ` [U-Boot] [PATCH v2 01/15] cmd: nvedit: Get rid of the env lookup Maxime Ripard
2018-01-16  9:16 ` [U-Boot] [PATCH v2 02/15] env: Rename env_driver_lookup_default and env_get_default_location Maxime Ripard
2018-01-16  9:16 ` [U-Boot] [PATCH v2 03/15] env: Pass additional parameters to the env lookup function Maxime Ripard
2018-01-17 22:03   ` Simon Glass
2018-01-18 14:54     ` Maxime Ripard
2018-01-16  9:16 ` Maxime Ripard [this message]
2018-01-16  9:16 ` [U-Boot] [PATCH v2 05/15] env: Make it explicit where we're loading our environment from Maxime Ripard
2018-01-16  9:16 ` [U-Boot] [PATCH v2 06/15] env: fat: Make the debug messages play a little nicer Maxime Ripard
2018-01-17 22:03   ` Simon Glass
2018-01-18 15:12     ` Maxime Ripard
2018-01-16  9:16 ` [U-Boot] [PATCH v2 07/15] env: mmc: " Maxime Ripard
2018-01-17 22:07   ` Simon Glass
2018-01-16  9:16 ` [U-Boot] [PATCH v2 08/15] env: common: " Maxime Ripard
2018-01-17 22:07   ` Simon Glass
2018-01-16  9:16 ` [U-Boot] [PATCH v2 09/15] env: Support multiple environments Maxime Ripard
2018-01-16  9:16 ` [U-Boot] [PATCH v2 10/15] env: Initialise all the environments Maxime Ripard
2018-01-17 22:07   ` Simon Glass
2018-01-16  9:16 ` [U-Boot] [PATCH v2 11/15] env: mmc: depends on the MMC framework Maxime Ripard
2018-01-17 22:07   ` Simon Glass
2018-01-16  9:16 ` [U-Boot] [PATCH v2 12/15] env: Allow to build multiple environments in Kconfig Maxime Ripard
2018-01-16  9:16 ` [U-Boot] [PATCH v2 13/15] env: Mark env_get_location as weak Maxime Ripard
2018-01-17 22:07   ` Simon Glass
2018-01-18 17:21     ` Maxime Ripard
2018-01-22  0:29       ` Simon Glass
2018-01-22 12:46         ` Maxime Ripard
2018-01-22 12:49           ` Tom Rini
2018-01-22 15:57             ` Maxime Ripard
2018-01-22 16:36               ` Tom Rini
2018-01-22 16:48                 ` Simon Glass
2018-01-22 17:08                   ` Tom Rini
2018-01-16  9:16 ` [U-Boot] [PATCH v2 14/15] sunxi: Transition from the MMC to a FAT-based environment Maxime Ripard
2018-01-16  9:16 ` [U-Boot] [PATCH v2 15/15] env: sunxi: Enable FAT-based environment support by default Maxime Ripard
2018-01-16 21:56 ` [U-Boot] [PATCH v2 00/15] env: Multiple env support and env transition for sunxi Tom Rini
2018-01-17  8:58   ` Maxime Ripard
2018-01-17 13:01     ` Tom Rini
2018-01-17 13:27       ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb4570e173ecc41955abab25b17568fb23825e70.1516094113.git-series.maxime.ripard@free-electrons.com \
    --to=maxime.ripard@free-electrons.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.