From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23E77C433E0 for ; Fri, 12 Feb 2021 07:03:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2FF264E57 for ; Fri, 12 Feb 2021 07:03:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229829AbhBLHDX (ORCPT ); Fri, 12 Feb 2021 02:03:23 -0500 Received: from foss.arm.com ([217.140.110.172]:33044 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229608AbhBLHDU (ORCPT ); Fri, 12 Feb 2021 02:03:20 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1D507113E; Thu, 11 Feb 2021 23:02:32 -0800 (PST) Received: from [192.168.0.130] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 313123F73D; Thu, 11 Feb 2021 23:02:27 -0800 (PST) From: Anshuman Khandual Subject: Re: [PATCH 0/3] mm/page_alloc: Fix pageblock_order with HUGETLB_PAGE_SIZE_VARIABLE To: David Hildenbrand , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, akpm@linux-foundation.org, will@kernel.org Cc: Robin Murphy , Marek Szyprowski , Christoph Hellwig , Mark Rutland , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org References: <1613024531-19040-1-git-send-email-anshuman.khandual@arm.com> <683c812a-ce3d-ef74-10d1-eaf8a3ae93d4@redhat.com> Message-ID: Date: Fri, 12 Feb 2021 12:32:56 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <683c812a-ce3d-ef74-10d1-eaf8a3ae93d4@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/11/21 2:07 PM, David Hildenbrand wrote: > On 11.02.21 07:22, Anshuman Khandual wrote: >> The following warning gets triggered while trying to boot a 64K page size >> without THP config kernel on arm64 platform. >> >> WARNING: CPU: 5 PID: 124 at mm/vmstat.c:1080 __fragmentation_index+0xa4/0xc0 >> Modules linked in: >> CPU: 5 PID: 124 Comm: kswapd0 Not tainted 5.11.0-rc6-00004-ga0ea7d62002 #159 >> Hardware name: linux,dummy-virt (DT) >> [    8.810673] pstate: 20400005 (nzCv daif +PAN -UAO -TCO BTYPE=--) >> [    8.811732] pc : __fragmentation_index+0xa4/0xc0 >> [    8.812555] lr : fragmentation_index+0xf8/0x138 >> [    8.813360] sp : ffff0000864079b0 >> [    8.813958] x29: ffff0000864079b0 x28: 0000000000000372 >> [    8.814901] x27: 0000000000007682 x26: ffff8000135b3948 >> [    8.815847] x25: 1fffe00010c80f48 x24: 0000000000000000 >> [    8.816805] x23: 0000000000000000 x22: 000000000000000d >> [    8.817764] x21: 0000000000000030 x20: ffff0005ffcb4d58 >> [    8.818712] x19: 000000000000000b x18: 0000000000000000 >> [    8.819656] x17: 0000000000000000 x16: 0000000000000000 >> [    8.820613] x15: 0000000000000000 x14: ffff8000114c6258 >> [    8.821560] x13: ffff6000bff969ba x12: 1fffe000bff969b9 >> [    8.822514] x11: 1fffe000bff969b9 x10: ffff6000bff969b9 >> [    8.823461] x9 : dfff800000000000 x8 : ffff0005ffcb4dcf >> [    8.824415] x7 : 0000000000000001 x6 : 0000000041b58ab3 >> [    8.825359] x5 : ffff600010c80f48 x4 : dfff800000000000 >> [    8.826313] x3 : ffff8000102be670 x2 : 0000000000000007 >> [    8.827259] x1 : ffff000086407a60 x0 : 000000000000000d >> [    8.828218] Call trace: >> [    8.828667]  __fragmentation_index+0xa4/0xc0 >> [    8.829436]  fragmentation_index+0xf8/0x138 >> [    8.830194]  compaction_suitable+0x98/0xb8 >> [    8.830934]  wakeup_kcompactd+0xdc/0x128 >> [    8.831640]  balance_pgdat+0x71c/0x7a0 >> [    8.832327]  kswapd+0x31c/0x520 >> [    8.832902]  kthread+0x224/0x230 >> [    8.833491]  ret_from_fork+0x10/0x30 >> [    8.834150] ---[ end trace 472836f79c15516b ]--- >> >> This warning comes from __fragmentation_index() when the requested order >> is greater than MAX_ORDER. >> >> static int __fragmentation_index(unsigned int order, >>                  struct contig_page_info *info) >> { >>          unsigned long requested = 1UL << order; >> >>          if (WARN_ON_ONCE(order >= MAX_ORDER)) <===== Triggered here >>                  return 0; >> >> Digging it further reveals that pageblock_order has been assigned a value >> which is greater than MAX_ORDER failing the above check. But why this >> happened ? Because HUGETLB_PAGE_ORDER for the given config on arm64 is >> greater than MAX_ORDER. >> >> The solution involves enabling HUGETLB_PAGE_SIZE_VARIABLE which would make >> pageblock_order a variable instead of constant HUGETLB_PAGE_ORDER. But that >> change alone also did not really work as pageblock_order still got assigned >> as HUGETLB_PAGE_ORDER in set_pageblock_order(). HUGETLB_PAGE_ORDER needs to >> be less than MAX_ORDER for its appropriateness as pageblock_order otherwise >> just fallback to MAX_ORDER - 1 as before. While here it also fixes a build >> problem via type casting MAX_ORDER in rmem_cma_setup(). > > I'm wondering, is there any real value in allowing FORCE_MAX_ZONEORDER to be "11" with ARM64_64K_PAGES/ARM64_16K_PAGES? MAX_ORDER should be as high as would be required for the current config. Unless THP is enabled, there is no need for it to be any higher than 11. But I might be missing historical reasons around this as well. Probably others from arm64 could help here. > > Meaning: are there any real use cases that actually build a kernel without TRANSPARENT_HUGEPAGE and with ARM64_64K_PAGES/ARM64_16K_PAGES? THP is always optional. Besides kernel builds without THP should always be supported. Assuming that all builds will have THP enabled, might not be accurate. > > As builds are essentially broken, I assume this is not that relevant? Or how long has it been broken? Git blame shows that it's been there for some time now. But how does that make this irrelevant ? A problem should be fixed nonetheless. > > It might be easier to just drop the "TRANSPARENT_HUGEPAGE" part from the FORCE_MAX_ZONEORDER config. > Not sure if it would be a good idea to unnecessarily have larger MAX_ORDER value for a given config. But I might be missing other contexts here. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26904C433DB for ; Fri, 12 Feb 2021 07:02:45 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9A9964DBA for ; Fri, 12 Feb 2021 07:02:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9A9964DBA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 7C0216F677 for ; Fri, 12 Feb 2021 07:02:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WMkRsY74kxNQ for ; Fri, 12 Feb 2021 07:02:43 +0000 (UTC) Received: by smtp3.osuosl.org (Postfix, from userid 1001) id AD5636F681; Fri, 12 Feb 2021 07:02:42 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTP id C9C026F606; Fri, 12 Feb 2021 07:02:38 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8316DC0174; Fri, 12 Feb 2021 07:02:38 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 86274C013A for ; Fri, 12 Feb 2021 07:02:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 6A8A487488 for ; Fri, 12 Feb 2021 07:02:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GdVEWAPGYe56 for ; Fri, 12 Feb 2021 07:02:33 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by hemlock.osuosl.org (Postfix) with ESMTP id 2B12B8748B for ; Fri, 12 Feb 2021 07:02:33 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1D507113E; Thu, 11 Feb 2021 23:02:32 -0800 (PST) Received: from [192.168.0.130] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 313123F73D; Thu, 11 Feb 2021 23:02:27 -0800 (PST) From: Anshuman Khandual Subject: Re: [PATCH 0/3] mm/page_alloc: Fix pageblock_order with HUGETLB_PAGE_SIZE_VARIABLE To: David Hildenbrand , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, akpm@linux-foundation.org, will@kernel.org References: <1613024531-19040-1-git-send-email-anshuman.khandual@arm.com> <683c812a-ce3d-ef74-10d1-eaf8a3ae93d4@redhat.com> Message-ID: Date: Fri, 12 Feb 2021 12:32:56 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <683c812a-ce3d-ef74-10d1-eaf8a3ae93d4@redhat.com> Content-Language: en-US Cc: Mark Rutland , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Robin Murphy , Christoph Hellwig X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Ck9uIDIvMTEvMjEgMjowNyBQTSwgRGF2aWQgSGlsZGVuYnJhbmQgd3JvdGU6Cj4gT24gMTEuMDIu MjEgMDc6MjIsIEFuc2h1bWFuIEtoYW5kdWFsIHdyb3RlOgo+PiBUaGUgZm9sbG93aW5nIHdhcm5p bmcgZ2V0cyB0cmlnZ2VyZWQgd2hpbGUgdHJ5aW5nIHRvIGJvb3QgYSA2NEsgcGFnZSBzaXplCj4+ IHdpdGhvdXQgVEhQIGNvbmZpZyBrZXJuZWwgb24gYXJtNjQgcGxhdGZvcm0uCj4+Cj4+IFdBUk5J Tkc6IENQVTogNSBQSUQ6IDEyNCBhdCBtbS92bXN0YXQuYzoxMDgwIF9fZnJhZ21lbnRhdGlvbl9p bmRleCsweGE0LzB4YzAKPj4gTW9kdWxlcyBsaW5rZWQgaW46Cj4+IENQVTogNSBQSUQ6IDEyNCBD b21tOiBrc3dhcGQwIE5vdCB0YWludGVkIDUuMTEuMC1yYzYtMDAwMDQtZ2EwZWE3ZDYyMDAyICMx NTkKPj4gSGFyZHdhcmUgbmFtZTogbGludXgsZHVtbXktdmlydCAoRFQpCj4+IFvCoMKgwqAgOC44 MTA2NzNdIHBzdGF0ZTogMjA0MDAwMDUgKG56Q3YgZGFpZiArUEFOIC1VQU8gLVRDTyBCVFlQRT0t LSkKPj4gW8KgwqDCoCA4LjgxMTczMl0gcGMgOiBfX2ZyYWdtZW50YXRpb25faW5kZXgrMHhhNC8w eGMwCj4+IFvCoMKgwqAgOC44MTI1NTVdIGxyIDogZnJhZ21lbnRhdGlvbl9pbmRleCsweGY4LzB4 MTM4Cj4+IFvCoMKgwqAgOC44MTMzNjBdIHNwIDogZmZmZjAwMDA4NjQwNzliMAo+PiBbwqDCoMKg IDguODEzOTU4XSB4Mjk6IGZmZmYwMDAwODY0MDc5YjAgeDI4OiAwMDAwMDAwMDAwMDAwMzcyCj4+ IFvCoMKgwqAgOC44MTQ5MDFdIHgyNzogMDAwMDAwMDAwMDAwNzY4MiB4MjY6IGZmZmY4MDAwMTM1 YjM5NDgKPj4gW8KgwqDCoCA4LjgxNTg0N10geDI1OiAxZmZmZTAwMDEwYzgwZjQ4IHgyNDogMDAw MDAwMDAwMDAwMDAwMAo+PiBbwqDCoMKgIDguODE2ODA1XSB4MjM6IDAwMDAwMDAwMDAwMDAwMDAg eDIyOiAwMDAwMDAwMDAwMDAwMDBkCj4+IFvCoMKgwqAgOC44MTc3NjRdIHgyMTogMDAwMDAwMDAw MDAwMDAzMCB4MjA6IGZmZmYwMDA1ZmZjYjRkNTgKPj4gW8KgwqDCoCA4LjgxODcxMl0geDE5OiAw MDAwMDAwMDAwMDAwMDBiIHgxODogMDAwMDAwMDAwMDAwMDAwMAo+PiBbwqDCoMKgIDguODE5NjU2 XSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwCj4+IFvCoMKgwqAg OC44MjA2MTNdIHgxNTogMDAwMDAwMDAwMDAwMDAwMCB4MTQ6IGZmZmY4MDAwMTE0YzYyNTgKPj4g W8KgwqDCoCA4LjgyMTU2MF0geDEzOiBmZmZmNjAwMGJmZjk2OWJhIHgxMjogMWZmZmUwMDBiZmY5 NjliOQo+PiBbwqDCoMKgIDguODIyNTE0XSB4MTE6IDFmZmZlMDAwYmZmOTY5YjkgeDEwOiBmZmZm NjAwMGJmZjk2OWI5Cj4+IFvCoMKgwqAgOC44MjM0NjFdIHg5IDogZGZmZjgwMDAwMDAwMDAwMCB4 OCA6IGZmZmYwMDA1ZmZjYjRkY2YKPj4gW8KgwqDCoCA4LjgyNDQxNV0geDcgOiAwMDAwMDAwMDAw MDAwMDAxIHg2IDogMDAwMDAwMDA0MWI1OGFiMwo+PiBbwqDCoMKgIDguODI1MzU5XSB4NSA6IGZm ZmY2MDAwMTBjODBmNDggeDQgOiBkZmZmODAwMDAwMDAwMDAwCj4+IFvCoMKgwqAgOC44MjYzMTNd IHgzIDogZmZmZjgwMDAxMDJiZTY3MCB4MiA6IDAwMDAwMDAwMDAwMDAwMDcKPj4gW8KgwqDCoCA4 LjgyNzI1OV0geDEgOiBmZmZmMDAwMDg2NDA3YTYwIHgwIDogMDAwMDAwMDAwMDAwMDAwZAo+PiBb wqDCoMKgIDguODI4MjE4XSBDYWxsIHRyYWNlOgo+PiBbwqDCoMKgIDguODI4NjY3XcKgIF9fZnJh Z21lbnRhdGlvbl9pbmRleCsweGE0LzB4YzAKPj4gW8KgwqDCoCA4LjgyOTQzNl3CoCBmcmFnbWVu dGF0aW9uX2luZGV4KzB4ZjgvMHgxMzgKPj4gW8KgwqDCoCA4LjgzMDE5NF3CoCBjb21wYWN0aW9u X3N1aXRhYmxlKzB4OTgvMHhiOAo+PiBbwqDCoMKgIDguODMwOTM0XcKgIHdha2V1cF9rY29tcGFj dGQrMHhkYy8weDEyOAo+PiBbwqDCoMKgIDguODMxNjQwXcKgIGJhbGFuY2VfcGdkYXQrMHg3MWMv MHg3YTAKPj4gW8KgwqDCoCA4LjgzMjMyN13CoCBrc3dhcGQrMHgzMWMvMHg1MjAKPj4gW8KgwqDC oCA4LjgzMjkwMl3CoCBrdGhyZWFkKzB4MjI0LzB4MjMwCj4+IFvCoMKgwqAgOC44MzM0OTFdwqAg cmV0X2Zyb21fZm9yaysweDEwLzB4MzAKPj4gW8KgwqDCoCA4LjgzNDE1MF0gLS0tWyBlbmQgdHJh Y2UgNDcyODM2Zjc5YzE1NTE2YiBdLS0tCj4+Cj4+IFRoaXMgd2FybmluZyBjb21lcyBmcm9tIF9f ZnJhZ21lbnRhdGlvbl9pbmRleCgpIHdoZW4gdGhlIHJlcXVlc3RlZCBvcmRlcgo+PiBpcyBncmVh dGVyIHRoYW4gTUFYX09SREVSLgo+Pgo+PiBzdGF0aWMgaW50IF9fZnJhZ21lbnRhdGlvbl9pbmRl eCh1bnNpZ25lZCBpbnQgb3JkZXIsCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IHN0cnVjdCBjb250aWdfcGFnZV9pbmZvICppbmZvKQo+PiB7Cj4+IMKgwqDCoMKgwqDCoMKgwqAg dW5zaWduZWQgbG9uZyByZXF1ZXN0ZWQgPSAxVUwgPDwgb3JkZXI7Cj4+Cj4+IMKgwqDCoMKgwqDC oMKgwqAgaWYgKFdBUk5fT05fT05DRShvcmRlciA+PSBNQVhfT1JERVIpKSA8PT09PT0gVHJpZ2dl cmVkIGhlcmUKPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIDA7Cj4+ Cj4+IERpZ2dpbmcgaXQgZnVydGhlciByZXZlYWxzIHRoYXQgcGFnZWJsb2NrX29yZGVyIGhhcyBi ZWVuIGFzc2lnbmVkIGEgdmFsdWUKPj4gd2hpY2ggaXMgZ3JlYXRlciB0aGFuIE1BWF9PUkRFUiBm YWlsaW5nIHRoZSBhYm92ZSBjaGVjay4gQnV0IHdoeSB0aGlzCj4+IGhhcHBlbmVkID8gQmVjYXVz ZSBIVUdFVExCX1BBR0VfT1JERVIgZm9yIHRoZSBnaXZlbiBjb25maWcgb24gYXJtNjQgaXMKPj4g Z3JlYXRlciB0aGFuIE1BWF9PUkRFUi4KPj4KPj4gVGhlIHNvbHV0aW9uIGludm9sdmVzIGVuYWJs aW5nIEhVR0VUTEJfUEFHRV9TSVpFX1ZBUklBQkxFIHdoaWNoIHdvdWxkIG1ha2UKPj4gcGFnZWJs b2NrX29yZGVyIGEgdmFyaWFibGUgaW5zdGVhZCBvZiBjb25zdGFudCBIVUdFVExCX1BBR0VfT1JE RVIuIEJ1dCB0aGF0Cj4+IGNoYW5nZSBhbG9uZSBhbHNvIGRpZCBub3QgcmVhbGx5IHdvcmsgYXMg cGFnZWJsb2NrX29yZGVyIHN0aWxsIGdvdCBhc3NpZ25lZAo+PiBhcyBIVUdFVExCX1BBR0VfT1JE RVIgaW4gc2V0X3BhZ2VibG9ja19vcmRlcigpLiBIVUdFVExCX1BBR0VfT1JERVIgbmVlZHMgdG8K Pj4gYmUgbGVzcyB0aGFuIE1BWF9PUkRFUiBmb3IgaXRzIGFwcHJvcHJpYXRlbmVzcyBhcyBwYWdl YmxvY2tfb3JkZXIgb3RoZXJ3aXNlCj4+IGp1c3QgZmFsbGJhY2sgdG8gTUFYX09SREVSIC0gMSBh cyBiZWZvcmUuIFdoaWxlIGhlcmUgaXQgYWxzbyBmaXhlcyBhIGJ1aWxkCj4+IHByb2JsZW0gdmlh IHR5cGUgY2FzdGluZyBNQVhfT1JERVIgaW4gcm1lbV9jbWFfc2V0dXAoKS4KPiAKPiBJJ20gd29u ZGVyaW5nLCBpcyB0aGVyZSBhbnkgcmVhbCB2YWx1ZSBpbiBhbGxvd2luZyBGT1JDRV9NQVhfWk9O RU9SREVSIHRvIGJlICIxMSIgd2l0aCBBUk02NF82NEtfUEFHRVMvQVJNNjRfMTZLX1BBR0VTPwoK TUFYX09SREVSIHNob3VsZCBiZSBhcyBoaWdoIGFzIHdvdWxkIGJlIHJlcXVpcmVkIGZvciB0aGUg Y3VycmVudCBjb25maWcuClVubGVzcyBUSFAgaXMgZW5hYmxlZCwgdGhlcmUgaXMgbm8gbmVlZCBm b3IgaXQgdG8gYmUgYW55IGhpZ2hlciB0aGFuIDExLgpCdXQgSSBtaWdodCBiZSBtaXNzaW5nIGhp c3RvcmljYWwgcmVhc29ucyBhcm91bmQgdGhpcyBhcyB3ZWxsLiBQcm9iYWJseQpvdGhlcnMgZnJv bSBhcm02NCBjb3VsZCBoZWxwIGhlcmUuCgo+IAo+IE1lYW5pbmc6IGFyZSB0aGVyZSBhbnkgcmVh bCB1c2UgY2FzZXMgdGhhdCBhY3R1YWxseSBidWlsZCBhIGtlcm5lbCB3aXRob3V0IFRSQU5TUEFS RU5UX0hVR0VQQUdFIGFuZCB3aXRoIEFSTTY0XzY0S19QQUdFUy9BUk02NF8xNktfUEFHRVM/CgpU SFAgaXMgYWx3YXlzIG9wdGlvbmFsLiBCZXNpZGVzIGtlcm5lbCBidWlsZHMgd2l0aG91dCBUSFAg c2hvdWxkIGFsd2F5cwpiZSBzdXBwb3J0ZWQuIEFzc3VtaW5nIHRoYXQgYWxsIGJ1aWxkcyB3aWxs IGhhdmUgVEhQIGVuYWJsZWQsIG1pZ2h0IG5vdApiZSBhY2N1cmF0ZS4KCj4gCj4gQXMgYnVpbGRz IGFyZSBlc3NlbnRpYWxseSBicm9rZW4sIEkgYXNzdW1lIHRoaXMgaXMgbm90IHRoYXQgcmVsZXZh bnQ/IE9yIGhvdyBsb25nIGhhcyBpdCBiZWVuIGJyb2tlbj8KCkdpdCBibGFtZSBzaG93cyB0aGF0 IGl0J3MgYmVlbiB0aGVyZSBmb3Igc29tZSB0aW1lIG5vdy4gQnV0IGhvdyBkb2VzCnRoYXQgbWFr ZSB0aGlzIGlycmVsZXZhbnQgPyBBIHByb2JsZW0gc2hvdWxkIGJlIGZpeGVkIG5vbmV0aGVsZXNz LgoKPiAKPiBJdCBtaWdodCBiZSBlYXNpZXIgdG8ganVzdCBkcm9wIHRoZSAiVFJBTlNQQVJFTlRf SFVHRVBBR0UiIHBhcnQgZnJvbSB0aGUgRk9SQ0VfTUFYX1pPTkVPUkRFUiBjb25maWcuCj4gCgpO b3Qgc3VyZSBpZiBpdCB3b3VsZCBiZSBhIGdvb2QgaWRlYSB0byB1bm5lY2Vzc2FyaWx5IGhhdmUg bGFyZ2VyIE1BWF9PUkRFUgp2YWx1ZSBmb3IgYSBnaXZlbiBjb25maWcuIEJ1dCBJIG1pZ2h0IGJl IG1pc3Npbmcgb3RoZXIgY29udGV4dHMgaGVyZS4KX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KaW9tbXUgbWFpbGluZyBsaXN0CmlvbW11QGxpc3RzLmxpbnV4 LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2lvbW11 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9FD7C433DB for ; Fri, 12 Feb 2021 07:04:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85EB464E57 for ; Fri, 12 Feb 2021 07:04:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85EB464E57 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:Subject:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cLtGA1GodDke67txuQM7qrmSDPuPsv0+VZuOqAwuOaU=; b=0pwgaE4lx4Ixl/PYe6rwyKyMQ VnUGZkxbZsmka+EijyWBs9e/KQ5HCMwh1TBBFIU+4SJ6KuCDO2dHoEthPpvaTohpKu5fUSNKoxUMD IGBBufAFXR7JVpRf6qad8A1wdSaX7b9NluXyBrXiQhnAgzsncBk/duICrpfvFkHtZcieagzXxTuuj 9f80etfOFiwx0iP5gHDH98XBd4kBf9kY1zv7gENHMSIZT+8SjEi0kwULs43G5yz1MZ6jSHRQKqF8T KYgvzdIVp+h/34McD6KDkVnry2UXkTo0jazCwqrN4VnR5xLbGsRFLWOOrAiS6KGFIyRhjD7aNG2lw u3vD/0byg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lASTS-0004r2-1q; Fri, 12 Feb 2021 07:02:42 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lASTP-0004qf-BD for linux-arm-kernel@lists.infradead.org; Fri, 12 Feb 2021 07:02:40 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1D507113E; Thu, 11 Feb 2021 23:02:32 -0800 (PST) Received: from [192.168.0.130] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 313123F73D; Thu, 11 Feb 2021 23:02:27 -0800 (PST) From: Anshuman Khandual Subject: Re: [PATCH 0/3] mm/page_alloc: Fix pageblock_order with HUGETLB_PAGE_SIZE_VARIABLE To: David Hildenbrand , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, akpm@linux-foundation.org, will@kernel.org References: <1613024531-19040-1-git-send-email-anshuman.khandual@arm.com> <683c812a-ce3d-ef74-10d1-eaf8a3ae93d4@redhat.com> Message-ID: Date: Fri, 12 Feb 2021 12:32:56 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <683c812a-ce3d-ef74-10d1-eaf8a3ae93d4@redhat.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210212_020239_507069_D5902927 X-CRM114-Status: GOOD ( 20.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Robin Murphy , Christoph Hellwig , Marek Szyprowski Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDIvMTEvMjEgMjowNyBQTSwgRGF2aWQgSGlsZGVuYnJhbmQgd3JvdGU6Cj4gT24gMTEuMDIu MjEgMDc6MjIsIEFuc2h1bWFuIEtoYW5kdWFsIHdyb3RlOgo+PiBUaGUgZm9sbG93aW5nIHdhcm5p bmcgZ2V0cyB0cmlnZ2VyZWQgd2hpbGUgdHJ5aW5nIHRvIGJvb3QgYSA2NEsgcGFnZSBzaXplCj4+ IHdpdGhvdXQgVEhQIGNvbmZpZyBrZXJuZWwgb24gYXJtNjQgcGxhdGZvcm0uCj4+Cj4+IFdBUk5J Tkc6IENQVTogNSBQSUQ6IDEyNCBhdCBtbS92bXN0YXQuYzoxMDgwIF9fZnJhZ21lbnRhdGlvbl9p bmRleCsweGE0LzB4YzAKPj4gTW9kdWxlcyBsaW5rZWQgaW46Cj4+IENQVTogNSBQSUQ6IDEyNCBD b21tOiBrc3dhcGQwIE5vdCB0YWludGVkIDUuMTEuMC1yYzYtMDAwMDQtZ2EwZWE3ZDYyMDAyICMx NTkKPj4gSGFyZHdhcmUgbmFtZTogbGludXgsZHVtbXktdmlydCAoRFQpCj4+IFvCoMKgwqAgOC44 MTA2NzNdIHBzdGF0ZTogMjA0MDAwMDUgKG56Q3YgZGFpZiArUEFOIC1VQU8gLVRDTyBCVFlQRT0t LSkKPj4gW8KgwqDCoCA4LjgxMTczMl0gcGMgOiBfX2ZyYWdtZW50YXRpb25faW5kZXgrMHhhNC8w eGMwCj4+IFvCoMKgwqAgOC44MTI1NTVdIGxyIDogZnJhZ21lbnRhdGlvbl9pbmRleCsweGY4LzB4 MTM4Cj4+IFvCoMKgwqAgOC44MTMzNjBdIHNwIDogZmZmZjAwMDA4NjQwNzliMAo+PiBbwqDCoMKg IDguODEzOTU4XSB4Mjk6IGZmZmYwMDAwODY0MDc5YjAgeDI4OiAwMDAwMDAwMDAwMDAwMzcyCj4+ IFvCoMKgwqAgOC44MTQ5MDFdIHgyNzogMDAwMDAwMDAwMDAwNzY4MiB4MjY6IGZmZmY4MDAwMTM1 YjM5NDgKPj4gW8KgwqDCoCA4LjgxNTg0N10geDI1OiAxZmZmZTAwMDEwYzgwZjQ4IHgyNDogMDAw MDAwMDAwMDAwMDAwMAo+PiBbwqDCoMKgIDguODE2ODA1XSB4MjM6IDAwMDAwMDAwMDAwMDAwMDAg eDIyOiAwMDAwMDAwMDAwMDAwMDBkCj4+IFvCoMKgwqAgOC44MTc3NjRdIHgyMTogMDAwMDAwMDAw MDAwMDAzMCB4MjA6IGZmZmYwMDA1ZmZjYjRkNTgKPj4gW8KgwqDCoCA4LjgxODcxMl0geDE5OiAw MDAwMDAwMDAwMDAwMDBiIHgxODogMDAwMDAwMDAwMDAwMDAwMAo+PiBbwqDCoMKgIDguODE5NjU2 XSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiAwMDAwMDAwMDAwMDAwMDAwCj4+IFvCoMKgwqAg OC44MjA2MTNdIHgxNTogMDAwMDAwMDAwMDAwMDAwMCB4MTQ6IGZmZmY4MDAwMTE0YzYyNTgKPj4g W8KgwqDCoCA4LjgyMTU2MF0geDEzOiBmZmZmNjAwMGJmZjk2OWJhIHgxMjogMWZmZmUwMDBiZmY5 NjliOQo+PiBbwqDCoMKgIDguODIyNTE0XSB4MTE6IDFmZmZlMDAwYmZmOTY5YjkgeDEwOiBmZmZm NjAwMGJmZjk2OWI5Cj4+IFvCoMKgwqAgOC44MjM0NjFdIHg5IDogZGZmZjgwMDAwMDAwMDAwMCB4 OCA6IGZmZmYwMDA1ZmZjYjRkY2YKPj4gW8KgwqDCoCA4LjgyNDQxNV0geDcgOiAwMDAwMDAwMDAw MDAwMDAxIHg2IDogMDAwMDAwMDA0MWI1OGFiMwo+PiBbwqDCoMKgIDguODI1MzU5XSB4NSA6IGZm ZmY2MDAwMTBjODBmNDggeDQgOiBkZmZmODAwMDAwMDAwMDAwCj4+IFvCoMKgwqAgOC44MjYzMTNd IHgzIDogZmZmZjgwMDAxMDJiZTY3MCB4MiA6IDAwMDAwMDAwMDAwMDAwMDcKPj4gW8KgwqDCoCA4 LjgyNzI1OV0geDEgOiBmZmZmMDAwMDg2NDA3YTYwIHgwIDogMDAwMDAwMDAwMDAwMDAwZAo+PiBb wqDCoMKgIDguODI4MjE4XSBDYWxsIHRyYWNlOgo+PiBbwqDCoMKgIDguODI4NjY3XcKgIF9fZnJh Z21lbnRhdGlvbl9pbmRleCsweGE0LzB4YzAKPj4gW8KgwqDCoCA4LjgyOTQzNl3CoCBmcmFnbWVu dGF0aW9uX2luZGV4KzB4ZjgvMHgxMzgKPj4gW8KgwqDCoCA4LjgzMDE5NF3CoCBjb21wYWN0aW9u X3N1aXRhYmxlKzB4OTgvMHhiOAo+PiBbwqDCoMKgIDguODMwOTM0XcKgIHdha2V1cF9rY29tcGFj dGQrMHhkYy8weDEyOAo+PiBbwqDCoMKgIDguODMxNjQwXcKgIGJhbGFuY2VfcGdkYXQrMHg3MWMv MHg3YTAKPj4gW8KgwqDCoCA4LjgzMjMyN13CoCBrc3dhcGQrMHgzMWMvMHg1MjAKPj4gW8KgwqDC oCA4LjgzMjkwMl3CoCBrdGhyZWFkKzB4MjI0LzB4MjMwCj4+IFvCoMKgwqAgOC44MzM0OTFdwqAg cmV0X2Zyb21fZm9yaysweDEwLzB4MzAKPj4gW8KgwqDCoCA4LjgzNDE1MF0gLS0tWyBlbmQgdHJh Y2UgNDcyODM2Zjc5YzE1NTE2YiBdLS0tCj4+Cj4+IFRoaXMgd2FybmluZyBjb21lcyBmcm9tIF9f ZnJhZ21lbnRhdGlvbl9pbmRleCgpIHdoZW4gdGhlIHJlcXVlc3RlZCBvcmRlcgo+PiBpcyBncmVh dGVyIHRoYW4gTUFYX09SREVSLgo+Pgo+PiBzdGF0aWMgaW50IF9fZnJhZ21lbnRhdGlvbl9pbmRl eCh1bnNpZ25lZCBpbnQgb3JkZXIsCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IHN0cnVjdCBjb250aWdfcGFnZV9pbmZvICppbmZvKQo+PiB7Cj4+IMKgwqDCoMKgwqDCoMKgwqAg dW5zaWduZWQgbG9uZyByZXF1ZXN0ZWQgPSAxVUwgPDwgb3JkZXI7Cj4+Cj4+IMKgwqDCoMKgwqDC oMKgwqAgaWYgKFdBUk5fT05fT05DRShvcmRlciA+PSBNQVhfT1JERVIpKSA8PT09PT0gVHJpZ2dl cmVkIGhlcmUKPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIDA7Cj4+ Cj4+IERpZ2dpbmcgaXQgZnVydGhlciByZXZlYWxzIHRoYXQgcGFnZWJsb2NrX29yZGVyIGhhcyBi ZWVuIGFzc2lnbmVkIGEgdmFsdWUKPj4gd2hpY2ggaXMgZ3JlYXRlciB0aGFuIE1BWF9PUkRFUiBm YWlsaW5nIHRoZSBhYm92ZSBjaGVjay4gQnV0IHdoeSB0aGlzCj4+IGhhcHBlbmVkID8gQmVjYXVz ZSBIVUdFVExCX1BBR0VfT1JERVIgZm9yIHRoZSBnaXZlbiBjb25maWcgb24gYXJtNjQgaXMKPj4g Z3JlYXRlciB0aGFuIE1BWF9PUkRFUi4KPj4KPj4gVGhlIHNvbHV0aW9uIGludm9sdmVzIGVuYWJs aW5nIEhVR0VUTEJfUEFHRV9TSVpFX1ZBUklBQkxFIHdoaWNoIHdvdWxkIG1ha2UKPj4gcGFnZWJs b2NrX29yZGVyIGEgdmFyaWFibGUgaW5zdGVhZCBvZiBjb25zdGFudCBIVUdFVExCX1BBR0VfT1JE RVIuIEJ1dCB0aGF0Cj4+IGNoYW5nZSBhbG9uZSBhbHNvIGRpZCBub3QgcmVhbGx5IHdvcmsgYXMg cGFnZWJsb2NrX29yZGVyIHN0aWxsIGdvdCBhc3NpZ25lZAo+PiBhcyBIVUdFVExCX1BBR0VfT1JE RVIgaW4gc2V0X3BhZ2VibG9ja19vcmRlcigpLiBIVUdFVExCX1BBR0VfT1JERVIgbmVlZHMgdG8K Pj4gYmUgbGVzcyB0aGFuIE1BWF9PUkRFUiBmb3IgaXRzIGFwcHJvcHJpYXRlbmVzcyBhcyBwYWdl YmxvY2tfb3JkZXIgb3RoZXJ3aXNlCj4+IGp1c3QgZmFsbGJhY2sgdG8gTUFYX09SREVSIC0gMSBh cyBiZWZvcmUuIFdoaWxlIGhlcmUgaXQgYWxzbyBmaXhlcyBhIGJ1aWxkCj4+IHByb2JsZW0gdmlh IHR5cGUgY2FzdGluZyBNQVhfT1JERVIgaW4gcm1lbV9jbWFfc2V0dXAoKS4KPiAKPiBJJ20gd29u ZGVyaW5nLCBpcyB0aGVyZSBhbnkgcmVhbCB2YWx1ZSBpbiBhbGxvd2luZyBGT1JDRV9NQVhfWk9O RU9SREVSIHRvIGJlICIxMSIgd2l0aCBBUk02NF82NEtfUEFHRVMvQVJNNjRfMTZLX1BBR0VTPwoK TUFYX09SREVSIHNob3VsZCBiZSBhcyBoaWdoIGFzIHdvdWxkIGJlIHJlcXVpcmVkIGZvciB0aGUg Y3VycmVudCBjb25maWcuClVubGVzcyBUSFAgaXMgZW5hYmxlZCwgdGhlcmUgaXMgbm8gbmVlZCBm b3IgaXQgdG8gYmUgYW55IGhpZ2hlciB0aGFuIDExLgpCdXQgSSBtaWdodCBiZSBtaXNzaW5nIGhp c3RvcmljYWwgcmVhc29ucyBhcm91bmQgdGhpcyBhcyB3ZWxsLiBQcm9iYWJseQpvdGhlcnMgZnJv bSBhcm02NCBjb3VsZCBoZWxwIGhlcmUuCgo+IAo+IE1lYW5pbmc6IGFyZSB0aGVyZSBhbnkgcmVh bCB1c2UgY2FzZXMgdGhhdCBhY3R1YWxseSBidWlsZCBhIGtlcm5lbCB3aXRob3V0IFRSQU5TUEFS RU5UX0hVR0VQQUdFIGFuZCB3aXRoIEFSTTY0XzY0S19QQUdFUy9BUk02NF8xNktfUEFHRVM/CgpU SFAgaXMgYWx3YXlzIG9wdGlvbmFsLiBCZXNpZGVzIGtlcm5lbCBidWlsZHMgd2l0aG91dCBUSFAg c2hvdWxkIGFsd2F5cwpiZSBzdXBwb3J0ZWQuIEFzc3VtaW5nIHRoYXQgYWxsIGJ1aWxkcyB3aWxs IGhhdmUgVEhQIGVuYWJsZWQsIG1pZ2h0IG5vdApiZSBhY2N1cmF0ZS4KCj4gCj4gQXMgYnVpbGRz IGFyZSBlc3NlbnRpYWxseSBicm9rZW4sIEkgYXNzdW1lIHRoaXMgaXMgbm90IHRoYXQgcmVsZXZh bnQ/IE9yIGhvdyBsb25nIGhhcyBpdCBiZWVuIGJyb2tlbj8KCkdpdCBibGFtZSBzaG93cyB0aGF0 IGl0J3MgYmVlbiB0aGVyZSBmb3Igc29tZSB0aW1lIG5vdy4gQnV0IGhvdyBkb2VzCnRoYXQgbWFr ZSB0aGlzIGlycmVsZXZhbnQgPyBBIHByb2JsZW0gc2hvdWxkIGJlIGZpeGVkIG5vbmV0aGVsZXNz LgoKPiAKPiBJdCBtaWdodCBiZSBlYXNpZXIgdG8ganVzdCBkcm9wIHRoZSAiVFJBTlNQQVJFTlRf SFVHRVBBR0UiIHBhcnQgZnJvbSB0aGUgRk9SQ0VfTUFYX1pPTkVPUkRFUiBjb25maWcuCj4gCgpO b3Qgc3VyZSBpZiBpdCB3b3VsZCBiZSBhIGdvb2QgaWRlYSB0byB1bm5lY2Vzc2FyaWx5IGhhdmUg bGFyZ2VyIE1BWF9PUkRFUgp2YWx1ZSBmb3IgYSBnaXZlbiBjb25maWcuIEJ1dCBJIG1pZ2h0IGJl IG1pc3Npbmcgb3RoZXIgY29udGV4dHMgaGVyZS4KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK