From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>, xen-devel@lists.xenproject.org
Cc: linux-kernel@vger.kernel.org, Juergen Gross <jgross@suse.com>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] xen/manage: don't complain about an empty value in control/sysrq node
Date: Thu, 6 Sep 2018 15:41:22 -0400 [thread overview]
Message-ID: <fb58e2c8-ffc4-dc5d-9625-6170f3fe7195@oracle.com> (raw)
In-Reply-To: <20180906112608.4221-1-vkuznets@redhat.com>
On 09/06/2018 07:26 AM, Vitaly Kuznetsov wrote:
> When guest receives a sysrq request from the host it acknowledges it by
> writing '\0' to control/sysrq xenstore node. This, however, make xenstore
> watch fire again but xenbus_scanf() fails to parse empty value with "%c"
> format string:
>
> sysrq: SysRq : Emergency Sync
> Emergency Sync complete
> xen:manage: Error -34 reading sysrq code in control/sysrq
>
> Ignore -ERANGE the same way we already ignore -ENOENT, empty value in
> control/sysrq is totally legal.
>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>
Applied to for-linus-19b.
-boris
next prev parent reply other threads:[~2018-09-06 19:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 11:26 [PATCH] xen/manage: don't complain about an empty value in control/sysrq node Vitaly Kuznetsov
2018-09-06 13:00 ` Wei Liu
2018-09-06 13:00 ` Wei Liu
2018-09-06 19:41 ` Boris Ostrovsky [this message]
2018-09-06 19:41 ` Boris Ostrovsky
-- strict thread matches above, loose matches on Subject: below --
2018-09-06 11:26 Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb58e2c8-ffc4-dc5d-9625-6170f3fe7195@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vkuznets@redhat.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.