From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E54B8C433E0 for ; Mon, 18 Jan 2021 18:50:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B249422C9E for ; Mon, 18 Jan 2021 18:50:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407762AbhARStk (ORCPT ); Mon, 18 Jan 2021 13:49:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407791AbhARStZ (ORCPT ); Mon, 18 Jan 2021 13:49:25 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93983C061573; Mon, 18 Jan 2021 10:48:44 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id o19so25518589lfo.1; Mon, 18 Jan 2021 10:48:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fxMA13avbLKRVNuLOjk7rttK6AhcMCADubVPJWhkVMc=; b=NU6eEJPevw5HPjNo6Xtu6KxAdjB73bNvuWYXa6QbL7vci0lTcpvMZ9tsd0PYzXt9OU JQu8x+I+8Fmr+XuDMyt407jnaqDhwF6N0QphhxwRuSg1j6ze+Y1E/9UjCNCBk7GtAc/d YcBGYPPJviT83DzmtGH1VPFQUVtmCtndVMDi6QtzL/VVQRtTi41taoSgip1K1HwfG2q+ HMi5E8uG0PUGs20sQ8Q2TRiPYQbxf8/yn+e0R6YBP2eBd9e77EkFMvHBWvKz4dHfQ+GY J1IuDAWoUiYR1Lz/VNlGkM7wPp88caBXrf5GEWrh6/G3Rge+dsdqazTNPVAY04PHMppS l3ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fxMA13avbLKRVNuLOjk7rttK6AhcMCADubVPJWhkVMc=; b=tCbHqotvUFHISUo6L5jadKYWe18CFwU3OXD08eR1VWC98Ll6b72Uf7bdXK/d4O4XzO SonnzQaOtgu702a67ZzEGXOh5RYhhYiBB1Tn13WV9nveqc0hEMXuFeGrwobkMo1/6Fy4 xF3/WcvNSe2aCgyG2QewW9aDk0I31AENbn2hn7NbmbMEd/RVPI66Y9pQrwxsr8m2Q4rj 4eOHSFn0KTuGMjmGbTte6S/PgEDv2SntM9kJ5gAHFNMvHyZCLcCCO9Pa7BBQm9LFZB82 s6VgvYlRWQj7/hkiXIltVc0wkkoKK2rO2dSORHPOzsKoodiRoYninXgIlgCPGd9Z9Zwm 5mZg== X-Gm-Message-State: AOAM5305feXRQdhbwecZ2pHAVS5EjV6mL9qVEsrS9dvK158qFduoFl3y GYqpdEpdAIc7X5jBww+SoHQEK1QvJP0= X-Google-Smtp-Source: ABdhPJzAMYRyR3MYxq+vBNNn5NqDhFjn4tImMiGrXpkA0xSDwCW4upNQtCvBFxo4RdTHGile9/DGng== X-Received: by 2002:a19:5e5b:: with SMTP id z27mr201701lfi.143.1610995722954; Mon, 18 Jan 2021 10:48:42 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id s2sm1703802ljj.100.2021.01.18.10.48.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jan 2021 10:48:42 -0800 (PST) Subject: Re: [PATCH v3 10/12] opp: Support set_opp() customization without requiring to use regulators To: Viresh Kumar Cc: Thierry Reding , Jonathan Hunter , Mark Brown , Liam Girdwood , Ulf Hansson , Peter Geis , Nicolas Chauvet , "Rafael J. Wysocki" , Kevin Hilman , Peter De Schrijver , Viresh Kumar , Stephen Boyd , Nishanth Menon , Yangtao Li , Matt Merhar , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org References: <20210118005524.27787-1-digetx@gmail.com> <20210118005524.27787-11-digetx@gmail.com> <20210118114451.5mpuvgnhhajx4b3y@vireshk-i7> From: Dmitry Osipenko Message-ID: Date: Mon, 18 Jan 2021 21:48:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <20210118114451.5mpuvgnhhajx4b3y@vireshk-i7> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 18.01.2021 14:44, Viresh Kumar пишет: > On 18-01-21, 03:55, Dmitry Osipenko wrote: >> diff --git a/include/linux/pm_opp.h b/include/linux/pm_opp.h >> index eefd0b15890c..c98fd2add563 100644 >> --- a/include/linux/pm_opp.h >> +++ b/include/linux/pm_opp.h >> @@ -13,6 +13,7 @@ >> >> #include >> #include >> +#include >> #include >> >> struct clk; >> @@ -74,6 +75,7 @@ struct dev_pm_opp_info { >> * @regulator_count: Number of regulators >> * @clk: Pointer to clk >> * @dev: Pointer to the struct device >> + * @kref: Reference counter >> * >> * This structure contains all information required for setting an OPP. >> */ >> @@ -85,6 +87,7 @@ struct dev_pm_set_opp_data { >> unsigned int regulator_count; >> struct clk *clk; >> struct device *dev; >> + struct kref kref; >> }; > > Instead of kref thing, allocate the memory for supplies from > dev_pm_opp_set_regulators() and store it in new entries in opp-table > and for rest of the data from dev_pm_opp_register_set_opp_helper(), to > which you can copy supplies pointers then. > Could you please show a code sample?