From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20A43C43460 for ; Wed, 7 Apr 2021 17:52:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 041526128A for ; Wed, 7 Apr 2021 17:52:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234321AbhDGRwj (ORCPT ); Wed, 7 Apr 2021 13:52:39 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:56641 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229841AbhDGRwj (ORCPT ); Wed, 7 Apr 2021 13:52:39 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1617817949; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=Uf0AVv8aqmiXb0YftRz/h5+MlBMvFR0+UaFhKIo1nCw=; b=qVqRzvmaQKR1Arg5AVnnI1HyPblG1NyvleMG4gFeYMggVV524EWYX9ErDUYvQ9ZKth+J9UlG CffWHKF4QvOLT5o2Msgua3znaJgBdd283Kp379Vv1/TRsnJavmzdZQTg3EW36sq3IbldwbMF NU34ytwncrMFrwmKU8X9GZt8IzE= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 606df152f34440a9d459978c (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 07 Apr 2021 17:52:18 GMT Sender: abhinavk=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 298A8C43466; Wed, 7 Apr 2021 17:52:18 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id 130AAC433ED; Wed, 7 Apr 2021 17:52:17 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 07 Apr 2021 10:52:17 -0700 From: abhinavk@codeaurora.org To: Zhen Lei Cc: Rob Clark , Sean Paul , David Airlie , Daniel Vetter , linux-arm-msm , dri-devel , freedreno , linux-kernel , AngeloGioacchino Del Regno Subject: Re: [Freedreno] [PATCH 1/1] drm/msm/dpu: remove unused local variable 'cmd_enc' In-Reply-To: <20210407083334.2762-1-thunder.leizhen@huawei.com> References: <20210407083334.2762-1-thunder.leizhen@huawei.com> Message-ID: X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2021-04-07 01:33, Zhen Lei wrote: > Fixes the following W=1 kernel build warning: > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c: In function > ‘dpu_encoder_phys_cmd_wait_for_commit_done’: > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c:688:31: warning: > variable ‘cmd_enc’ set but not used [-Wunused-but-set-variable] > > Fixes: fe286893ed34 ("drm/msm/dpu: Remove unused call in > wait_for_commit_done") > Reported-by: Hulk Robot > Signed-off-by: Zhen Lei Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > index b2be39b9144e449..088900841bf8baa 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > @@ -685,10 +685,6 @@ static int > dpu_encoder_phys_cmd_wait_for_tx_complete( > static int dpu_encoder_phys_cmd_wait_for_commit_done( > struct dpu_encoder_phys *phys_enc) > { > - struct dpu_encoder_phys_cmd *cmd_enc; > - > - cmd_enc = to_dpu_encoder_phys_cmd(phys_enc); > - > /* only required for master controller */ > if (!dpu_encoder_phys_cmd_is_master(phys_enc)) > return 0; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC49AC433B4 for ; Wed, 7 Apr 2021 17:52:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97CA46124C for ; Wed, 7 Apr 2021 17:52:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97CA46124C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D31876E94B; Wed, 7 Apr 2021 17:52:23 +0000 (UTC) Received: from m43-7.mailgun.net (m43-7.mailgun.net [69.72.43.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id 392EA6E134 for ; Wed, 7 Apr 2021 17:52:21 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1617817942; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=Uf0AVv8aqmiXb0YftRz/h5+MlBMvFR0+UaFhKIo1nCw=; b=QHk8PICScH/dAmGiCmKrK+SrB9jjL/6qEy8gUZE4WLlmxf7DIR5nsNMtN0gXNzbqcKoNthOE E98TE5C6bG4akz3W4K0COMAkKSP8FygpKGt3ECQdI7/YhkoFcPprHNFrR9l9SWEERNTrRyKa LHHP4RHOiM+daJX81GNdDAqL8HM= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-west-2.postgun.com with SMTP id 606df1522cc44d3aea4b2246 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 07 Apr 2021 17:52:18 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 1A8FAC43465; Wed, 7 Apr 2021 17:52:18 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id 130AAC433ED; Wed, 7 Apr 2021 17:52:17 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 07 Apr 2021 10:52:17 -0700 From: abhinavk@codeaurora.org To: Zhen Lei Subject: Re: [Freedreno] [PATCH 1/1] drm/msm/dpu: remove unused local variable 'cmd_enc' In-Reply-To: <20210407083334.2762-1-thunder.leizhen@huawei.com> References: <20210407083334.2762-1-thunder.leizhen@huawei.com> Message-ID: X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno , David Airlie , linux-arm-msm , linux-kernel , dri-devel , AngeloGioacchino Del Regno , Sean Paul Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gMjAyMS0wNC0wNyAwMTozMywgWmhlbiBMZWkgd3JvdGU6Cj4gRml4ZXMgdGhlIGZvbGxvd2lu ZyBXPTEga2VybmVsIGJ1aWxkIHdhcm5pbmc6Cj4gCj4gZHJpdmVycy9ncHUvZHJtL21zbS9kaXNw L2RwdTEvZHB1X2VuY29kZXJfcGh5c19jbWQuYzogSW4gZnVuY3Rpb24KPiDigJhkcHVfZW5jb2Rl cl9waHlzX2NtZF93YWl0X2Zvcl9jb21taXRfZG9uZeKAmToKPiBkcml2ZXJzL2dwdS9kcm0vbXNt L2Rpc3AvZHB1MS9kcHVfZW5jb2Rlcl9waHlzX2NtZC5jOjY4ODozMTogd2FybmluZzoKPiB2YXJp YWJsZSDigJhjbWRfZW5j4oCZIHNldCBidXQgbm90IHVzZWQgWy1XdW51c2VkLWJ1dC1zZXQtdmFy aWFibGVdCj4gCj4gRml4ZXM6IGZlMjg2ODkzZWQzNCAoImRybS9tc20vZHB1OiBSZW1vdmUgdW51 c2VkIGNhbGwgaW4gCj4gd2FpdF9mb3JfY29tbWl0X2RvbmUiKQo+IFJlcG9ydGVkLWJ5OiBIdWxr IFJvYm90IDxodWxrY2lAaHVhd2VpLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBaaGVuIExlaSA8dGh1 bmRlci5sZWl6aGVuQGh1YXdlaS5jb20+ClJldmlld2VkLWJ5OiBBYmhpbmF2IEt1bWFyIDxhYmhp bmF2a0Bjb2RlYXVyb3JhLm9yZz4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2Rw dTEvZHB1X2VuY29kZXJfcGh5c19jbWQuYyB8IDQgLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNCBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2Rw dTEvZHB1X2VuY29kZXJfcGh5c19jbWQuYwo+IGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2Rw dTEvZHB1X2VuY29kZXJfcGh5c19jbWQuYwo+IGluZGV4IGIyYmUzOWI5MTQ0ZTQ0OS4uMDg4OTAw ODQxYmY4YmFhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2Rw dV9lbmNvZGVyX3BoeXNfY21kLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1 MS9kcHVfZW5jb2Rlcl9waHlzX2NtZC5jCj4gQEAgLTY4NSwxMCArNjg1LDYgQEAgc3RhdGljIGlu dCAKPiBkcHVfZW5jb2Rlcl9waHlzX2NtZF93YWl0X2Zvcl90eF9jb21wbGV0ZSgKPiAgc3RhdGlj IGludCBkcHVfZW5jb2Rlcl9waHlzX2NtZF93YWl0X2Zvcl9jb21taXRfZG9uZSgKPiAgCQlzdHJ1 Y3QgZHB1X2VuY29kZXJfcGh5cyAqcGh5c19lbmMpCj4gIHsKPiAtCXN0cnVjdCBkcHVfZW5jb2Rl cl9waHlzX2NtZCAqY21kX2VuYzsKPiAtCj4gLQljbWRfZW5jID0gdG9fZHB1X2VuY29kZXJfcGh5 c19jbWQocGh5c19lbmMpOwo+IC0KPiAgCS8qIG9ubHkgcmVxdWlyZWQgZm9yIG1hc3RlciBjb250 cm9sbGVyICovCj4gIAlpZiAoIWRwdV9lbmNvZGVyX3BoeXNfY21kX2lzX21hc3RlcihwaHlzX2Vu YykpCj4gIAkJcmV0dXJuIDA7Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo=