From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4BAFC6FD1F for ; Tue, 14 Mar 2023 03:28:29 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 583DE85900; Tue, 14 Mar 2023 04:28:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id E34928587C; Tue, 14 Mar 2023 04:28:24 +0100 (CET) Received: from mail-m11874.qiye.163.com (mail-m11874.qiye.163.com [115.236.118.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 18AE685BFA for ; Tue, 14 Mar 2023 04:28:22 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com Received: from [172.16.12.93] (unknown [58.22.7.114]) by mail-m11874.qiye.163.com (Hmail) with ESMTPA id 599EF3C01A3; Tue, 14 Mar 2023 11:28:05 +0800 (CST) Message-ID: Date: Tue, 14 Mar 2023 11:28:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 08/12] rockchip: tinker-rk3288: Use common BOOT_TARGET_DEVICES Content-Language: en-US To: Jonas Karlman , Simon Glass , Philipp Tomsich , Lin Huang , Michael Trimarchi Cc: Jagan Teki , Eugen Hristev , u-boot@lists.denx.de References: <20230314003755.512696-1-jonas@kwiboo.se> <20230314003755.512696-9-jonas@kwiboo.se> From: Kever Yang In-Reply-To: <20230314003755.512696-9-jonas@kwiboo.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGksfSFZOGkwYHU8dShpOGU1VEwETFh oSFyQUDg9ZV1kYEgtZQVlOQ1VJSVVMVUpKT1lXWRYaDxIVHRRZQVlPS0hVSkpLSEpMVUpLS1VLWQ Y+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PT46KSo6TT0PLS0RHk03DD8R Q0owCzVVSlVKTUxDTE1PT0NNS09MVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFPTEhPNwY+ X-HM-Tid: 0a86de292bc42eb0kusn599ef3c01a3 X-HM-MType: 1 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 2023/3/14 08:38, Jonas Karlman wrote: > Building U-Boot for Tinker Board with USB or NET Kconfig option disabled > result in the following build error: > > In file included from include/configs/rk3288_common.h:29, > from include/configs/tinker_rk3288.h:14, > from include/config.h:3, > from include/common.h:16, > from env/common.c:10: > include/config_distro_bootcmd.h:302:9: error: expected '}' before 'BOOT_TARGET_DEVICES_references_USB_without_CONFIG_CMD_USB' > 302 | BOOT_TARGET_DEVICES_references_USB_without_CONFIG_CMD_USB > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > include/config_distro_bootcmd.h:302:9: note: in definition of macro 'BOOTENV_DEV_NAME_USB' > 302 | BOOT_TARGET_DEVICES_references_USB_without_CONFIG_CMD_USB > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > include/configs/tinker_rk3288.h:21:9: note: in expansion of macro 'BOOTENV_DEV_NAME' > 21 | func(USB, usb, 0) \ > | ^~~~ > include/config_distro_bootcmd.h:454:25: note: in expansion of macro 'BOOT_TARGET_DEVICES' > 454 | "boot_targets=" BOOT_TARGET_DEVICES(BOOTENV_DEV_NAME) "\0" > | ^~~~~~~~~~~~~~~~~~~ > include/config_distro_bootcmd.h:474:9: note: in expansion of macro 'BOOTENV_BOOT_TARGETS' > 474 | BOOTENV_BOOT_TARGETS \ > | ^~~~~~~~~~~~~~~~~~~~ > include/configs/rk3288_common.h:40:9: note: in expansion of macro 'BOOTENV' > 40 | BOOTENV > | ^~~~~~~ > include/env_default.h:122:9: note: in expansion of macro 'CFG_EXTRA_ENV_SETTINGS' > 122 | CFG_EXTRA_ENV_SETTINGS > | ^~~~~~~~~~~~~~~~~~~~~~ > In file included from env/common.c:32: > include/env_default.h:29:36: note: to match this '{' > 29 | const char default_environment[] = { > | ^ > make[2]: *** [scripts/Makefile.build:256: env/common.o] Error 1 > > The BOOT_TARGET_DEVICES defined in rockchip-common.h include the same > devices as defined in tinker_rk3288.h, remove the board specific one to > fix building with USB or NET option disabled. > > Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever > --- > include/configs/tinker_rk3288.h | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/include/configs/tinker_rk3288.h b/include/configs/tinker_rk3288.h > index 269ec529a340..053c9032e2da 100644 > --- a/include/configs/tinker_rk3288.h > +++ b/include/configs/tinker_rk3288.h > @@ -13,13 +13,4 @@ > > #include > > -#undef BOOT_TARGET_DEVICES > - > -#define BOOT_TARGET_DEVICES(func) \ > - func(MMC, mmc, 0) \ > - func(MMC, mmc, 1) \ > - func(USB, usb, 0) \ > - func(PXE, pxe, na) \ > - func(DHCP, dchp, na) > - > #endif