From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752482AbdB1MVS (ORCPT ); Tue, 28 Feb 2017 07:21:18 -0500 Received: from goliath.siemens.de ([192.35.17.28]:49885 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752437AbdB1MVQ (ORCPT ); Tue, 28 Feb 2017 07:21:16 -0500 Subject: Re: [PATCH 0/2] efi: Enhance capsule loader to support signed Quark images To: Matt Fleming References: <1bf3c9d8-56aa-818b-350f-deb62ad14e08@siemens.com> <4014c5e6-b5a0-7552-166f-a42992532c09@siemens.com> <5da59d02-d299-f5c7-48fa-a67bdd017252@siemens.com> <20170228121255.GD28416@codeblueprint.co.uk> Cc: "Kweh, Hock Leong" , "Bryan O'Donoghue" , Andy Shevchenko , Ard Biesheuvel , "linux-efi@vger.kernel.org" , Linux Kernel Mailing List , Borislav Petkov , "Ong, Boon Leong" , "Mok, Tze Siong" From: Jan Kiszka Message-ID: Date: Tue, 28 Feb 2017 13:20:25 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20170228121255.GD28416@codeblueprint.co.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-02-28 13:12, Matt Fleming wrote: > On Fri, 17 Feb, at 10:24:41AM, Jan Kiszka wrote: >> >> I just can re-express my frustration that this essential step hasn't >> been started years ago by whoever designed the extension. Then I bet >> there would have been constructive feedback on the interface BEFORE its >> ugliness spread to broader use. >> >> Or is there a technical need, in general or on Quark, to have the >> signature header right before the standard capsule *for the handover* to >> the firmware? I mean, I would naively put it into another capsule and >> prepend that to the core so that the existing UEFI API can palate it >> transparently and cleanly. > > I'm fairly sure this was my first thought when we discussed this > originally, some years ago now. > > The whole CSH concept is, frankly, stupid. It makes a mockery of > everything the capsule interface was designed to be. > > I have long been holding out in hope that someone would patch the > firmware to work around this CSH requirement, something along the > lines of the double wrapping Jan mentions above. It's not like the > Quark is the only platform that wants to verify capsules. > > But to my knowledge, that hasn't happened. > > Nevertheless my answer is still the same - someone needs to go and > update the Quark firmware source to work with the generic capsule > mechanism. > >>From you POV, does this exclude upstream quirk support for already shipped devices? Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 0/2] efi: Enhance capsule loader to support signed Quark images Date: Tue, 28 Feb 2017 13:20:25 +0100 Message-ID: References: <1bf3c9d8-56aa-818b-350f-deb62ad14e08@siemens.com> <4014c5e6-b5a0-7552-166f-a42992532c09@siemens.com> <5da59d02-d299-f5c7-48fa-a67bdd017252@siemens.com> <20170228121255.GD28416@codeblueprint.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170228121255.GD28416-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matt Fleming Cc: "Kweh, Hock Leong" , Bryan O'Donoghue , Andy Shevchenko , Ard Biesheuvel , "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux Kernel Mailing List , Borislav Petkov , "Ong, Boon Leong" , "Mok, Tze Siong" List-Id: linux-efi@vger.kernel.org On 2017-02-28 13:12, Matt Fleming wrote: > On Fri, 17 Feb, at 10:24:41AM, Jan Kiszka wrote: >> >> I just can re-express my frustration that this essential step hasn't >> been started years ago by whoever designed the extension. Then I bet >> there would have been constructive feedback on the interface BEFORE its >> ugliness spread to broader use. >> >> Or is there a technical need, in general or on Quark, to have the >> signature header right before the standard capsule *for the handover* to >> the firmware? I mean, I would naively put it into another capsule and >> prepend that to the core so that the existing UEFI API can palate it >> transparently and cleanly. > > I'm fairly sure this was my first thought when we discussed this > originally, some years ago now. > > The whole CSH concept is, frankly, stupid. It makes a mockery of > everything the capsule interface was designed to be. > > I have long been holding out in hope that someone would patch the > firmware to work around this CSH requirement, something along the > lines of the double wrapping Jan mentions above. It's not like the > Quark is the only platform that wants to verify capsules. > > But to my knowledge, that hasn't happened. > > Nevertheless my answer is still the same - someone needs to go and > update the Quark firmware source to work with the generic capsule > mechanism. > >>From you POV, does this exclude upstream quirk support for already shipped devices? Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux