All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Eric Blake" <eblake@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>, "Max Reitz" <mreitz@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/4] hw/block/fdc: Replace error_setg(&error_abort) by error_report() + abort()
Date: Wed, 30 May 2018 16:23:19 -0400	[thread overview]
Message-ID: <fba4c1c5-a479-60c6-31e3-99affcacd5b7@redhat.com> (raw)
In-Reply-To: <20180529174821.19964-2-f4bug@amsat.org>



On 05/29/2018 01:48 PM, Philippe Mathieu-Daudé wrote:
> Use error_report() + abort() instead of error_setg(&error_abort),
> as suggested by the "qapi/error.h" documentation:
> 
>     Please don't error_setg(&error_fatal, ...), use error_report() and
>     exit(), because that's more obvious.
>     Likewise, don't error_setg(&error_abort, ...), use assert().
> 

Didn't realize this was bad form (Why do we have it?)

> Use abort() instead of the suggested assert() because the error message
> already got displayed.
> 

Update the suggestion?

> Suggested-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: John Snow <jsnow@redhat.com>
Acked-by: John Snow <jsnow@redhat.com>

  reply	other threads:[~2018-05-30 20:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-29 17:48 [Qemu-devel] [PATCH 0/4] qapi/error: converts error_setg(&error_fatal) to error_report() + exit() Philippe Mathieu-Daudé
2018-05-29 17:48 ` [Qemu-devel] [PATCH 1/4] hw/block/fdc: Replace error_setg(&error_abort) by error_report() + abort() Philippe Mathieu-Daudé
2018-05-30 20:23   ` John Snow [this message]
2018-05-30 21:30     ` Philippe Mathieu-Daudé
2018-06-07 13:41       ` Markus Armbruster
2018-06-07 14:27         ` Philippe Mathieu-Daudé
2018-05-29 17:48 ` [Qemu-devel] [PATCH 2/4] hw/ppc/spapr_drc: " Philippe Mathieu-Daudé
2018-06-04  1:25   ` David Gibson
2018-05-29 17:48 ` [Qemu-devel] [PATCH 3/4] hw/arm/sysbus-fdt: Replace error_setg(&error_fatal) by error_report() + exit() Philippe Mathieu-Daudé
2018-06-07 13:53   ` Markus Armbruster
2018-05-29 17:48 ` [Qemu-devel] [PATCH 4/4] device_tree: " Philippe Mathieu-Daudé
2018-06-07 13:50   ` Markus Armbruster
2018-05-29 19:38 ` [Qemu-devel] [PATCH 0/4] qapi/error: converts error_setg(&error_fatal) to " Auger Eric
2018-06-07 13:48 ` Markus Armbruster
2018-06-07 14:49   ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fba4c1c5-a479-60c6-31e3-99affcacd5b7@redhat.com \
    --to=jsnow@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.